[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Karthikeyan
On Fri, Oct 16, 2020, 12:45 AM Serhiy Storchaka wrote: > 14.10.20 20:56, Brett Cannon пише: > > I think if the project is not maintained externally and thus synced into > > the stdlib we can drop the attributes. > > I have found only one exception. decimal.__version__ refers to the > version of

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Neil Schemenauer
On 2020-10-15, Serhiy Storchaka wrote: > [..] it seems that there are no usages the __version__ variable in > top 4K pypi packages. Given that, I think it's fine to remove them. If we find broken code during the alpha release we still have a chance to revert. However, it would seem quite

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Serhiy Storchaka
14.10.20 20:56, Brett Cannon пише: > I think if the project is not maintained externally and thus synced into > the stdlib we can drop the attributes. I have found only one exception. decimal.__version__ refers to the version of the external specification which was not changed since 2009. I think

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Serhiy Storchaka
15.10.20 14:59, Victor Stinner пише: > If the __version__ variable is used, I suggest to start with a > deprecation period using a module __getattr__(): emit > DeprecationWarning, and only remove these variables in 2 Python > releases (PEP 387). This is a good idea, I though about it. But it

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Serhiy Storchaka
14.10.20 23:25, Batuhan Taskaya пише: > I've indexed a vast majority of the files from top 4K pypi packages to > this system, and here are the results about __version__ usage on > argparse, cgi, csv, decimal, imaplib, ipaddress, optparse, pickle, > platform, re, smtpd, socketserver, tabnanny

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Serhiy Storchaka
14.10.20 23:25, Batuhan Taskaya пише: > I've indexed a vast majority of the files from top 4K pypi packages to > this system, and here are the results about __version__ usage on > argparse, cgi, csv, decimal, imaplib, ipaddress, optparse, pickle, > platform, re, smtpd, socketserver, tabnanny

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Ethan Furman
On 10/15/20 5:45 AM, Erlend Aasland wrote: FYI, sqlite3 has a /pysqlite/ “version" attribute iso. “__version__", stemming from its days outside of stdlib. It has held the value “2.6.0" since commit f9cee22, 2010-03-05. The proposal is to remove dunder version and friends, not plain version

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Paul Moore
On Thu, 15 Oct 2020 at 16:31, Erlend Aasland wrote: > > Actually both sqlite3.version and sqlite3.version_info, the former as a > string, the latter as a tuple. However, sqlite3.sqlite_version and sqlite3.sqlite_version_info should definitely be retained, as they give the version of the sqlite

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Erlend Aasland
Actually both sqlite3.version and sqlite3.version_info, the former as a string, the latter as a tuple. E On 15 Oct 2020, at 14:45, Erlend Aasland mailto:erlen...@innova.no>> wrote: FYI, sqlite3 has a pysqlite “version" attribute iso. “__version__", stemming from its days outside of stdlib.

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Erlend Aasland
FYI, sqlite3 has a pysqlite “version" attribute iso. “__version__", stemming from its days outside of stdlib. It has held the value “2.6.0" since commit f9cee22, 2010-03-05. Erlend E. Aasland On 14 Oct 2020, at 15:53, Serhiy Storchaka mailto:storch...@gmail.com>> wrote: Some module

[Python-Dev] Re: [python-committers] Re: Performance benchmarks for 3.9

2020-10-15 Thread M.-A. Lemburg
On 15.10.2020 15:50, Victor Stinner wrote: > Le mer. 14 oct. 2020 à 17:59, Antoine Pitrou a écrit : >> unpack-sequence is a micro-benchmark. (...) > > I suggest removing it. > > I removed other similar micro-benchmarks from pyperformance in the > past, since they can easily be misunderstood and

[Python-Dev] Re: Changing Python's string search algorithms

2020-10-15 Thread Tim Peters
[Guido] > I am not able to dream up any hard cases -- like other posters, > my own use of substring search is usually looking for a short > string in a relatively short piece of text. I doubt even the current > optimizations matter to my uses. I should have responded to this part differently.

[Python-Dev] Re: Changing Python's string search algorithms

2020-10-15 Thread Tim Peters
[Dennis Sweeney ] > Here's my attempt at some heuristic motivation: Thanks, Dennis! It helps. One gloss: > > The key insight though is that the worst strings are still > "periodic enough", and if we have two different patterns going on, > then we can intentionally split them apart. The

[Python-Dev] Re: [python-committers] Re: Performance benchmarks for 3.9

2020-10-15 Thread Victor Stinner
Le mer. 14 oct. 2020 à 17:59, Antoine Pitrou a écrit : > unpack-sequence is a micro-benchmark. (...) I suggest removing it. I removed other similar micro-benchmarks from pyperformance in the past, since they can easily be misunderstood and misleading. For curious people, I'm keeping a

[Python-Dev] Re: Remove module's __version__ attributes in the stdlib

2020-10-15 Thread Victor Stinner
If the __version__ variable is used, I suggest to start with a deprecation period using a module __getattr__(): emit DeprecationWarning, and only remove these variables in 2 Python releases (PEP 387). sys.version or sys.version_info can be used instead of argparse.__version__, no? Victor Le

[Python-Dev] Re: Changing Python's string search algorithms

2020-10-15 Thread Dennis Sweeney
Here's my attempt at some heuristic motivation: Try to construct a needle that will perform as poorly as possible when using the naive two-nested-for-loops algorithm. You'll find that if there isn't some sort of vague periodicity in your needle, then you won't ever get *that* unlucky; each

[Python-Dev] Re: PEP 638: Syntactic macros

2020-10-15 Thread Dima Tisnek
My 2c as a Python user (mostly) and someone who dabbled in ES2020: The shouting syntax! does not sit well with me. The $hygenic is also cumbersome. To contrast, babel macros: * looks like regular code, without special syntax: existing tooling works, less mental strain * have access to call site

[Python-Dev] Re: Changing Python's string search algorithms

2020-10-15 Thread Greg Ewing
On 15/10/20 1:45 pm, Chris Angelico wrote: So it'd be heuristics in the core language that choose a good default for most situations, and then a str method that returns a preprocessed needle. Or maybe cache the results of the preprocessing? -- Greg