[Python-Dev] Re: [Steering-council] Re: PEP 651, Robust Stack Overflow Handling, Rejection notice

2022-01-30 Thread Gregory P. Smith
-cc: python-steering-council On Fri, Mar 5, 2021 at 4:26 PM Guido van Rossum wrote: > On Fri, Mar 5, 2021 at 11:11 AM Brett Cannon wrote: > >> Speaking for myself ... >> > > Ditto ... > > On Fri, Mar 5, 2021 at 7:04 AM Mark Shannon wrote: >> [...] >> >>> In some cases, the PEP would have impro

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Oscar Benjamin
On Sun, 30 Jan 2022 at 20:36, Steven D'Aprano wrote: > > On Sun, Jan 30, 2022 at 08:36:43AM -0800, Jelle Zijlstra wrote: > > > Agree, the count of 1.6k open PRs is not a good look for new contributors. > > How does that compare to other comparable open source projects? How it compares is a separa

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Steven D'Aprano
On Sun, Jan 30, 2022 at 08:36:43AM -0800, Jelle Zijlstra wrote: > Agree, the count of 1.6k open PRs is not a good look for new contributors. How does that compare to other comparable open source projects? Number of open PRs per KLOC seems like a more useful metric than just the number of open P

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Jelle Zijlstra
El dom, 30 ene 2022 a las 2:40, Irit Katriel via Python-Dev (< python-dev@python.org>) escribió: > > A non-core approval changes the label from "awaiting review" to "awaiting > core review". > Interestingly, it also changes if a non-core dev requests changes (e.g., see https://github.com/python/cp

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Mats Wichmann
On 1/30/22 04:45, Inada Naoki wrote: > On Sun, Jan 30, 2022 at 7:37 PM Irit Katriel > wrote: > Some people may do "approval without review" to make their "Profile" > page richer, because GitHub counts it as a contribution. > Creating spam issues or pull requests can be reported as spam very > ea

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Inada Naoki
On Sun, Jan 30, 2022 at 7:37 PM Irit Katriel wrote: > > If people spam the approvals (i.e., approve PRs without reviewing them) then > the distinction between the labels becomes meaningless, of course. Though I > do wonder what the motivation for doing that repeatedly would be. My basic > assu

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Irit Katriel via Python-Dev
A non-core approval changes the label from "awaiting review" to "awaiting core review". I find this useful, and occasionally filter on "awaiting core review" because it indicates that at least one other person found the PR sound / interesting. I would not like this to change - I think high quality

[Python-Dev] Re: Increase of Spammy PRs and PR reviews

2022-01-30 Thread Ethan Smith
On Sat, Jan 29, 2022 at 7:38 PM Inada Naoki wrote: > On Sun, Jan 30, 2022 at 12:03 PM Ethan Smith wrote: > > > > As a non-committer, I want to make a plea for non-committer approval > reviews, or at least that they have a place. When asked how outsiders can > contribute I frequently see "review