[Python-Dev] Asking for review for Windows issues 21518 and 22080

2015-03-07 Thread Claudiu Popa
Hello, The winreg module has a function for loading a registry key under another registry key, called winreg.LoadKey. Unfortunately, the module doesn't provide a way to unload that key after the user finishes operating with it. There's a patch [1] for exporting the RegUnloadKey [2] API in winreg

Re: [Python-Dev] Division of tool labour in porting Python 2 code to 2/3

2014-06-07 Thread Claudiu Popa
On Fri, Jun 6, 2014 at 7:37 PM, Brett Cannon wrote: > After Glyph and Alex's email about their asks for assisting in writing > Python 2/3 code, it got me thinking about where in the toolchain various > warnings and such should go in order to help direct energy to help develop > whatever future too

[Python-Dev] Questions regarding Windows buildbots

2014-05-12 Thread Claudiu Popa
Hello! I'm working on a patch for issue bugs.python.org/issue8579 (Add missing tests for FlushKey, LoadKey, and SaveKey in winreg). This issue requires the SeBackupPrivilege in order to use LoadKey and SaveKey. While acquiring the privilege isn't very complicated using ctypes, it fails with ERROR_

Re: [Python-Dev] API and process questions (sparked by Claudiu Popa on 16104

2014-04-30 Thread Claudiu Popa
On Tue, Apr 29, 2014 at 11:11 PM, Charles-François Natali wrote: > 2014-04-28 21:24 GMT+01:00 Claudiu Popa : >> [...] >> >> If anyone agrees with the above, then I'll modify the patch. This will >> be its last iteration, any other bikeshedding >> should be

Re: [Python-Dev] API and process questions (sparked by Claudiu Popa on 16104

2014-04-28 Thread Claudiu Popa
This issue raised too much bikeshedding. To wrap it up, I'll modify the patch with the following: - processes renamed to workers - `workers` defaults to 1 - When `workers` is equal to 0, then `os.cpu_count` will be used - When `workers` > 1, multiple processes will be used - When `workers` == 1, r

Re: [Python-Dev] API and process questions (sparked by Claudiu Popa on 16104

2014-04-28 Thread Claudiu Popa
On Mon, Apr 28, 2014 at 6:32 PM, Jim J. Jewett wrote: > (1) Should fixes to a docstring go in with a patch, even if they > aren't related to the changing functionality? > > Bytestring compilation has several orthogonal parameters. Most -- but > not all -- are documented in the docstring. (Speci

[Python-Dev] Patches in need of review

2014-04-23 Thread Claudiu Popa
Hello! This approach worked for Nikolaus and I hope that it could work for me. I have a couple of languishing patches, waiting for a core dev to review, reject or commit them. I consider them ready to go, but another pair of eyes could unveil unknown problems to me. I pinged some issues from this