Re: [Python-Dev] [Python-checkins] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-31 Thread Michael Foord
On 31 Jul 2011, at 02:26, Senthil Kumaran wrote: On Sat, Jul 30, 2011 at 11:11:08PM +0300, Ezio Melotti wrote: -.. class:: SMTP(host='', port=0, local_hostname=None[, timeout]) +.. class:: SMTP(host='', port=0, local_hostname=None[, timeout], source_address=None) The [, timeout] now looks

Re: [Python-Dev] [Python-checkins] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-31 Thread Antoine Pitrou
On Sun, 31 Jul 2011 17:17:00 +0100 Michael Foord fuzzy...@voidspace.org.uk wrote: I found that [, timeout] bit odd too. But is not mentioning that as timeout=None when it is timeout=socket._GLOBAL_DEFAULT_TIME technically inaccurate? It does mean that users will expect to be able to

Re: [Python-Dev] [Python-checkins] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Ezio Melotti
Hi, On 30/07/2011 5.58, senthil.kumaran wrote: http://hg.python.org/cpython/rev/26839edf3cc1 changeset: 71617:26839edf3cc1 parent: 71613:018e14a46454 user:Senthil Kumaransent...@uthcode.com date:Sat Jul 30 10:56:50 2011 +0800 summary: Fix closes Issue11281 -

Re: [Python-Dev] [Python-checkins] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Senthil Kumaran
On Sat, Jul 30, 2011 at 11:11:08PM +0300, Ezio Melotti wrote: -.. class:: SMTP(host='', port=0, local_hostname=None[, timeout]) +.. class:: SMTP(host='', port=0, local_hostname=None[, timeout], source_address=None) The [, timeout] now looks weird there, and it would be better to convert it