Re: [Python-Dev] [Python-checkins] cpython (3.3): - Issue #16514: Fix regression causing a traceback when sys.path[0] is None

2012-11-21 Thread Brett Cannon
On Tue, Nov 20, 2012 at 6:41 PM, Barry Warsaw wrote: > On Nov 20, 2012, at 05:35 PM, Terry Reedy wrote: > > >On 11/20/2012 3:35 PM, barry.warsaw wrote: > > > >> for entry in path: > >> +if not isinstance(entry, (str, bytes)): > >> +continue > > > >Given that

Re: [Python-Dev] [Python-checkins] cpython (3.3): - Issue #16514: Fix regression causing a traceback when sys.path[0] is None

2012-11-20 Thread Barry Warsaw
On Nov 20, 2012, at 05:35 PM, Terry Reedy wrote: >On 11/20/2012 3:35 PM, barry.warsaw wrote: > >> for entry in path: >> +if not isinstance(entry, (str, bytes)): >> +continue > >Given that a non-(str,bytes) entry could indicate a programming error, should >a wa

Re: [Python-Dev] [Python-checkins] cpython (3.3): - Issue #16514: Fix regression causing a traceback when sys.path[0] is None

2012-11-20 Thread Barry Warsaw
On Nov 20, 2012, at 05:12 PM, Brett Cannon wrote: >Should you also insert None into sys.path_importer_cache to signify there >is no finder for the path entry? I guess the real problem with that is >there is no guarantee the path entry is hashable, so that probably won't >work. So nevermind. =) I

Re: [Python-Dev] [Python-checkins] cpython (3.3): - Issue #16514: Fix regression causing a traceback when sys.path[0] is None

2012-11-20 Thread Brett Cannon
Should you also insert None into sys.path_importer_cache to signify there is no finder for the path entry? I guess the real problem with that is there is no guarantee the path entry is hashable, so that probably won't work. So nevermind. =) On Tue, Nov 20, 2012 at 3:35 PM, barry.warsaw wrote: >