Re: [Python-Dev] [Python-checkins] hooks: Fix checkbranch hook

2011-02-27 Thread Daniel Stutzbach
On Sat, Feb 26, 2011 at 11:48 PM, Nick Coghlan wrote: > On Sun, Feb 27, 2011 at 5:26 PM, "Martin v. Löwis" > wrote: > > If you think that it's a likely problem that people create named > > branches by mistake, then we should have a hook. > > I suspect the concern is that people may create named

Re: [Python-Dev] [Python-checkins] hooks: Fix checkbranch hook

2011-02-26 Thread Nick Coghlan
On Sun, Feb 27, 2011 at 5:26 PM, "Martin v. Löwis" wrote: > There is nothing that prevents people from tagging the tree currently > in subversion, but most of the time, only the release manager does any > tagging. > > If you think that it's a likely problem that people create named > branches by m

Re: [Python-Dev] [Python-checkins] hooks: Fix checkbranch hook

2011-02-26 Thread Martin v. Löwis
Am 27.02.2011 00:21, schrieb Éric Araujo: >> Then we will have to fix the hook each time we want to add a new >> legitimate branch. > The alternative is to edit the hook each time we want to remove a former > legitimate branch, plus have another hook to refuse new named branches. The question is w

Re: [Python-Dev] [Python-checkins] hooks: Fix checkbranch hook

2011-02-26 Thread Éric Araujo
> Then we will have to fix the hook each time we want to add a new > legitimate branch. The alternative is to edit the hook each time we want to remove a former legitimate branch, plus have another hook to refuse new named branches. > I have no preference really. Looks like a ±0 to me :) Regards

Re: [Python-Dev] [Python-checkins] hooks: Fix checkbranch hook

2011-02-26 Thread Antoine Pitrou
On Sat, 26 Feb 2011 22:36:47 +0100 Éric Araujo wrote: > > +if branch in ('trunk', 'legacy-trunk', > > + '2.0', '2.1', '2.2', '2.3', '2.4', '3.0'): > > Wouldn’t using a whitelist instead of a blacklist protect against new > named branches too? Then we will have to fix

Re: [Python-Dev] [Python-checkins] hooks: Fix checkbranch hook

2011-02-26 Thread Éric Araujo
> +if branch in ('trunk', 'legacy-trunk', > + '2.0', '2.1', '2.2', '2.3', '2.4', '3.0'): Wouldn’t using a whitelist instead of a blacklist protect against new named branches too? ___ Python-Dev mailing list Python-Dev@python.