It seems appropriate to consult python-dev on this. I thought ValueError was for values that are valid Python objects but out of acceptable range of the function. Errors that can only be triggered in C code normally handled with either assert() or raise SystemError. I think you are splitting hairs too thin by distinguishing between stdlib and 3rd party extensions.
On Thu, Feb 24, 2011 at 4:07 PM, Antoine Pitrou <rep...@bugs.python.org> wrote: > > Antoine Pitrou <pit...@free.fr> added the comment: > >> > I've committed the part of the patch which disallows a NULL data pointer >> > with PyMemoryView_FromBuffer in r88550 and r88551. >> >> Is it possible to create such buffer in Python (other than by >> exploiting a bug or writing a rogue extension module)? If not, this >> should be a SystemError or even just an assert() rather than >> ValueError. > > I'm against asserts for such use, since they get disabled in non-debug > mode (which is the mode 99.99% of users run in). > > As for SystemError, it means "Internal error in the Python interpreter", > which isn't the case here (most likely it's an error in an extension > module instead, possibly a third-party one). > > ---------- > > _______________________________________ > Python tracker <rep...@bugs.python.org> > <http://bugs.python.org/issue11286> > _______________________________________ > _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
