[Python-Dev] Bytcode "magic tag"

2015-10-28 Thread Eric V. Smith
In issue 25483 I'm adding an opcode to make f-string formatting more robust and faster. As part of that, I'm bumping the .pyc magic number. While doing that, I notice Lib/importlib/_bootstrap_external.h includes this comment: # Starting with the adoption of PEP 3147 in Python 3.2, every bump in

Re: [Python-Dev] Bytcode "magic tag"

2015-10-28 Thread Eric V. Smith
On 10/28/2015 10:22 AM, Eric Snow wrote: > On Wed, Oct 28, 2015 at 6:35 AM, Eric V. Smith wrote: >> Do I need to do anything else? Unlike what the comment in >> _boostrap_external.py suggests, this "magic tag" will not change every >> time a bytecode is added, but only on

Re: [Python-Dev] Bytcode "magic tag"

2015-10-28 Thread Eric Snow
On Wed, Oct 28, 2015 at 6:35 AM, Eric V. Smith wrote: > In issue 25483 I'm adding an opcode to make f-string formatting more > robust and faster. As part of that, I'm bumping the .pyc magic number. > > While doing that, I notice Lib/importlib/_bootstrap_external.h includes >

Re: [Python-Dev] Bytcode "magic tag"

2015-10-28 Thread Barry Warsaw
On Oct 28, 2015, at 08:35 AM, Eric V. Smith wrote: >The "following table" is a comment, that contains a few references to >the tag "cpython-", specifically cpython-32. It doesn't seem >that the tag is routinely updated in the comment. IIRC, it used to have to be changed in the code, but with

Re: [Python-Dev] Bytcode "magic tag"

2015-10-28 Thread Eric V. Smith
On 10/28/2015 10:19 AM, Barry Warsaw wrote: > On Oct 28, 2015, at 08:35 AM, Eric V. Smith wrote: > >> The "following table" is a comment, that contains a few references to >> the tag "cpython-", specifically cpython-32. It doesn't seem >> that the tag is routinely updated in the comment. > >

Re: [Python-Dev] Bytcode "magic tag"

2015-10-28 Thread Eric Snow
On Wed, Oct 28, 2015 at 8:28 AM, Eric V. Smith wrote: > Thanks. That part I've done (but forgot to mention). I was just > concerned about the "magic tag" part, which Barry cleared up. Ah, I misread. :) Yeah, that comment is out of date. -eric