[Python-Dev] Code reviews

2012-01-02 Thread Antoine Pitrou
On Mon, 2 Jan 2012 14:44:49 +1000 Nick Coghlan ncogh...@gmail.com wrote: He keeps leaving them out, I occasionally tell him they should always be included (most recently this came up when we gave conflicting advice to a patch contributor). Oh, by the way, this is also why I avoid arguing too

Re: [Python-Dev] Code reviews

2012-01-02 Thread Georg Brandl
On 01/02/2012 03:41 PM, Antoine Pitrou wrote: On Mon, 2 Jan 2012 14:44:49 +1000 Nick Coghlan ncogh...@gmail.com wrote: He keeps leaving them out, I occasionally tell him they should always be included (most recently this came up when we gave conflicting advice to a patch contributor).

Re: [Python-Dev] Code reviews

2012-01-02 Thread francis
On 01/02/2012 06:35 PM, Georg Brandl wrote: On 01/02/2012 03:41 PM, Antoine Pitrou wrote: On Mon, 2 Jan 2012 14:44:49 +1000 Nick Coghlanncogh...@gmail.com wrote: He keeps leaving them out, I occasionally tell him they should always be included (most recently this came up when we gave

Re: [Python-Dev] Code reviews

2012-01-02 Thread Brian Curtin
On Mon, Jan 2, 2012 at 12:26, francis franci...@email.de wrote: On 01/02/2012 06:35 PM, Georg Brandl wrote: On 01/02/2012 03:41 PM, Antoine Pitrou wrote: On Mon, 2 Jan 2012 14:44:49 +1000 Nick Coghlanncogh...@gmail.com  wrote: He keeps leaving them out, I occasionally tell him they should

Re: [Python-Dev] Code reviews

2012-01-02 Thread julien tayon
@francis Like indent ? http://www.linuxmanpages.com/man1/indent.1.php @brian I don't think this is a problem to the point that it needs to be fixed via automation. The code I write is the code I build and test, so I'd rather not have some script that goes in and modifies it to some accepted

Re: [Python-Dev] Code reviews

2012-01-02 Thread Francisco Martin Brugue
On 01/02/2012 10:02 PM, julien tayon wrote: @francis Like indent ? http://www.linuxmanpages.com/man1/indent.1.php Thank you, I wasn't aware of this one ! ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Code reviews

2012-01-02 Thread Barry Warsaw
On Jan 02, 2012, at 06:35 PM, Georg Brandl wrote: Exactly. Especially for reviews of patches from non-core people, we should exercise a lot of restraint: as the committers, I think we can be expected to bite the sour bullet and apply our uniform style (such as it is). It is tiresome, if not