Re: [Python-Dev] feature freeze questions

2012-07-28 Thread Chris Jerdonek
On Sat, Jul 28, 2012 at 6:21 AM, Nick Coghlan wrote: > On Sat, Jul 28, 2012 at 8:25 PM, Chris Jerdonek > wrote: >> Also, this response seems somewhat at odds to the response I got to a >> patch that refactors part of regrest, fixes some bugs in it, and adds >> its first unit tests (in particular,

Re: [Python-Dev] feature freeze questions

2012-07-28 Thread Nick Coghlan
On Sat, Jul 28, 2012 at 8:25 PM, Chris Jerdonek wrote: > Also, this response seems somewhat at odds to the response I got to a > patch that refactors part of regrest, fixes some bugs in it, and adds > its first unit tests (in particular, increasing code coverage): > > http://bugs.python.org/issue1

Re: [Python-Dev] feature freeze questions

2012-07-28 Thread Chris Jerdonek
On Wed, Jul 25, 2012 at 4:29 PM, Benjamin Peterson wrote: >> (2) When adding new tests (e.g. in the course of fixing a bug or >> increasing test coverage), are we allowed to refactor other tests so >> that supporting test code can be shared? Or should the tests be added >> in a less DRY fashion a

Re: [Python-Dev] feature freeze questions

2012-07-26 Thread Georg Brandl
Am 26.07.2012 10:24, schrieb Eli Bendersky: >>> I have a few questions about feature freeze: >>> >>> (1) Is increasing test coverage acceptable during feature freeze, even >>> if it does not involve fixing a bug? >>> >>> (2) When adding new tests (e.g. in the course of fixing a bug or >>> increasin

Re: [Python-Dev] feature freeze questions

2012-07-26 Thread Nick Coghlan
On Thu, Jul 26, 2012 at 6:24 PM, Eli Bendersky wrote: > You cannot skip the peer review during an RC, no matter how small! > Even if it is a simple copy-and-paste change, everything requires peer > review from a core developer. The extra restrictions during RC are more about not doing things

Re: [Python-Dev] feature freeze questions

2012-07-26 Thread Eli Bendersky
>> I have a few questions about feature freeze: >> >> (1) Is increasing test coverage acceptable during feature freeze, even >> if it does not involve fixing a bug? >> >> (2) When adding new tests (e.g. in the course of fixing a bug or >> increasing test coverage), are we allowed to refactor other

Re: [Python-Dev] feature freeze questions

2012-07-25 Thread Benjamin Peterson
2012/7/25 Chris Jerdonek : > I have a few questions about feature freeze: > > (1) Is increasing test coverage acceptable during feature freeze, even > if it does not involve fixing a bug? > > (2) When adding new tests (e.g. in the course of fixing a bug or > increasing test coverage), are we allowe

[Python-Dev] feature freeze questions

2012-07-25 Thread Chris Jerdonek
I have a few questions about feature freeze: (1) Is increasing test coverage acceptable during feature freeze, even if it does not involve fixing a bug? (2) When adding new tests (e.g. in the course of fixing a bug or increasing test coverage), are we allowed to refactor other tests so that suppo

Re: [Python-Dev] Feature Freeze

2012-06-22 Thread Terry Reedy
On 6/22/2012 3:00 PM, Ethan Furman wrote: can somebody review (and commit! :) issues: http://bugs.python.org/issue14954 About weakref, no response yet. Beyond my knowledge. http://bugs.python.org/issue14617 About __hash__, a short response from Éric Araujo I might look at this. -- Terry

Re: [Python-Dev] Feature Freeze

2012-06-22 Thread martin
Zitat von Ethan Furman : Does the feature freeze affect documentation enhancements? No. Incorrect/missing documentation is always a bug (unless there is a debate whether something is an implementation detail or a language feature); bugs can be fixed at any time, and documentation bugs in part

[Python-Dev] Feature Freeze

2012-06-22 Thread Ethan Furman
Does the feature freeze affect documentation enhancements? If it does, can somebody review (and commit! :) issues: http://bugs.python.org/issue14954 http://bugs.python.org/issue14617 Thanks! (And if not necessary before the feature freeze, sorry for the noise.) ~Ethan~ ___