Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Victor Stinner
2017-07-04 16:27 GMT+02:00 Nick Coghlan : > That concern just doesn't apply to the *stdlib* modules doing a normal > top-level "import bisect". Hum, ok. I created a PR which removes '' and Lib/test/ from sys.path, and rename again test.bisectcmd to test.bisect. Would you mind to review it? https:

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Nick Coghlan
On 4 July 2017 at 22:10, Victor Stinner wrote: > 2017-07-04 13:22 GMT+02:00 Nick Coghlan : >> That means if test.bisect is shadowing the top level bisect module >> when backported, it suggests that the test.regrtest directory is >> ending up on sys.path for the affected test run (e.g. because the

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Victor Stinner
2017-07-04 13:22 GMT+02:00 Nick Coghlan : > That means if test.bisect is shadowing the top level bisect module > when backported, it suggests that the test.regrtest directory is > ending up on sys.path for the affected test run (e.g. because the > tests were run as "python Lib/test/regrtest.py" rat

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Nick Coghlan
On 4 July 2017 at 21:03, Victor Stinner wrote: > 2017-07-04 12:52 GMT+02:00 Nick Coghlan : >> I know it's longer, but perhaps it would make sense to put the >> bisection helper under "python -m test.support.bisect" in both Python >> 2 & 3? > > For me, test.support is a toolkit to *write* tests, no

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Lele Gaifax
Nick Coghlan writes: > On 4 July 2017 at 19:55, Victor Stinner wrote: >> On Python 2, the addition of Lib/test/bisect.py caused conflict with >> Lib/bisect.py when running the Python test suite :-( I chose to rename >> Lib/test/bisect.py to Lib/test/bisectcmd.py to reduce changes caused >> by th

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Victor Stinner
2017-07-04 12:52 GMT+02:00 Nick Coghlan : > I know it's longer, but perhaps it would make sense to put the > bisection helper under "python -m test.support.bisect" in both Python > 2 & 3? For me, test.support is a toolkit to *write* tests, not really to run tests. I don't really care where my bis

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Nick Coghlan
On 4 July 2017 at 19:55, Victor Stinner wrote: > On Python 2, the addition of Lib/test/bisect.py caused conflict with > Lib/bisect.py when running the Python test suite :-( I chose to rename > Lib/test/bisect.py to Lib/test/bisectcmd.py to reduce changes caused > by this new debug tool. So only in

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-07-04 Thread Victor Stinner
On Python 2, the addition of Lib/test/bisect.py caused conflict with Lib/bisect.py when running the Python test suite :-( I chose to rename Lib/test/bisect.py to Lib/test/bisectcmd.py to reduce changes caused by this new debug tool. So only in Python 2.7, you have to run: ./python -m test.bisectcm

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-30 Thread Victor Stinner
Another example to bisect "Running test_warnings twice fails" bug: http://bugs.python.org/issue30812 --- haypo@selma$ ./python -m test.bisect -o bisect test_warnings test_warnings (...) Tests (1): * test.test_warnings._WarningsTests.test_showwarnmsg_missing (...) Bisection completed in 14 iterati

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-27 Thread Zachary Ware
On Tue, Jun 27, 2017 at 11:52 PM, Terry Reedy wrote: > Are you testing for refleaks with gui enabled? Yes; the refleak builders are running on my Gentoo and Windows workers, both of which (should have, at least) GUI available and enabled. However, I have caught Xvfb not running properly on the G

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-27 Thread Terry Reedy
On 6/27/2017 8:39 PM, Victor Stinner wrote: 2017-06-27 7:33 GMT+02:00 Serhiy Storchaka : You could make it just a submodule in the test package. ./python -m test.bisect -R 3:3 test_os I like the idea :-) I proposed a PR which was approved by Yury Selivanov, and so I just merged it! It me

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-27 Thread Eric V. Smith
That's great, Victor. Thanks for all of your work on this. Eric. On 6/27/2017 8:39 PM, Victor Stinner wrote: 2017-06-27 7:33 GMT+02:00 Serhiy Storchaka : You could make it just a submodule in the test package. ./python -m test.bisect -R 3:3 test_os I like the idea :-) I proposed a PR w

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-27 Thread Victor Stinner
2017-06-27 7:33 GMT+02:00 Serhiy Storchaka : > You could make it just a submodule in the test package. > > ./python -m test.bisect -R 3:3 test_os I like the idea :-) I proposed a PR which was approved by Yury Selivanov, and so I just merged it! It means that you can now play with "./python -m

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-26 Thread Serhiy Storchaka
26.06.17 23:37, Victor Stinner пише: 2017-06-26 21:58 GMT+02:00 Brett Cannon : I don't see why regrtest isn't the right place for this. The current regrest CLI isn't designed for subcommands, and I don't want to "pollute" regrtest with multiple options for bisect. Currently, my script has alre

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-26 Thread Brett Cannon
On Mon, 26 Jun 2017 at 13:38 Victor Stinner wrote: > 2017-06-26 21:58 GMT+02:00 Brett Cannon : > > I don't see why regrtest isn't the right place for this. > > The current regrest CLI isn't designed for subcommands, and I don't > want to "pollute" regrtest with multiple options for bisect. > Curr

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-26 Thread Victor Stinner
2017-06-26 21:58 GMT+02:00 Brett Cannon : > I don't see why regrtest isn't the right place for this. The current regrest CLI isn't designed for subcommands, and I don't want to "pollute" regrtest with multiple options for bisect. Currently, my script has already 4 options: haypo@selma$ python3 ~/

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-26 Thread Brett Cannon
On Mon, 26 Jun 2017 at 09:38 Victor Stinner wrote: > Hi, > > I updated my bisect_test.py script to simplify its command line: > >https://github.com/haypo/misc/blob/master/python/bisect_test.py > > To debug a reference leak in test_os, now just type: > >$ ./python bisect_test.py -R 3:3 tes

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-26 Thread Victor Stinner
Hi, I updated my bisect_test.py script to simplify its command line: https://github.com/haypo/misc/blob/master/python/bisect_test.py To debug a reference leak in test_os, now just type: $ ./python bisect_test.py -R 3:3 test_os Example of output: --- (...) Failing tests (1): * test.test_o

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-16 Thread Victor Stinner
2017-06-16 19:00 GMT+02:00 Brett Cannon : > Great idea! I had thought about doing something similar to this years ago to > help diagnose when a test passes in isolation but somehow fails due to one > of the bazillion of other tests that ran previously (which can be hard to > narrow down if the fail

Re: [Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-16 Thread Brett Cannon
Great idea! I had thought about doing something similar to this years ago to help diagnose when a test passes in isolation but somehow fails due to one of the bazillion of other tests that ran previously (which can be hard to narrow down if the failure is not early on in a test run). On Fri, 16 Ju

[Python-Dev] New work-in-progress bisection tool for the Python test suite (in regrtest)

2017-06-16 Thread Victor Stinner
Hi, Last weeks, I worked on a new tool to bisect failing tests because it's painful to bisect manually reference leaks (I remove as much code as possible until the code is small enough to be reviewable manually). See the bisect_test.py script attached to this issue: http://bugs.python.org/issue29