Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Steven D'Aprano
Steven D'Aprano wrote: Greg Ewing wrote: Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? I think that, depending on the typeface you view it with, it is supposed to be some sort of smiley: two big wide open square eyes with tightly pursed lips. Presumably it is supposed to be a

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Steven D'Aprano
Greg Ewing wrote: Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? I think that, depending on the typeface you view it with, it is supposed to be some sort of smiley: two big wide open square eyes with tightly pursed lips. Presumably it is supposed to be a look of shock and surpr

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Antoine Pitrou
On Sun, 18 Dec 2011 13:09:16 +1300 Greg Ewing wrote: > Matt Joiner wrote: > > ಠ_ಠ > > What's up with these ?_? messages? >>> print(ascii("ಠ_ಠ")) '\u0ca0_\u0ca0' Antoine. ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailm

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Greg Ewing
Matt Joiner wrote: ಠ_ಠ What's up with these ?_? messages? -- Greg ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-arch

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Michael Mueller
On Sat, Dec 17, 2011 at 5:02 AM, Benjamin Peterson wrote: > 2011/12/17 Michael Mueller : >> >> Hopefully someone can take a look and determine the appropriate fix. > > Fixed. > > -- > Regards, > Benjamin Excellent! -- Mike Mueller Phone: (401) 405-1525 Email: mmuel...@vigilantsw.com http://www

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Eli Collins
On Sat, Dec 17, 2011 at 11:20 AM, Benjamin Peterson wrote: > > No. The descr will deallocate it. > > PS. Please don't send HTML mail. > Thank you for the explanation. And my apologies to the entire list for the HTML; it's way too early for me, I forgot to turn that mess off.

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Benjamin Peterson
2011/12/17 Eli Collins > > In that same code, right before "PY_DECREF(descr)", should there also be a > "PY_XDECREF(type)"? it looks like it might leak a reference to "type" > otherwise. No. The descr will deallocate it. PS. Please don't send HTML mail. -- Regards, Benjamin ___

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Eli Collins
In that same code, right before "PY_DECREF(descr)", should there also be a "PY_XDECREF(type)"? it looks like it might leak a reference to "type" otherwise. the line in question - http://hg.python.org/cpython/file/8c355edc5b1d/Objects/descrobject.c#l628 - Eli Collins On Sat, Dec 17, 2011 at 8:02

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Benjamin Peterson
2011/12/17 Michael Mueller : > > Hopefully someone can take a look and determine the appropriate fix. Fixed. -- Regards, Benjamin ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http:/

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Georg Brandl
On 12/17/2011 11:33 AM, Matt Joiner wrote: > ಠ_ಠ Would you please stop this? It may have been funny the first time, but now it looks like pure trolling. Georg ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/py

Re: [Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Matt Joiner
ಠ_ಠ On Sat, Dec 17, 2011 at 8:55 PM, Michael Mueller wrote: > Hi Guys, > > We've been analyzing CPython with our static analysis tool (Sentry) > and a NULL pointer dereference popped up the other day, in > Objects/descrobject.c: > >    if (descr != NULL) { >        Py_XINCREF(type); >        desc

[Python-Dev] Potential NULL pointer dereference in descrobject.c

2011-12-17 Thread Michael Mueller
Hi Guys, We've been analyzing CPython with our static analysis tool (Sentry) and a NULL pointer dereference popped up the other day, in Objects/descrobject.c: if (descr != NULL) { Py_XINCREF(type); descr->d_type = type; descr->d_name = PyUnicode_InternFromString(name);