Re: [Python-Dev] Preserving the blamelist

2006-04-16 Thread Martin v. Löwis
Tim Peters wrote: > Since we're spread across time zones, I think 24 hours is a good > minimum. Ok, done. > If something is set to 12 hours now, doesn't look like it's > working: when I wrote my msg, it showed (as I said) about 5 hours of > history. Right now it shows only about 3 hrs, from Sa

Re: [Python-Dev] Preserving the blamelist

2006-04-15 Thread Tim Peters
[Tim] >> All the trunk buildbots started failing about 5 hours ago, in >> test_parser. There have been enough checkins since then that the >> boundary between passing and failing is about to scroll off forever. [Martin] > It's not lost, though; it's just not displayed anymore. It would be > possi

Re: [Python-Dev] Preserving the blamelist

2006-04-13 Thread Thomas Wouters
On Wed, Apr 12, 2006 at 01:16:04AM -0400, Tim Peters wrote: > I'd whine about not checking buildbot health after a code change, > except that it's much more tempting to point out that Thomas couldn't > have run the test suite successfully on his own box in this case :-) Not with -uall, yes. Witho

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Neal Norwitz
On 4/12/06, A.M. Kuchling <[EMAIL PROTECTED]> wrote: > On Wed, Apr 12, 2006 at 01:43:43PM -0400, Tim Peters wrote: > > BTW, someone looking for an easy task might enjoy rewriting other > > tp_traverse slots to use Py_VISIT. We even have cases now (like > > super_traverse) where modules define thei

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread A.M. Kuchling
On Wed, Apr 12, 2006 at 01:43:43PM -0400, Tim Peters wrote: > BTW, someone looking for an easy task might enjoy rewriting other > tp_traverse slots to use Py_VISIT. We even have cases now (like > super_traverse) where modules define their own workalike > traverse-visit macros, which has become con

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Tim Peters
[Tim] >> Phillip, when eyeballing gen_dealloc(), I didn't understand two things: >> >> 1. Why doesn't >> >> if (gen->gi_frame->f_stacktop!=NULL) { >> >>check first to be sure that gen->gi_frame != Py_None? [Phillip] > Apparently, it's because I'm an idiot, and because nobody else reali

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Tim Peters
[Tim ] >> I'd whine about not checking buildbot health after a code change, >> except that it's much more tempting to point out that Thomas couldn't >> have run the test suite successfully on his own box in this case :-) [Thomas] > Not with -uall, yes. Without -uall it ran fine (by chance, I admit

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Phillip J. Eby
At 03:00 AM 4/12/2006 -0400, Tim Peters wrote: >Phillip, when eyeballing gen_dealloc(), I didn't understand two things: > >1. Why doesn't > > if (gen->gi_frame->f_stacktop!=NULL) { > >check first to be sure that gen->gi_frame != Py_None? Apparently, it's because I'm an idiot, and becau

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Neal Norwitz
On 4/12/06, "Martin v. Löwis" <[EMAIL PROTECTED]> wrote: > > The failures might have nothing to with the changes, though: It appears > that some files are still left from earlier tests, and now the setUp > code fails because /tmp/dir already exists... That was my guess. I went in and cleaned up a

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Martin v. Löwis
Tim Peters wrote: > All the trunk buildbots started failing about 5 hours ago, in > test_parser. There have been enough checkins since then that the > boundary between passing and failing is about to scroll off forever. It's not lost, though; it's just not displayed anymore. It would be possible

Re: [Python-Dev] Preserving the blamelist

2006-04-12 Thread Tim Peters
[Neal] >> ... >> I'm concerned about the negative ref leak in test_contextlib. I >> wonder if this was a result of PJE's fix for generators? [Tim] > I don't know, but if you do > > while 1: > test_contextlib.test_main() > gc.collect() > > under a debug build it eventually (> 500 iteration

Re: [Python-Dev] Preserving the blamelist

2006-04-11 Thread Tim Peters
[Neal Norwitz] > ... > I'm concerned about the negative ref leak in test_contextlib. I > wonder if this was a result of PJE's fix for generators? I don't know, but if you do while 1: test_contextlib.test_main() gc.collect() under a debug build it eventually (> 500 iterations) crashes wi

Re: [Python-Dev] Preserving the blamelist

2006-04-11 Thread Neal Norwitz
On 4/11/06, Tim Peters <[EMAIL PROTECTED]> wrote: > > I'd whine about not checking buildbot health after a code change, > except that it's much more tempting to point out that Thomas couldn't > have run the test suite successfully on his own box in this case :-) Tsk, tsk, Thomas. Should be fixed

[Python-Dev] Preserving the blamelist

2006-04-11 Thread Tim Peters
All the trunk buildbots started failing about 5 hours ago, in test_parser. There have been enough checkins since then that the boundary between passing and failing is about to scroll off forever. So, here's the blamelist before it vanishes: """ 1. Changed by: thomas.wouters Chang