[Python-Dev] Re: [Python-checkins]python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-21 Thread Fredrik Lundh
Armin Rigo wrote: > Some code in the 'py' lib used to use marshal to send simple objects between > the main process and a subprocess. We ran into trouble when we extended the > idea to a subprocess that would actually run via ssh on a remote machine, and > the remote machine's Python version didn

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Raymond Hettinger
[Armin] > Crash.  Which means that there is no way in 2.4.0 to marshal an object in the > > old version format as a string -- you'd have to work around by writing a real > > file and reading it back :-( [Aahz] > Brown bag time? Perhaps a rather quick Py2.4.1 would be in order.   Ideally, it shoul

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Barry Warsaw
On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > Perhaps a rather quick Py2.4.1 would be in order. +1 -Barry signature.asc Description: This is a digitally signed message part ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.o

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Jeremy Hylton
On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: > On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > > > Perhaps a rather quick Py2.4.1 would be in order. > > +1 Nothing wrong with an incremental release, but none of these sound like critical bugs to me. Jeremy

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Irmen de Jong
Raymond Hettinger wrote: Perhaps a rather quick Py2.4.1 would be in order. Ideally, it should include other important fixes: [...] * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Is http://www.python.org/sf/1062060 perhaps of similar im

RE: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Raymond Hettinger
> Raymond Hettinger wrote: > > Perhaps a rather quick Py2.4.1 would be in order. > > > > Ideally, it should include other important fixes: > [...] > > * Fix for off-by-one bug in urllib.URLopener.retrieve > >http://www.python.org/sf/810023 > >(assigned to me) > > Is http://www.python.org/s

Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Irmen de Jong
Raymond Hettinger wrote: * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Is http://www.python.org/sf/1062060 perhaps of similar importance? (fix for urllib.urlretrieve silently truncating download) That seems reasonable to me. There is n

Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Tim Delaney
Irmen de Jong wrote: Also, I'm not sure how a test-case should be constructed for this patch? Can the Python regression test download stuff as part of a test? Or is there some other way to make a testcase for this. Hmm - perhaps start a server on the local machine at the start of the test, and tea

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Aahz
On Mon, Dec 20, 2004, Jeremy Hylton wrote: > On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: >> On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: >>> >>> Perhaps a rather quick Py2.4.1 would be in order. >> >> +1 > > Nothing wrong with an incremental release, but

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Jeremy Hylton
On Mon, 20 Dec 2004 18:25:39 -0500, Aahz <[EMAIL PROTECTED]> wrote: > On Mon, Dec 20, 2004, Jeremy Hylton wrote: > > On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: > >> On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > >>> > >>> Perhaps a rather quick Py2.4.1 woul

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-20 Thread Tim Peters
[Jeremy Hylton on a quick 2.4.1] >>> Nothing wrong with an incremental release, but none of these sound >>> like critical bugs to me. [Aahz] >> You don't think a blowup in marshal is critical? Mind expanding on >> that? [Jeremy] > An undocumented extension to marshal causes a segfault. It's > c

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-21 Thread Armin Rigo
Hi Tim, On Mon, Dec 20, 2004 at 07:26:25PM -0500, Tim Peters wrote: > Still, it's a new-in-2.4 gimmick, and no pre-2.4 code could be using > it. I suppose Armin found a use for it in 2.4, but I'm still > scratching my head. If ZODB doesn't already depend on it, how useful > can it be? QED Some

Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-21 Thread Irmen de Jong
Tim Delaney wrote: Irmen de Jong wrote: Also, I'm not sure how a test-case should be constructed for this patch? Can the Python regression test download stuff as part of a test? Or is there some other way to make a testcase for this. Hmm - perhaps start a server on the local machine at the start o

Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-21 Thread Johannes Gijsbers
On Tue, Dec 21, 2004 at 08:00:22PM +0100, Irmen de Jong wrote: > Thanks for those suggestions. > Let's see what I can concoct. > > Never made (or studied in detail) a python regression test case > before so now is a good time :) You might be especially interested in 'class urlopen_HttpTests' in t

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-21 Thread Tim Peters
[Armin Rigo] > Some code in the 'py' lib used to use marshal to send simple objects between > the main process and a subprocess. We ran into trouble when we extended the > idea to a subprocess that would actually run via ssh on a remote machine, and > the remote machine's Python version didn't mat

Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80

2004-12-22 Thread Armin Rigo
Hi Tim, On Tue, Dec 21, 2004 at 05:21:29PM -0500, Tim Peters wrote: > > we reverted to repr/eval, which is quite slower (and actually not > > guaranteed to > > work across Python versions either: string escapes sometimes change). > > Really? The precise rules str's __repr__ uses for which escap