[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-13 Thread Antoine Pitrou
On Thu, 13 Jun 2019 02:07:54 +0200 Victor Stinner wrote: > > For PyCodeOptions: does it contain posonlyargcount? If not, how do you > pass posonlyargcount. I'm not sure if you plan to handle the backward > compatibility. The idiom to use it could be: PyCodeOptions opts = PyCodeOptions_INIT; //

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-12 Thread Victor Stinner
Hi Antoine, In Python 3.4, I added "void PyMem_SetAllocator(PyMemAllocatorDomain domain, PyMemAllocator *allocator)" to the public C API. Problem: we wanted to add a new "calloc" field to PyMemAllocator structure. I chose to rename the structure to PyMemAllocatorEx to ensure that all C

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-12 Thread Antoine Pitrou
On Wed, 12 Jun 2019 00:09:10 +0200 Victor Stinner wrote: > Update. > > Le ven. 31 mai 2019 à 10:49, Petr Viktorin a écrit : > > PEP 570 (Positional-Only Parameters) changed the signatures of > > PyCode_New() and types.CodeType(), adding a new argument for "posargcount". > > > > Pablo

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-12 Thread Paul Ganssle
I'm not one of the people who ever shipped pre-cythonized code, but I think at this point it should be pretty safe to ship just your .pyx files and not the generated C files - at least if your reason for shipping the C code was "it will be hard for people to pip install things". For /other/

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-12 Thread Brett Cannon
Petr Viktorin wrote: > On 6/12/19 7:40 AM, Stefan Behnel wrote: > > Victor Stinner schrieb am 12.06.19 um 00:09: > > So yeah, the PyCode_New() change is very annoying > > in practical, since > > every single project using Cython requires a new release in practice. > > I think Cython's deal

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-12 Thread Brett Cannon
Victor Stinner wrote: > Update. > > Le ven. 31 mai 2019 à 10:49, Petr Viktorin > PEP 570 (Positional-Only Parameters) changed the > > signatures of > > PyCode_New() and types.CodeType(), adding a new argument for "posargcount". > > > Pablo proposed a PR to revert PyCode_New() API to Python

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-12 Thread Petr Viktorin
On 6/12/19 7:40 AM, Stefan Behnel wrote: Victor Stinner schrieb am 12.06.19 um 00:09: So yeah, the PyCode_New() change is very annoying in practical, since every single project using Cython requires a new release in practice. I think Cython's deal with regard to this is: """ If you use

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-11 Thread Stefan Behnel
Victor Stinner schrieb am 12.06.19 um 00:09: > So yeah, the PyCode_New() change is very annoying in practical, since > every single project using Cython requires a new release in practice. I think Cython's deal with regard to this is: """ If you use Cython, we will try hard to cover up the

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-11 Thread Stefan Behnel
Neil Schemenauer schrieb am 08.06.19 um 22:46: > It would be great if we had a system that did CI testing with the > top PyPI modules. E.g. pull the latest versions of the top 100 PyPI > modules and test them with the latest CPython branch. FWIW, travis-ci provides the latest CPython master

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-11 Thread Victor Stinner
Update. Le ven. 31 mai 2019 à 10:49, Petr Viktorin a écrit : > PEP 570 (Positional-Only Parameters) changed the signatures of > PyCode_New() and types.CodeType(), adding a new argument for "posargcount". Pablo proposed a PR to revert PyCode_New() API to Python 3.7 API:

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-10 Thread Brett Cannon
Neil Schemenauer wrote: > On 2019-05-31, Simon Cross wrote: > > As the maintainer of Genshi, one the libraries > > affected by the CodeType and > > similar changes, I thought I could add a users perspective to the > > discussion: [...] > > Thanks. I think this change to PyCode_New() could

[Python-Dev] Re: Expected stability of PyCode_New() and types.CodeType() signatures

2019-06-08 Thread Neil Schemenauer
On 2019-05-31, Simon Cross wrote: > As the maintainer of Genshi, one the libraries affected by the CodeType and > similar changes, I thought I could add a users perspective to the > discussion: [...] Thanks. I think this change to PyCode_New() could have been handled a bit better. Couldn't we