On 3/22/2021 8:51 PM, Senthil Kumaran wrote:
Given this discussion, I am motivated to review this and merge this
into stdlib. The conversation was helpful to me to understand for
utility value of the method introduced by the patch.
I had stated in the PR as well.
Thank you, both, Faisal and Jaku
Given this discussion, I am motivated to review this and merge this
into stdlib. The conversation was helpful to me to understand for
utility value of the method introduced by the patch.
I had stated in the PR as well.
Thank you, both, Faisal and Jakub.
On Mon, Mar 22, 2021 at 5:40 PM Jakub Stasi
> On 22 Mar 2021, at 13:07, Faisal Mahmood wrote:
>
> Thanks Jakub, I wasn't aware of the netaddr library but just gave it a play
> and it does seem very similar and I think it's very useful and completely
> valid.
>
> I think the subtle difference is also that my implementation allows you t
Thanks Jakub, I wasn't aware of the netaddr library but just gave it a play
and it does seem very similar and I think it's very useful and completely
valid.
I think the subtle difference is also that my implementation allows you to
specify the next prefix as well, so it won't just find the next pr
> On 20 Mar 2021, at 04:39, Guido van Rossum wrote:
>
> Honestly this is an example of a module that would have been better off
> outside the stdlib.
>
> On Fri, Mar 19, 2021 at 14:43 Senthil Kumaran wrote:
> On Mon, Feb 15, 2021 at 8:36 AM Faisal Mahmood
> wrote:
> >
> > Hello,
> >
> > I h
Thank you for taking the time to look at this. I do agree with Guido to an
extent, the ipaddress module is by far the most comprehensive and useful
standard IP library I've seen in a programming language, I was surprised
when I first found it's existence. But being fairly new to Python, I
assumed
Honestly this is an example of a module that would have been better off
outside the stdlib.
On Fri, Mar 19, 2021 at 14:43 Senthil Kumaran wrote:
> On Mon, Feb 15, 2021 at 8:36 AM Faisal Mahmood
> wrote:
> >
> > Hello,
> >
> > I hope you are all well, I currently have an issue / merge request th
On Mon, Feb 15, 2021 at 8:36 AM Faisal Mahmood
wrote:
>
> Hello,
>
> I hope you are all well, I currently have an issue / merge request that has
> become stale and as per the guidelines I am sending this e-mail to request
> someone to review it for me please.
>
> Issue Number: 42861 (https://bug
On Fri, Mar 19, 2021 at 9:29 AM Faisal Mahmood
wrote:
> Hello,
>
> Following my previous e-mail last month, thank you for responding. I
> almost immediately got two reviewers who posted helpful comments on my PR
> which I believe have all been resolved now.
>
> Today, I got a notification to say
On Fri, 19 Mar 2021 at 17:26, Hasan Diwan wrote:
>
> For the side question, you can always use rebase instead of merge. Let me
> know if you need further particulars? -- H
There should be no need though, as the Python project has a policy of
squash-merging all PRs.
Paul
For the side question, you can always use rebase instead of merge. Let me
know if you need further particulars? -- H
On Fri, 19 Mar 2021 at 09:31, Faisal Mahmood
wrote:
> Hello,
>
> Following my previous e-mail last month, thank you for responding. I
> almost immediately got two reviewers who
Hello,
Following my previous e-mail last month, thank you for responding. I
almost immediately got two reviewers who posted helpful comments on my PR
which I believe have all been resolved now.
Today, I got a notification to say my branch is stale again so wanted to
understand what the next step
12 matches
Mail list logo
