[Python-Dev] Re: What is the pyclbr public API?

2021-01-29 Thread Guido van Rossum
+1 On Fri, Jan 29, 2021 at 6:28 PM Terry Reedy wrote: > On 1/29/2021 8:57 PM, Guido van Rossum wrote: > > On Fri, Jan 29, 2021 at 5:39 PM Terry Reedy > > wrote: > > > > Guido, thank you for the helpful discussion. I now think that we > > should > > just

[Python-Dev] Re: What is the pyclbr public API?

2021-01-29 Thread Terry Reedy
On 1/29/2021 8:57 PM, Guido van Rossum wrote: On Fri, Jan 29, 2021 at 5:39 PM Terry Reedy > wrote: Guido, thank you for the helpful discussion.  I now think that we should just add 'end_lineno=None' at the end of the Function/Class __init__ signatures. 

[Python-Dev] Re: What is the pyclbr public API?

2021-01-29 Thread Guido van Rossum
On Fri, Jan 29, 2021 at 5:39 PM Terry Reedy wrote: > Guido, thank you for the helpful discussion. I now think that we should > just add 'end_lineno=None' at the end of the Function/Class __init__ > signatures. pyclbr makes one call to each to contruct the tree it > returns, and the test

[Python-Dev] Re: What is the pyclbr public API?

2021-01-29 Thread Terry Reedy
Guido, thank you for the helpful discussion. I now think that we should just add 'end_lineno=None' at the end of the Function/Class __init__ signatures. pyclbr makes one call to each to contruct the tree it returns, and the test functions make another call to each. If those are the only two

[Python-Dev] Re: What is the pyclbr public API?

2021-01-28 Thread Guido van Rossum
On Thu, Jan 28, 2021 at 8:08 PM Terry Reedy wrote: > On 1/27/2021 7:01 PM, Guido van Rossum wrote: > > It's likely that the additions are going to break someone's code; > > Since at least 2007, when Georg moved the 3i reST tree into the 3k > branch, the instances have been described as

[Python-Dev] Re: What is the pyclbr public API?

2021-01-28 Thread Terry Reedy
On 1/27/2021 7:01 PM, Guido van Rossum wrote: It's likely that the additions are going to break someone's code; Since at least 2007, when Georg moved the 3i reST tree into the 3k branch, the instances have been described as "Class/Function Descriptor Objects", returned by readmodule(_ex),

[Python-Dev] Re: What is the pyclbr public API?

2021-01-27 Thread Guido van Rossum
It's likely that the additions are going to break someone's code; the question seems to be do we care, since the constructors are undocumented? But shouldn't we just document the signatures, so that in the future we're not going to make the same mistake? I also wonder if some judicious use of