Re: [Python-Dev] Source of truth for C-API

2019-01-27 Thread Nick Coghlan
On Thu, 24 Jan 2019 at 02:56, Victor Stinner wrote: > > I suggest you to add a new function and leaves the existing function > unchanged. "Just in case". > > You may deprecate the old functions at the same time using Py_DEPRECATED(). And potentially put an underscore in front of the new ones (or

Re: [Python-Dev] Source of truth for C-API

2019-01-23 Thread Victor Stinner
I suggest you to add a new function and leaves the existing function unchanged. "Just in case". You may deprecate the old functions at the same time using Py_DEPRECATED(). Victor Le mer. 23 janv. 2019 à 17:44, Ivan Levkivskyi a écrit : > > I added to extra parameters to each, see >

Re: [Python-Dev] Source of truth for C-API

2019-01-23 Thread Ivan Levkivskyi
I added to extra parameters to each, see https://github.com/python/cpython/pull/11605/files#diff-d350c56a842065575842defb8aaa9f27 -- Ivan On Wed, 23 Jan 2019 at 16:41, Victor Stinner wrote: > What is your change? Did you remove these functions? Change their > parameters? > > Victor > > Le mer.

Re: [Python-Dev] Source of truth for C-API

2019-01-23 Thread Victor Stinner
What is your change? Did you remove these functions? Change their parameters? Victor Le mer. 23 janv. 2019 à 16:24, Ivan Levkivskyi a écrit : > > Thanks for advice Victor and Steve! > > I looked at the list, and the two functions I mentioned are not in the list. > So I assume the best strategy

Re: [Python-Dev] Source of truth for C-API

2019-01-23 Thread Ivan Levkivskyi
Thanks for advice Victor and Steve! I looked at the list, and the two functions I mentioned are not in the list. So I assume the best strategy for now is to wait until first alpha-beta releases are out, and see if anyone complains. -- Ivan On Wed, 23 Jan 2019 at 06:58, Steve Dower wrote: >

Re: [Python-Dev] Source of truth for C-API

2019-01-22 Thread Steve Dower
On 22Jan.2019 1517, Victor Stinner wrote: > I'm not aware of any tool to automatically list the content of the C API. The shell script attached to https://bugs.python.org/issue23903 should be able to do it with different preprocessor values (we originally intended to detect inconsistencies in the

Re: [Python-Dev] Source of truth for C-API

2019-01-22 Thread Victor Stinner
I consider that frameobject.h is also part of the C API, even if it's not included by Python.h. For example, PyFrame_GetLineNumber() is part of the C API, it's just that you have to explicitly #include "frameobject.h". I'm not aware of any tool to automatically list the content of the C API.

[Python-Dev] Source of truth for C-API

2019-01-22 Thread Ivan Levkivskyi
Hi, I recently modified signatures of two functions PyNode_AddChild() and PyParser_AddToken(). These two functions are not listed in C-API docs on docs.python.org, and are not included in Python.h. However, their names look like they may be part of C-API. So there appeared a question, what is the