[Python-Dev] Vestigial code in threadmodule?

2005-06-02 Thread A.M. Kuchling
Looking at bug #1209880, the following function from threadmodule.c is referenced. I think the args==NULL case, which can return None instead of a Boolean value, can never be reached because PyArg_ParseTuple() will fail if args==NULL. Before ripping the args==NULL code out, I wanted to be sure

Re: [Python-Dev] Vestigial code in threadmodule?

2005-06-02 Thread Neal Norwitz
On 6/2/05, A.M. Kuchling [EMAIL PROTECTED] wrote: Looking at bug #1209880, the following function from threadmodule.c is referenced. I think the args==NULL case, which can return None instead of a Boolean value, can never be reached because PyArg_ParseTuple() will fail if args==NULL.

Re: [Python-Dev] Vestigial code in threadmodule?

2005-06-02 Thread Jeremy Maxfield
If you're digging into the threadmodule.c could you take a look at bug #1163563 (http://sourceforge.net/tracker/index.php?func=detailaid=1163563group_id=5470atid=105470) I've posted a patch (http://sourceforge.net/tracker/index.php? func=detailaid=1203393group_id=5470atid=305470) Regards, Max

Re: [Python-Dev] Vestigial code in threadmodule?

2005-06-02 Thread Tim Peters
[A.M. Kuchling] Looking at bug #1209880, the following function from threadmodule.c is referenced. I think the args==NULL case, which can return None instead of a Boolean value, can never be reached because PyArg_ParseTuple() will fail if args==NULL. It would assert-fail in a debug build.