Re: [Python-Dev] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Antoine Pitrou
Hi Senthil, +if source_address: self.source_address = source_address Could you try to follow PEP 8? (I know PEP 8 is not always followed in old code, but there's no reason not to follow it in code that we add to the stdlib) +SMTP.__init__(self, host, port, local_hostname =

Re: [Python-Dev] cpython: Fix closes Issue11281 - smtplib.STMP gets source_address parameter, which adds

2011-07-30 Thread Senthil Kumaran
Hello Antoine, On Sat, Jul 30, 2011 at 08:46:00AM +0200, Antoine Pitrou wrote: (I know PEP 8 is not always followed in old code, but there's no reason not to follow it in code that we add to the stdlib) Thanks for pointing out. I somehow overlooked it. I shall refactor that lib. Unless