On Thu, Apr 19, 2012 at 12:21 AM, Antoine Pitrou wrote:
> I don't think INCREFs were necessary, actually.
> PyDict_SetItemString doesn't steal a reference.
Yes, I was tired when that checkin went by and my brain didn't
register that the function was otherwise using borrowed refs for name
and path
On 19/04/12 11:22, Tres Seaver wrote:
Maybe we should mandate that their names end with '_rtfm'.
+1
--
Greg
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mai
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 04/18/2012 06:48 PM, Greg Ewing wrote:
> Functions with ref-stealing APIs really ought to have a naming
> convention that makes them stand out and remind you to consult the
> documentation.
Maybe we should mandate that their names end with '_rtfm'
Antoine Pitrou wrote:
(and here we see why reference-stealing APIs are a nuisance: because
you never know in advance whether a function will steal a reference or
not, and you have to read the docs for each and every C API call you
make)
Fortunately, they're very rare, so you don't encounter
th
On Wed, Apr 18, 2012 at 8:21 AM, Antoine Pitrou wrote:
> (and here we see why reference-stealing APIs are a nuisance: because
> you never know in advance whether a function will steal a reference or
> not, and you have to read the docs for each and every C API call you
> make)
+1
-eric
_
On Wed, 18 Apr 2012 15:31:10 +0200
brian.curtin wrote:
> http://hg.python.org/cpython/rev/bf23a6c215f6
> changeset: 76388:bf23a6c215f6
> parent: 76385:6762b943ee59
> user:Brian Curtin
> date:Wed Apr 18 08:30:51 2012 -0500
> summary:
> Fix email post-commit review comments
