Re: [Python-Dev] cpython: simplify and rewrite the zipimport part of 702009f3c0b1 a bit

2012-05-28 Thread Guido van Rossum
On Sat, May 26, 2012 at 2:07 AM, Larry Hastings wrote: > > On 05/25/2012 10:14 AM, Antoine Pitrou wrote: > > On Fri, 25 May 2012 18:57:57 +0200 > Georg Brandl wrote: > > This is probably minor, but wouldn't it make more sense to have those > constants uppercased? At least that's the general styl

Re: [Python-Dev] cpython: simplify and rewrite the zipimport part of 702009f3c0b1 a bit

2012-05-26 Thread Larry Hastings
On 05/25/2012 10:14 AM, Antoine Pitrou wrote: On Fri, 25 May 2012 18:57:57 +0200 Georg Brandl wrote: This is probably minor, but wouldn't it make more sense to have those constants uppercased? At least that's the general style we have in the codebase for enum values. +1, this surprised me to

Re: [Python-Dev] cpython: simplify and rewrite the zipimport part of 702009f3c0b1 a bit

2012-05-25 Thread Antoine Pitrou
On Fri, 25 May 2012 18:57:57 +0200 Georg Brandl wrote: > Am 25.05.2012 07:54, schrieb benjamin.peterson: > > http://hg.python.org/cpython/rev/a47d32a28662 > > changeset: 77129:a47d32a28662 > > user:Benjamin Peterson > > date:Thu May 24 22:54:15 2012 -0700 > > summary: > > sim

Re: [Python-Dev] cpython: simplify and rewrite the zipimport part of 702009f3c0b1 a bit

2012-05-25 Thread Georg Brandl
Am 25.05.2012 07:54, schrieb benjamin.peterson: > http://hg.python.org/cpython/rev/a47d32a28662 > changeset: 77129:a47d32a28662 > user:Benjamin Peterson > date:Thu May 24 22:54:15 2012 -0700 > summary: > simplify and rewrite the zipimport part of 702009f3c0b1 a bit > > files: