Re: [Python-Dev] httplib and bad response chunking

2006-07-31 Thread Greg Ward
[me, on 25 July] I have discovered other hypothetical cases of bad chunking that cause httplib to go into an infinite loop or block forever on socket.readline(). Should we worry about those cases as well, despite not having seen them happen in the wild? More annoying, I can reproduce the

Re: [Python-Dev] httplib and bad response chunking

2006-07-30 Thread Gregory P. Smith
On Tue, Jul 25, 2006 at 10:32:13PM -0400, Greg Ward wrote: what I discovered in the wild the other day was a response like this: 0005\r\nabcd\n\r\n0004\r\nabc\n\r\n\r\n i.e. the chunk-size for the terminating empty chunk was missing. This cause httplib.py to blow up with ValueError

[Python-Dev] httplib and bad response chunking

2006-07-28 Thread Greg Ward
So I accidentally discovered the other day that httplib does not handle a particular type of mangled HTTP response very well. In particular, it tends to blow up with an undocumented ValueError when the server screws up chunked encoding. I'm not the first to discover this, either: see

Re: [Python-Dev] httplib and bad response chunking

2006-07-28 Thread John J Lee
On Tue, 25 Jul 2006, Greg Ward wrote: [...] Where I'm getting hung up is how far to test this stuff. Stop when you run out of time ;-) I have discovered other hypothetical cases of bad chunking that cause httplib to go into an infinite loop or block forever on socket.readline(). Should we