[Python-Dev] internal weakref API should be Py_ssize_t?

2006-08-01 Thread Neal Norwitz
I'm wondering if the following change should be made to Include/weakrefobject.h: -PyAPI_FUNC(long) _PyWeakref_GetWeakrefCount(PyWeakReference *head); +PyAPI_FUNC(Py_ssize_t) _PyWeakref_GetWeakrefCount(PyWeakReference *head); And the 2 other files which use this (weakref obj and module). Should t

Re: [Python-Dev] internal weakref API should be Py_ssize_t?

2006-08-01 Thread Tim Peters
[Neal Norwitz] > I'm wondering if the following change should be made to > Include/weakrefobject.h: Yes. > -PyAPI_FUNC(long) _PyWeakref_GetWeakrefCount(PyWeakReference *head); > +PyAPI_FUNC(Py_ssize_t) _PyWeakref_GetWeakrefCount(PyWeakReference *head); > > And the 2 other files which use this (w

Re: [Python-Dev] internal weakref API should be Py_ssize_t?

2006-08-01 Thread Fred L. Drake, Jr.
Neal Norwitz wrote: > I'm wondering if the following change should be made to > Include/weakrefobject.h: On Wednesday 02 August 2006 00:53, Tim Peters wrote: > Yes. ... > +1 on biting the bullet for 2.5. Agreed. This should definately go with the rest of the Py_ssize_t changes. -Fred --