Re: [Python-Dev] static analysis of python source

2007-04-21 Thread Kristján Valur Jónsson
python-dev@python.org Subject: Re: [Python-Dev] static analysis of python source Kristján Valur Jónsson schrieb: > I see. There appear to be two fixes, one for the dots, and another for the > quotetabs. > Shouldn't this be backported? Apparently I wasn't sure at the time. You now c

Re: [Python-Dev] static analysis of python source

2007-04-21 Thread Georg Brandl
Kristján Valur Jónsson schrieb: > I see. There appear to be two fixes, one for the dots, and another for the > quotetabs. > Shouldn't this be backported? Apparently I wasn't sure at the time. You now checked in one half of the fix, and put an exclamation mark at the wrong point (I assume that's

Re: [Python-Dev] static analysis of python source

2007-04-21 Thread Kristján Valur Jónsson
n.org Subject: Re: [Python-Dev] static analysis of python source > The final ((data[in] != '\t') || (data[in] != ' ')) is always > true. What is the right form? ((data[in] == '\t') || (data[in] == ' ')

Re: [Python-Dev] static analysis of python source

2007-04-21 Thread Georg Brandl
Kristján Valur Jónsson schrieb: > I just ran some static analysis of the python core 2.5 with Visual > Studio team system. > > There was the stray error discovered. I will update the most obvious ones. > > > > Some questions, though: > > > > This code in binascii.c, line 1168 (and again

[Python-Dev] static analysis of python source

2007-04-20 Thread Kristján Valur Jónsson
I just ran some static analysis of the python core 2.5 with Visual Studio team system. There was the stray error discovered. I will update the most obvious ones. Some questions, though: This code in binascii.c, line 1168 (and again 1238) is wrong: while (in < datalen) { if ((data[in