[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread Andrew Barnert via Python-ideas
On Sep 8, 2019, at 14:44, Tim Peters wrote: > > From my POV, the audience for complex gamma is relatively tiny Agreed. Especially people who need complex gamma who aren’t dealing with arrays (in which case you’d have to use scipy anyway). Also, I suspect different uses might actually need diff

[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread Tim Peters
More a question for Mark Dickinson - he added math.gamma, not me ;-) There was a bpo issue opened about this over 8 years ago, but it was closed 6 years ago "due to lack of interest": https://bugs.python.org/issue11012 In general, adding hairy stuff to cmath is painful, and just minimizing t

[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread Guido van Rossum
That's a question for Tim Peters. On Sun, Sep 8, 2019 at 9:48 PM Andrew Barnert via Python-ideas < python-ideas@python.org> wrote: > On Sep 7, 2019, at 18:07, davidgmoril...@gmail.com wrote: > > > > Since the gamma function (see > https://en.wikipedia.org/wiki/Gamma_function) is defined for compl

[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread Andrew Barnert via Python-ideas
On Sep 7, 2019, at 18:07, davidgmoril...@gmail.com wrote: > > Since the gamma function (see https://en.wikipedia.org/wiki/Gamma_function) > is defined for complex numbers too, wouldn't it be normal to have it > implemented on the `cmath` module? The `math` module has this function, but > it doe

[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread Guido van Rossum
Maybe you can start by publishing a Python implementation? On Sun, Sep 8, 2019 at 16:48 David García wrote: > Since cmath module is implemented on C, and my C level is really basic, I > do not feel confident enough to submit a PR, but I encourage a more > experienced developer to do it. I must s

[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread David García
Since cmath module is implemented on C, and my C level is really basic, I do not feel confident enough to submit a PR, but I encourage a more experienced developer to do it. I must say too that I'm new to the python community, therefore I don't know the following steps I should take. Thanks in a

[Python-ideas] Re: Add gamma function to cmath module

2019-09-08 Thread Guido van Rossum
I don't know, but maybe you can look into submitting a PR that adds cmath.gamma? (I would first create an issue on bugs.python.org where you can have more discussion about the PR.) Maybe when implementing it you'll find the reason why it isn't defined yet... On Sun, Sep 8, 2019 at 1:45 PM wrote: