Re: [Python-ideas] zipfile refactor and AES

2019-06-04 Thread Steven D'Aprano
On Mon, Jun 03, 2019 at 09:24:03PM +, Steve Barnes wrote: > One specific pain point with zipfile is that if you zip a directory > that contains the target zip file you end up trying to add the target > file to itself which leads to a rapidly growing archive. If that is accurate, it probably

Re: [Python-ideas] zipfile refactor and AES

2019-06-03 Thread Daniel Hillier
Robert Collins wrote: > Is it API compatible with the current zipfile module docs? Yes it should be (that was my intention during the refactor and if I accidentally introduced an incompatibility, I'll fix that up before I attempt to integrate the work). I had a look through the docs again and I ca

Re: [Python-ideas] zipfile refactor and AES

2019-06-03 Thread Steve Barnes
: Python-Ideas Subject: Re: [Python-ideas] zipfile refactor and AES This sounds like a valuable refactoring to me. Is it API compatible with the current zipfile module docs? On Mon, 3 Jun 2019, 20:23 Daniel Hillier, mailto:dhillierc...@gmail.com>> wrote: Hi, I've written a package th

Re: [Python-ideas] zipfile refactor and AES

2019-06-03 Thread Robert Collins
This sounds like a valuable refactoring to me. Is it API compatible with the current zipfile module docs? On Mon, 3 Jun 2019, 20:23 Daniel Hillier, wrote: > Hi, > > I've written a package that can read and write zip files encrypted with > Winzip's AES encryption scheme (https://github.com/danif

[Python-ideas] zipfile refactor and AES

2019-06-03 Thread Daniel Hillier
Hi, I've written a package that can read and write zip files encrypted with Winzip's AES encryption scheme (https://github.com/danifus/pyzipper/). It is based on Python's zipfile module which I refactored to facilitate adding the AES code as subclasses of the classes defined in the zipfile module.