Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15425
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15484
___
Nick Coghlan added the comment:
Updated the statement docs to accurately describe the from X import Y case.
I also noted that unlike the statement form, importlib.import_module ignores
module level __import__ overrides.
--
___
Python tracker
Richard Oudkerk added the comment:
Richard, can the issue be closed?
I guess so (although the change could arguably be back ported).
Pickling of Exception classes is still somewhat dodgy because an example like
class Error(Exception):
def __init__(self, x):
Andrew Svetlov added the comment:
Add patch for py3k
--
assignee: - asvetlov
keywords: +patch
nosy: +asvetlov
versions: +Python 3.2, Python 3.3
Added file: http://bugs.python.org/file26574/issue12288.diff
___
Python tracker rep...@bugs.python.org
Changes by Richard Oudkerk shibt...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
type: crash - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6056
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
title: Python 2.7.1 tkSimpleDialog initialvalue - tkinter SimpleDialog
initialvalue
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12288
Nick Coghlan added the comment:
Nothing too complicated - just noting that a test suite like ours that launches
Python subprocesses to test process global state handling could fairly easily
arrange to pass appropriate -C options to trigger things like recording
coverage data or profiling
Richard Oudkerk added the comment:
One example is 'srcdir': this value is only useful in the build tree and
there currently is no clean way to signal that you are retrieving a
value that is not useful.
In the particular case of 'srcdir', sysconfig.is_python_build() tells you
whether the
Christian Heimes added the comment:
Thanks Stefan and Nick!
I tried to find the off-by-one bug myself but gave up quickly. Stefan's rewrite
is a better approach.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12834
Ned Batchelder added the comment:
I'm -0.5 myself, though, for the reason that it complicates the startup
process a little bit more, without looking very compelling. It smells
disturbingly like LD_PRELOAD to me.
Antoine, do you have a suggestion for how to solve the coverage.py problem? To
New submission from Serhiy Storchaka:
Here is a patch that implements correct __sizeof__ for C implementation of
buffered I/O files: io.BufferedReader, io.BufferedWriter and io.BufferedRandom.
--
components: IO, Library (Lib)
messages: 166756
nosy: benjamin.peterson, hynek, pitrou,
Chris Jerdonek added the comment:
The unit tests added here are another candidate for the refactoring in issue
15403 (Refactor package creation support code into a common location). I'll
note this in that issue.
--
nosy: +cjerdonek
___
Python
Hynek Schlawack added the comment:
There is no patch.
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15487
___
___
Chris Jerdonek added the comment:
Lib/test/test_import.py also contains test code that would benefit from this
(see for example issue 15425). (Though not all files need to be refactored in
a single issue.)
--
___
Python tracker
Chris Jerdonek added the comment:
The test cases uploaded to issue 7559 (TestLoader.loadTestsFromName swallows
import errors) a while back contain a number of distinct cases (four, I think)
in which an import error can be raised. IIRC, these include a couple recursive
scenarios (cyclical
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
nosy: +cjerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14803
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file26575/bufferedio_sizeof.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15487
Richard Oudkerk added the comment:
But I observe that the same script(with proper modification of file names)
works very well under Linux. After I dive into the source code, I found
Python use execvpe to invoke the child process which _will_ use the PATH
variable to search the executable.
Chris Jerdonek added the comment:
Ned, two questions: in the scenario you just described, is it a requirement
that your test suite's code need not be modified (even minimally) to support
coverage of subprocesses?
And can the solution assume that the test suite is spawning the Python
Antoine Pitrou added the comment:
I'm -0.5 myself, though, for the reason that it complicates the startup
process a little bit more, without looking very compelling. It smells
disturbingly like LD_PRELOAD to me.
Antoine, do you have a suggestion for how to solve the coverage.py
Stefan Krah added the comment:
Nick, are you talking about a complete backport or just about pulling
in all functions needed by PyBuffer_ToContiguous()?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12834
Ned Batchelder added the comment:
Chris:
The real problem is that it isn't the test suite that spawns the processes,
the tests invoke product code, and the product code spawns Python. So
modifying the Python-spawning really means modifying the product code to do
something different under
Roundup Robot added the comment:
New changeset efade142ef01 by Martin v. Löwis in branch '3.2':
Issue #15467: Move helpers for __sizeof__ tests into test_support.
http://hg.python.org/cpython/rev/efade142ef01
New changeset d43ff8eb4cb3 by Martin v. Löwis in branch 'default':
Issue #15467: Merge
Roundup Robot added the comment:
New changeset fa95b04e67fd by Martin v. Löwis in branch '2.7':
Issue #15467: Move helpers for __sizeof__ tests into test_support.
http://hg.python.org/cpython/rev/fa95b04e67fd
--
___
Python tracker
Antoine Pitrou added the comment:
Instead of putting this in MiscIOTest, you could use the relevant
class-specific test cases.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15487
___
Martin v. Löwis added the comment:
I wasn't aware that test_support isn't public API. The patches are fine then;
committed.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15467
Antoine Pitrou added the comment:
This is an elegant solution, +1 from me.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
___
Antoine Pitrou added the comment:
Please let's not have something called test.supportlib in addition to
test.support. If test.support grows too large we can turn it into a package.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Chris Jerdonek added the comment:
I understand that. Sorry, I meant to say code under test.
If you make no assumptions about spawning subprocesses, does this mean, for
example, that the solution must satisfy the case of subprocesses invoking a
different version of Python, or invoking the
Chris Jerdonek added the comment:
I feel like it is already too large (it is over 1750 lines), and I did not want
to create a third sibling test support module (there is also
test/script_helper.py that overlaps with test.support). Do you think that the
community would be open to refactoring
Antoine Pitrou added the comment:
I feel like it is already too large (it is over 1750 lines), and I did
not want to create a third sibling test support module (there is also
test/script_helper.py that overlaps with test.support). Do you think
that the community would be open to refactoring
Cheer Xiao added the comment:
There is a bigger problem:
class C:
... class D:
... pass
...
repr(C)
class '__main__.C'
repr(C.D)
class '__main__.D'
Default repr on nested classes produce specious results.
The problem become pratical when you have two nested classes C1.D and
Chris Jerdonek added the comment:
At this point, would you advise me to add even more to the existing hodge
podge, or to create a third sibling test support module? My patch adds closely
related test support functionality.
Incidentally, this discussion relates to the point I was getting at
Atsuo Ishimoto added the comment:
+1 for keeping the file name unchanged. This solution is not very
compatible with prior versions, but simple and least-surprise.
I prefer other platforms than Windows to use same method to build OSError.
--
___
Antoine Pitrou added the comment:
I don't mind refactoring test support routines in maintenance release. I
said it was too late for 3.3 because the beta period is closing; but it
could be fine for 3.3.1 ;)
As for the way forward, I see three possibilites:
1) put everying in test.support, as a
Changes by Meador Inge mead...@gmail.com:
--
stage: - committed/rejected
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15467
___
Ned Batchelder added the comment:
Chris, I'm not sure how to answer your questions. The more powerful and
flexible, the better. There is no must here. I'm looking for a way to avoid
the hacks coverage.py has used in the past to measure coverage in subprocesses.
A language feature that
Serhiy Storchaka added the comment:
Patches updated on Meador's remarks. Tests updated to use new test.support
helpers.
--
Added file: http://bugs.python.org/file26576/itertools_sizeof-3.3-2.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26577/itertools_sizeof-3.2-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15475
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26578/itertools_sizeof-2.7-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15475
___
Serhiy Storchaka added the comment:
Sorry, on Martin's remarks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15475
___
___
Python-bugs-list
Martin v. Löwis added the comment:
rhettinger: users frequently need sys.getsizeof. See, for example,
http://stackoverflow.com/questions/1331471/in-memory-size-of-python-stucture
http://stackoverflow.com/questions/449560/how-do-i-determine-the-size-of-an-object-in-python
Meador Inge added the comment:
Serhiy, I didn't analyze it too in depth, but why aren't the test cases using
the __sizeof__ support work you implemented for issue15467? I think these
tests should be using the more exact method like your other '__sizeof__'
patches.
--
nosy:
Serhiy Storchaka added the comment:
Instead of putting this in MiscIOTest, you could use the relevant
class-specific test cases.
Thank you, good advice. Here is updated patch.
--
Added file: http://bugs.python.org/file26579/bufferedio_sizeof-2.patch
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
___
___
Python-bugs-list
Chris Jerdonek added the comment:
Okay, then in the interest of understanding why various alternatives fail, I'll
just throw out the suggestion or question that I had in mind because I don't
see it mentioned above or on the web page.
Why wouldn't it work to define an alias or script that
Serhiy Storchaka added the comment:
Serhiy, I didn't analyze it too in depth, but why aren't the test cases
using the __sizeof__ support work you implemented for issue15467? I think
these tests should be using the more exact method like your other
'__sizeof__' patches.
Because struct has
Chris Jerdonek added the comment:
Thanks for your thoughts. For the purposes of this patch, I will change to
putting the new support functionality in test.support. Going forward, if we
could do some of the refactoring for 3.3.1, that would be great. :)
I worry that the third option may make
Antoine Pitrou added the comment:
Are you opposed to (2), or is it simply less favorable?
Less favorable, because it produces longer import strings
(test.support.some_helper instead of test.some_helper).
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
sys.getsizeof is certainly CPython-specific. However, __sizeof__ is not
just an implementation detail of sys.getsizeof, just as __len__ is not an
implementation detail of len(). Authors of extension types are supposed to
implement it if object.__sizeof__
Chris Jerdonek added the comment:
Less favorable, because it produces longer import strings
(test.support.some_helper instead of test.some_helper).
This can be addressed by exposing the API in __init__.py though (as does, say,
the unittest package), no?
--
Georg Brandl added the comment:
Please reopen if you think it should be backported.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1692335
___
Roundup Robot added the comment:
New changeset 8a02a93c803a by Antoine Pitrou in branch '3.2':
Issue #15487: Add a __sizeof__ implementation for buffered I/O objects.
http://hg.python.org/cpython/rev/8a02a93c803a
New changeset 1d811e1097ed by Antoine Pitrou in branch 'default':
Issue #15487:
Antoine Pitrou added the comment:
Le dimanche 29 juillet 2012 à 17:00 +, Chris Jerdonek a écrit :
Chris Jerdonek added the comment:
Less favorable, because it produces longer import strings
(test.support.some_helper instead of test.some_helper).
This can be addressed by exposing the
Roundup Robot added the comment:
New changeset 1102e86b8739 by Antoine Pitrou in branch '2.7':
Issue #15487: Add a __sizeof__ implementation for buffered I/O objects.
http://hg.python.org/cpython/rev/1102e86b8739
--
___
Python tracker
Antoine Pitrou added the comment:
Thanks for the patch :)
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15487
Martin v. Löwis added the comment:
I think there is one difference between __len__ and __sizeof__. __sizeof__
should be overloaded only for C-implemented classes. IMHO, it is a part of C
API.
That is a reasonable point. So documenting it along with the type slots
might be best.
--
Vinay Sajip added the comment:
As far as your other suggestion goes, don't reinvent crypto badly -
if you want to provide authentication support in listener(), provide a
hook that allows the application to decide whether or not to accept
the configuration before it gets applied.
Well,
Antoine Pitrou added the comment:
That said, given the nature of the patch (a cleanup without any functional
impact), I don't think it should be a release blocker.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
Meador Inge added the comment:
On Sun, Jul 29, 2012 at 11:50 AM, Serhiy Storchaka rep...@bugs.python.org
wrote:
Serhiy, I didn't analyze it too in depth, but why aren't the test cases
using the __sizeof__ support work you implemented for issue15467? I think
these tests should be using the
Antoine Pitrou added the comment:
Le dimanche 29 juillet 2012 à 17:45 +, Meador Inge a écrit :
Anyway, the way you are implementing the tests has the same issue as Martin
pointed
out for the 'object.__sizeof__' method in issue15402. I could replace the
'buffered_sizeof' implementation
New submission from Antoine Pitrou:
f = open(LICENSE, rb)
sys.getsizeof(f)
4296
f.close()
sys.getsizeof(f)
4296
Instead of waiting for the file object's deallocation, perhaps we should free
the buffer when it is closed?
--
components: IO, Library (Lib)
messages: 166801
nosy:
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +benjamin.peterson, hynek, stutzbach
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
___
Python-bugs-list
Stefan Mihaila added the comment:
Only an issue in Python2.
A.B.__qualname__
'A.B'
repr(A.B)
class '__main__.A.B'
--
nosy: +mstefanro
versions: +Python 2.6, Python 2.7
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
What I understand you two as saying is that there seems to be an undocumented
difference in execxxe between unix and windows which has been carried over to
subprocess. In particular, for both, the PATH component of the env parameter is
used to search for the
Benjamin Peterson added the comment:
Sounds reasonable to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Patches updated. Now __sizeof__ is O(1) as Martin advised.
--
Added file: http://bugs.python.org/file26580/deque_sizeof-3.3-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15469
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26581/deque_sizeof-3.2-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15469
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26582/deque_sizeof-2.7-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15469
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26585/bytesio_sizeof-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15489
___
New submission from Serhiy Storchaka:
Here is a patch that implements correct __sizeof__ for C implementation of
io.BytesIO.
--
components: IO, Library (Lib)
files: bytesio_sizeof-3.3.patch
keywords: patch
messages: 166806
nosy: benjamin.peterson, hynek, pitrou, storchaka, stutzbach
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26584/bytesio_sizeof-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15489
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26588/stringio_sizeof-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15490
___
New submission from Serhiy Storchaka:
Here is a patch that implements correct __sizeof__ for C implementation of
io.StringIO.
I haven't tested the patch on narrow build.
--
components: IO, Library (Lib)
files: stringio_sizeof-3.3.patch
keywords: patch
messages: 166807
nosy:
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26587/stringio_sizeof-3.2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15490
___
Antoine Pitrou added the comment:
Here is a patch that implements correct __sizeof__ for C implementation of
io.StringIO.
For some value of correct, since the internal accumulator could hold
alive some unicode strings.
I haven't tested the patch on narrow build.
There's no narrow build
Chris Jerdonek added the comment:
In working on the patch for this issue, I also noticed that there is a minor
error in the documentation of the replace_whitespace attribute.
The docs say that string.whitespace is used, but the code uses a hard-coded
string and includes a comment explaining
New submission from Chris Jerdonek:
I'm not sure if I'm filing this in the right place since I don't see
hg.python.org in the tracker components list, but if one clicks on the
Browse online link of the Dev Guide here:
http://docs.python.org/devguide/
One is taken to--
Chris Jerdonek added the comment:
Sorry, that link should have been--
http://hg.python.org/cpython/file/1d811e1097ed/Lib/textwrap.py#l12
(hg.python.org seems to default to the 2.7 branch. I just filed an issue about
this.)
--
___
Python tracker
Serhiy Storchaka added the comment:
For some value of correct, since the internal accumulator could hold
alive some unicode strings.
This is not a concern of __sizeof__, because these lists and strings are
managed by GC.
There's no narrow build anymore on 3.3.
I mean 2.7 and 3.2. I have
Antoine Pitrou added the comment:
For some value of correct, since the internal accumulator could hold
alive some unicode strings.
This is not a concern of __sizeof__, because these lists and strings are
managed by GC.
It is, since they are private and not known by the user.
Martin v. Löwis added the comment:
The question really is what memory blocks can leak out of the object, and
those don't really belong to the container. Those shouldn't be accounted for,
since somebody else may get hold of them, and pass them to sys.sizeof.
For the PyAccu, AFAICT, objects
New submission from Chris Jerdonek:
While working on issue 1859, I noticed that textwrap.wrap()'s tab expansion
does not seem to behave sensibly.
In particular, the documentation says, If expand_tabs is true, then all tab
characters in text will be expanded to zero or more spaces, *depending
Chris Jerdonek added the comment:
If people are interested, I filed a new issue (issue 15492) about textwrap's
tab expansion that I noticed while working on this issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1859
Richard Oudkerk added the comment:
What I understand you two as saying is that there seems to be an
undocumented difference in execxxe between unix and windows which has been
carried over to subprocess.
No. There is no difference between the platforms in the behaviour of
os.execvpe().
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +belopolsky, ezio.melotti, rhettinger
stage: - patch review
type: enhancement - behavior
versions: +Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 1d3155750808 by Antoine Pitrou in branch '3.2':
Issue #15489: Add a __sizeof__ implementation for BytesIO objects.
http://hg.python.org/cpython/rev/1d3155750808
New changeset 917295aaad76 by Antoine Pitrou in branch 'default':
Issue #15489: Add a
Antoine Pitrou added the comment:
Thank you!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15489
___
Roundup Robot added the comment:
New changeset 0529e2062ec7 by Ezio Melotti in branch 'default':
#15491: link to the file list of the default branch.
http://hg.python.org/devguide/rev/0529e2062ec7
--
nosy: +python-dev
___
Python tracker
Antoine Pitrou added the comment:
The snapshot of py3k link has the same issue.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15491
___
New submission from Antoine Pitrou:
The Daily OS X installer link in the devguide points to an empty directory
(http://www.python.org/dev/daily-dmg/).
--
components: Devguide
messages: 166822
nosy: ezio.melotti, ned.deily, pitrou, ronaldoussoren
priority: low
severity: normal
status:
Ned Deily added the comment:
It looks like the buildbot is still building them:
http://buildbot.python.org/all/buildslaves/bolen-dmg
I'm not sure who set up the web site link.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 54ec1b493006 by Ezio Melotti in branch 'default':
#15491: change a couple more links to point to the default branch.
http://hg.python.org/devguide/rev/54ec1b493006
--
___
Python tracker
Ezio Melotti added the comment:
So there may be three issues here:
(1) the Dev Guide links to the revision list rather than directly
to the browser,
This is now fixed.
(2) browsing defaults to browsing 2.7 rather than the default branch,
This is fixed as well. FTR it's not defaulting to
Antoine Pitrou added the comment:
It looks like the buildbot is still building them:
http://buildbot.python.org/all/buildslaves/bolen-dmg
I'm not sure who set up the web site link.
The upload directory is wrong in the buildmaster configuration, I'm
trying to fix that.
--
Martin v. Löwis added the comment:
I'm not sure who set up the web site link.
The current version of that link comes from Antoine Pitrou; I believe I put the
original version on the website (before Brett moved it into the devguide).
The DMG uploading really can't work anymore since buildbot
Antoine Pitrou added the comment:
I have now created the upload directory, let's see whether it fills
(and no, it's still not on dinsdale).
No need to create it, I've already pointer the master.cfg to another
directory (/data/www/buildbot/daily-dmg).
--
101 - 200 of 231 matches
Mail list logo
