Changes by Berker Peksag <berker.pek...@gmail.com>:
--
pull_requests: +176
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11572>
___
Berker Peksag added the comment:
New changeset 8fb1f6e039cbdeb333d83b7a62f0f37af4ce6e02 by Berker Peksag in
branch 'master':
bpo-29554: Improve docs for pstat module and profile. (#88)
https://github.com/python/cpython/commit/8fb1f6e039cbdeb333d83b7a62f0f37af4ce6e02
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
stage: -> patch review
type: -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
type: performance ->
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
components: -Tkinter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Berker Peksag added the comment:
pip_gui is not part of the Python standard library. Please use
https://github.com/upendra-k14/pip_gui/issues to report your problem.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: open -&g
Berker Peksag added the comment:
All changes to Lib/test/test_copy.py have already been committed.
Perhaps the following hunks from the latest patch can still be useful:
-try:
-d[types.CodeType] = _deepcopy_atomic
-except AttributeError:
-pass
+d[types.CodeType] = _deepcopy_atomic
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +ethan.furman
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29594>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +ned.deily
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29574>
___
Berker Peksag added the comment:
FWIW, I also prefer PR 120 over PR 117. However, if Steven prefers PR 120 we
probably should merge it only in master.
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.5, Python 3.7
___
Pyt
Berker Peksag added the comment:
Thanks for the report. I agree that the link can be removed. We have a separate
issue tracker for devguide at https://github.com/python/devguide/issues Please
report this there.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> re
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
components: +Library (Lib) -Tests
stage: needs patch -> patch review
versions: +Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: -> patch review
type: -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
New changeset 6de2b7817fa9403e81dc38f13f3690f0bbf3d064 by Berker Peksag in
branch 'master':
bpo-29557: Remove ambiguous line in binhex docs (#90)
https://github.com/python/cpython/commit/6de2b7817fa9403e81dc38f13f3690f0bbf3d064
--
nosy: +berker.peksag
Berker Peksag added the comment:
I'm +1 on the idea. Currently, a user needs to find this information in a wall
of text: "To get the most compact JSON representation, you should specify (',',
':') to eliminate whitespace." It's easy to miss the lack of trailing space in
(',', ':')
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
versions: +Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag, michael.foord
stage: -> patch review
versions: -Python 2.7, Python 3.3, Python 3.4
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Thanks for the report. Feature requests about bugs.python.org should be
reported to http://psf.upfronthosting.co.za/roundup/meta/
--
nosy: +berker.peksag
stage: -> resolved
status: open -> closed
___
Python t
Berker Peksag added the comment:
Thanks for the report. Feature requests about bugs.python.org should be
reported to http://psf.upfronthosting.co.za/roundup/meta/
--
nosy: +berker.peksag
stage: -> resolved
status: open -> closed
___
Python t
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26213>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: -> needs patch
type: compile error -> enhancement
versions: +Python 3.5, Python 3.6
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
Thanks for the report, but spacy is not part of the Python standard library.
Please report your problem to spacy developers.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: open -&g
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Berker Peksag added the comment:
New changeset c6d2f498142c29ed62241ab6d89cb7b5e38f2fca by GitHub in branch
'3.5':
bpo-27122: Fix comment to point to correct issue number (#50)
https://github.com/python/cpython/commit/c6d2f498142c29ed62241ab6d89cb7b5e38f2fca
--
nosy: +berker.peksag
Berker Peksag added the comment:
New changeset 89b1824e693419b20b6a9113e5293f1c1a78065f by GitHub in branch
'3.6':
bpo-27122: Fix comment to point to correct issue number (#48)
https://github.com/python/cpython/commit/89b1824e693419b20b6a9113e5293f1c1a78065f
--
nosy: +berker.peksag
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +jason.coombs
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29523>
___
Berker Peksag added the comment:
Thanks for the report and for the patch, Jim! I agree with Inada.
global_gitignore is a better way to achieve this.
> Maybe a better solution would be to add something to the devguide about
> excluding IDE settings files, with a link to the Github instru
Berker Peksag added the comment:
See http://bugs.python.org/issue25680#msg255116 for Guido's comment on platform
differences.
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks for the reviews!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Patch looks good to me too, thanks! Just left a super minor comment on Rietveld.
You might want to commit this to 3.5+ because we don't daily build 3.4 docs
anymore:
https://github.com/python/docsbuild-scripts/blob/master/build_docs.py#L30
I didn't see any
Changes by Berker Peksag <berker.pek...@gmail.com>:
Added file: http://bugs.python.org/file46541/issue24459_cleanup_2.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Berker Peksag added the comment:
Thanks for the patch and sorry for my late response. I did some tweaks and am
planning to commit the tweaked version of your patch this week.
--
Added file: http://bugs.python.org/file46540/issue24459_cleanup.diff
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
> [...] but I want to make the change small so others won't get unfamiliar with
> the new code. :-)
Assuming it doesn't cause any behavior changes, I find Milt's patch simple
enough and easier to understand than the version uses 'iteration' va
Berker Peksag added the comment:
Thanks for the updated patch, but I'm not sure FileInput class needs a
islastline() method. I couldn't find any similar or duplicate feature requests
on the tracker after this opened in 2004 (which is a sign that the need for
this method is low.)
Also
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue24905>
___
Berker Peksag added the comment:
I've applied Ryan's patch since it's been sitting in the 'commit review' queue.
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
type: -&
Berker Peksag added the comment:
Thanks for the report, Michal. Note that both [1] and [2] point to the same
patch. Perhaps you meant to paste a link to a separate patch for distutils?
(I removed 3.3 and 3.4 from the versions field since they are in
security-fix-only mode now. I don't know
Berker Peksag added the comment:
Thanks for the patches, Jelle :)
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> enhancement
versions: +Python 3.5
___
Python tracker <rep...@bugs.py
New submission from Berker Peksag:
Attached patch converts all examples that use @coroutine decorator in
Doc/library/asyncio-task.rst. I also removed the generator example at
https://docs.python.org/3/library/asyncio-task.html#example-coroutine-displaying-the-current-date
See issue 29407
Berker Peksag added the comment:
> "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd;>
I think that HTML output suggests that their server configuration is broken. If
you look at further down the page there is this error message:
Something has triggered missing webpage on your
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> fixed
stage: -> resolved
status: -> closed
___
Python tracker <rep...@bugs.python.org>
<http://b
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: fixed ->
stage: resolved ->
status: closed ->
___
Python tracker <rep...@bugs.python.org>
<http://b
Berker Peksag added the comment:
Here's a patch. sock_connect() wrapped by @coroutine in
Lib/asyncio/selector_events.py so I left it as-is. Let me know if it still
needs to be updated:
@coroutine
def sock_connect(self, sock, address):
"""Connect to a remote so
Berker Peksag added the comment:
Thanks for the review, Guido.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: -> resolved
superseder: -> Add support for _msi.Record.GetString() and
_msi.Record.GetInteger()
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
Thanks for the report, Jason. I think this is a duplicate of issue 1102. The
second patch (_msi_fetch.patch.txt) there should fix your problem (if I read
MSDN correctly, 103 is ERROR_NO_MORE_ITEMS.)
I don't have access to a Windows box at the moment so could
Berker Peksag added the comment:
Thanks! Since Greg has given his LGTM and I couldn't find any usage of it in
the wild, I've committed the patch with a NEWS entry.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -&g
New submission from Berker Peksag:
Unless I'm missing something, ensure_future() calls at
https://docs.python.org/3.6/library/asyncio-task.html#example-parallel-execution-of-tasks
are redundant and can be removed.
Off-topic: Can we use the async/await keywords in asyncio docs now
Berker Peksag added the comment:
I'm not really familiar with asyncio terminology, but it looks like it returns
a future:
>>> asyncio.isfuture(loop.sock_recv(sock, 1024))
True
There is a also a test in test_selector_events:
f = self.loop.sock_recv(s
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
components: -Installation
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Berker Peksag added the comment:
Thanks for the report, Nathaniel. I agree that the documentation could be
improved. Here is a patch. I also moved the constant table to epoll.register()
documentation (it's already done in
https://docs.python.org/3.7/library/select.html#polling-objects
Berker Peksag added the comment:
Thanks for the patch. I think it would be better to use the existing framework
in Win32SymlinkTests to create a test file instead of using a hardcoded path
like 'C:\Users\All Users' (e.g. use Win32SymlinkTests.filelink and
Win32SymlinkTests.filelink_target
Berker Peksag added the comment:
Good catch and thanks for the report! Renaming was done in issue 24633. It
looks like it was added back in a merge commit:
https://github.com/python/cpython/commit/ebe304e919b56d889313a2d15fb5c52189a32ef7
I will delete Lib/site-packages/README shortly
Berker Peksag added the comment:
Thanks for the report, but pyserial is not part of the Python stdlib. Please
open your bug report on https://github.com/pyserial/pyserial.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: open -> closed
ty
Berker Peksag added the comment:
> 1. Should we add the VACUUM with a explicit commit? Maybe there should
> be an implicit commit before VACUUM?
VACUUM is often an expensive operation so I think people should need to
explicitly handle it anyway.
> 2. Should a SELECT start a trans
Berker Peksag added the comment:
Great! Since this is no longer an issue on Python 3.4+, I'm going to close this
as a duplicate of issue 27634 and merge
https://github.com/berkerpeksag/selectors34/pull/4.
--
resolution: -> duplicate
stage: -> resolved
status: open -&g
Berker Peksag added the comment:
Thanks for the report! This is a duplicate of issue 27634.
Since we got multiple reports [1][2] about the same problem on selectors34
(backport of selector module) and use of Gevent is very popular, I think we
should reconsider the idea of wrapping
Berker Peksag added the comment:
Serhiy's patch looks pretty good to me, thanks! Also, thanks for the report,
Rafael. I definitely forgot to fix this case after fixing issue 25195.
--
stage: patch review -> commit review
___
Python tracker &
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +ned.deily
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29316>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +michael.foord
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29274>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +gvanrossum
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 28518.
--
components: +Library (Lib)
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> execute("begin immediate") throwing
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9182>
___
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9338>
___
Berker Peksag added the comment:
Are you planning to use test.support.os_link() to fix other tests in near
future? If test_os is the only user of the helper, I'd say let's keep it in
Lib/test/test_os.py for now. test.support is already big enough and it would be
better not to put every
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
nosy: +berker.peksag
stage: -> patch review
type: -> behavior
versions: +Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Berker Peksag added the comment:
I'd probably write it without the for loop:
text = "a && b; c && d || e; f >'abc'; (def \"ghi\")"
result = shlex.shlex(text)
print(f"Old behavior: {list(result)}")
result = shlex.shlex(text,
Berker Peksag added the comment:
Thanks for the patches James and Greg!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5
___
Python tracker <rep...@bugs.python.org>
<http
Berker Peksag added the comment:
Thanks for the review, Senthil.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
New submission from Berker Peksag:
I noticed this while taking a look at urllib docs for issue 29182. Indentation
of prompt_user_passwd() is broken and it looks like it's part of the note
directive:
https://docs.python.org/2/library/urllib.html#urllib.FancyURLopener.prompt_user_passwd
Python
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
stage: patch review -> commit review
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
IIRC 3.5.3rc1 is already tagged so the 3.5 branch is open for 3.5.4. Anything
that needs to be in 3.5.3 should be cherry-picked by the RM at this point if
I'm not mistaken (and note that I don't have time check, but 3.5.3 may be the
last bugfix release of 3.5
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> duplicate
stage: -> resolved
superseder: -> Fix curses module compilation with ncurses6
___
Python tracker <rep...@bugs.python.org>
<http://bu
Berker Peksag added the comment:
I think the next steps are:
1. Add tests for the cases Serhiy has mentioned in msg277109:
> Shouldn't the ZipFile.filename attribute be converted to str?
and
> The file name of ZipFile is only a part of the issue. There are other uses
of file
Berker Peksag added the comment:
Thanks for releasing it on PyPI! It's probably better to keep it as an example
in the documentation for now. We can reopen this if there's a demand for
CopyingMock in the future.
--
nosy: +berker.peksag
resolution: -> rejected
stage: -> re
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
type: -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Berker Peksag added the comment:
Yes, thanks!
--
nosy: +martin.panter, xiang.zhang
stage: -> patch review
type: -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Berker Peksag added the comment:
Note: We don't officially use pull requests yet. Current way of contributing to
Python is documented at https://docs.python.org/devguide/patch.html
--
nosy: +berker.peksag
___
Python tracker <rep...@bugs.python.
Berker Peksag added the comment:
I misread your comment. I think we need to add "import sys" to that file so I'm
reopening this.
--
keywords: +easy
resolution: not a bug ->
stage: resolved -> needs patch
status: closed -> open
ve
Berker Peksag added the comment:
Great, thanks for following up with us.
--
resolution: -> not a bug
stage: -> resolved
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Berker Peksag added the comment:
We can just fallback to the current behavior (i.e. return None) if the return
type of text_factory(val_str) is not str, bytes or bytearray. I think this is
also somewhat similar to what we do for the return values of
sqlite3_column_text().
--
nosy
Berker Peksag added the comment:
I think the OP is talking about Lib/idlelib/pyshell.py. The relevant changeset
is 76f831e4b806. "from tkinter import *" imports the sys module as a
side-effect. OO O, did you notice this by reading the code or by using a tool
like flake8?
-
Berker Peksag added the comment:
Thanks for the report. That's because TestResult.addSubTest() updates
TestResult.errors and TestResult.failures itself instead of calling the
addError() and addFailure() methods respectively:
if issubclass(err[0], test.failureException):
errors
Berker Peksag added the comment:
You may find Raymond Hettinger's "super() considered super" article helpful to
understand how Python's super() works:
https://rhettinger.wordpress.com/2011/05/26/super-considered-super/
--
nosy: +ber
Berker Peksag added the comment:
Welcome and thanks for the patch, Greg. csv.rst-patch looks good to me. I will
commit it this week if there are no objections.
Documentation updates can go into all active branches so I'm adding 3.5 and 3.6
back (we can pass 2.7 at this point since
Berker Peksag added the comment:
Thanks for finding the duplicate. I'm closing this as a duplicate of issue
20608.
--
components: -2to3 (2.x to 3.x conversion tool), Documentation
nosy: +berker.peksag -docs@python
resolution: -> duplicate
stage: -> resolved
status: open -&g
Changes by Berker Peksag <berker.pek...@gmail.com>:
--
versions: +Python 3.7 -Python 3.5
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Berker Peksag added the comment:
The patch looks good to me. There are some styling issues in the test code
(e.g. no need to add trailing spaces after commas in some cases), but I can
take care of them before committing the patch :) Thanks
Berker Peksag added the comment:
I agree with Ezio.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27200>
___
___
Python-bugs-
Berker Peksag added the comment:
Right, that's my fault. Apparently I missed the "[...] zipfile will create
[...]" part :) What do you think about Monte's suggested changes Serhiy? Should
we just revert 4685cd33087b (1) or do both (1) and (2)?
--
stage: ->
Berker Peksag added the comment:
You're right. Thanks for the review, Serhiy!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Berker Peksag added the comment:
Good point, Serhiy. Thanks for the patch, Jim. I've now removed the "possible a
singleton" part.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.py
Berker Peksag added the comment:
Thanks for the patch Sam and thanks for the ping Peter!
--
components: +Library (Lib)
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.5, Python 3.6
Berker Peksag added the comment:
Thanks, Dingyuan!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Berker Peksag added the comment:
Thanks for the report and for the analysis, Monte!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.6, Python 3.7
___
Python
Berker Peksag added the comment:
Thanks, Jim.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: -Python 3.3, Python 3.4
___
Python tracker <rep...@bugs.py
1101 - 1200 of 3698 matches
Mail list logo
