Berker Peksag added the comment:
Thanks for the report and for the PR. Could you give us a little bit more
information about your use case? Couldn't you make the class you want to use
implement the __fspath__ protocol?
import pathlib as p
class Spam:
def __fspath__(self
Berker Peksag added the comment:
Correct, this has been fixed in issue 25195. Closing as 'out of date'. Thanks
for triaging!
--
nosy: +berker.peksag
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
_
Berker Peksag added the comment:
PR 9461 converts Martin's nntp-server.patch. I've made some tweaks and fixed a
"threading._dangling was modified by test_nntplib" warning. I will try to
convert multi-connect.patch later.
I will attribute Martin as the patch author before merg
Change by Berker Peksag :
--
pull_requests: +8875
___
Python tracker
<https://bugs.python.org/issue19756>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Well, no one is going to notice it if we close this issue. I don't see why the
age of the issue matters here. We close issues when we fix them. It may take 20
minutes, 5 years or a decade.
I understand closing an issue as "out of date" when we cou
Berker Peksag added the comment:
The test_article_head_body test is now skipped unconditionally:
@unittest.skipIf(True, "FIXME: see bpo-32128")
I don't think we should close this issue without re-enabling that test.
--
nosy: +ber
Berker Peksag added the comment:
Thanks for the reviews, Victor. I'm planning to work on them tonight. I will
close this issue and open a new one if I decide to do further work on them.
--
___
Python tracker
<https://bugs.python.org/issue19
Berker Peksag added the comment:
>From AMD64 FreeBSD 10.x Shared 3.x:
> 0:18:38 load avg: 5.04 [390/419/1] test_mmap passed
https://buildbot.python.org/all/#/builders/87/builds/1465/steps/4/logs/stdio
--
resolution: -> fixed
stage: patch review -> resolved
status: op
Berker Peksag added the comment:
> I had raised a PR in github when i have created this ticket but forgot
> to add it here: https://github.com/python/cpython/pull/9413
Thanks for the PR, Jophine :) I saw your PR yesterday, but I thought fixing
this in __init__ would be a better solut
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset c56bbae5e92828a4c93be3b0e7a5072a31fdc587 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34743: Fix test_database_source_name under SQLite 3.7.9 (GH-9426)
https://github.com/python/cpython/commit
Berker Peksag added the comment:
New changeset 4fb672ff96ecbb87aaf2ecc4f04aed76aafe63b1 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-32215: Fix performance regression in sqlite3 (GH-8511)
https://github.com/python/cpython/commit/4fb672ff96ecbb87aaf2ecc4f04aed76aafe63b1
Berker Peksag added the comment:
> Why not support Iterable[FrameSummary]?
The question that needs to be answered here is "why we should support
Iterable[FrameSummary]?" and you're one the one who needs to answer it instead
of saying our design decisions were "absurd"
Berker Peksag added the comment:
New changeset bc854750589d4de0fd55693963964e0558b5c8ac by Berker Peksag in
branch 'master':
bpo-34754: Fix test_flush_return_value on FreeBSD (GH-9451)
https://github.com/python/cpython/commit/bc854750589d4de0fd55693963964e0558b5c8ac
Berker Peksag added the comment:
New changeset 015cd0f5cb17b1b208a92e549cd665dc38f2f699 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-32215: Fix performance regression in sqlite3 (GH-8511)
https://github.com/python/cpython/commit/015cd0f5cb17b1b208a92e549cd665dc38f2f699
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8866
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Berker Peksag :
==
FAIL: test_flush_return_value (test.test_mmap.MmapTests)
--
Traceback (most recent call last):
File
"/usr
Berker Peksag added the comment:
New changeset 476177005e8c8d4ece3070c8c378f8b8c068e76f by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-19756: Prevent test failures due to EADDRNOTAVAIL (GH-9446)
https://github.com/python/cpython/commit/476177005e8c8d4ece3070c8c378f8b8c068e76f
Berker Peksag added the comment:
New changeset 8213eaddf3ce8e87564d2949454903a1484748b5 by Berker Peksag in
branch 'master':
bpo-19756: Prevent test failures due to EADDRNOTAVAIL (GH-9446)
https://github.com/python/cpython/commit/8213eaddf3ce8e87564d2949454903a1484748b5
Change by Berker Peksag :
--
pull_requests: +8861
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue19756>
___
___
Python-
Berker Peksag added the comment:
Yeah, I will submit a pull request today. The reason I reopened this issue is
that I didn't want to file another issue for a similar problem and wanted to
use this as a meta issue for issues with test_nntplib. Also, I'd like to play
Martin's patches a bit
Berker Peksag added the comment:
I think it would be nice if tweaked support.transient_internet() to catch
EADDRNOTAVAIL. See
https://github.com/python/cpython/commit/e4dcbbd7f4ac18d01c0ec85f64ae98b8281ed403#diff-7fa374913c0ecbdc621db8ea79a1212bR78
for another example
Change by Berker Peksag :
--
Removed message: https://bugs.python.org/msg325858
___
Python tracker
<https://bugs.python.org/issue19756>
___
___
Python-bugs-list m
Berker Peksag added the comment:
==
ERROR: setUpClass (test.test_nntplib.NetworkedNNTPTests)
--
Traceback (most recent call last):
File "/home/travis/
Berker Peksag added the comment:
New changeset b10a64d117de6121ea3e79c467c4107f8f399f3d by Berker Peksag in
branch 'master':
bpo-34743: Fix test_database_source_name under SQLite 3.7.9 (GH-9426)
https://github.com/python/cpython/commit/b10a64d117de6121ea3e79c467c4107f8f399f3d
Berker Peksag added the comment:
New changeset 8d1e190fc507a9e304f6817e761e9f628a23cbd8 by Berker Peksag in
branch 'master':
bpo-32215: Fix performance regression in sqlite3 (GH-8511)
https://github.com/python/cpython/commit/8d1e190fc507a9e304f6817e761e9f628a23cbd8
Berker Peksag added the comment:
Thanks for the report and for the PRs. The approach in PR 9417 seems reasonable
to me, but we need to add some tests for all supported platforms and fix the
test_windll_getnode test.
I'm removing Python 3.6 from the versions list since it's nearly end of its
Berker Peksag added the comment:
Issue 34732 is actually a duplicate of this issue, but I'm going to close this
one instead since the former has already two open pull requests. Thanks for the
report!
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8844
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Berker Peksag :
==
FAIL: test_database_source_name (sqlite3.test.backup.BackupTests)
--
Traceback (most recent call last):
File "
Change by Berker Peksag :
--
superseder: -> Pathlib glob ** bug
___
Python tracker
<https://bugs.python.org/issue34731>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Thanks for the report. This looks like a duplicate of issue 29249.
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue34
Berker Peksag added the comment:
We can definitely make the title of that issue more descriptive. Feel free to
change it -- IIRC, you don't need additional permissions to change the title of
an issue. Thanks!
--
___
Python tracker
<ht
Berker Peksag added the comment:
I think we usually went with option 1 when we fixed similar issues in the past.
See also issue 23224 for the same problem in *Decompressor classes of lzma and
bz2 modules. It looks like the attached PR to that issue went with option 2: PR
7822.
Perhaps we
Berker Peksag added the comment:
Or we can special case functools.partial() in _copy_func_details() and use
partial_object.func.__name__.
(I'm not sure which solution is better, but we need to the same thing for
__doc__ as well.)
--
___
Python
Berker Peksag added the comment:
I think option 2 is what functools.update_wrapper() does and it may be better
to make create_autospec() consistent with it.
Perhaps we can replace _copy_func_details() with functools.update_wrapper():
assigments = (
'__name__', '__doc__
Berker Peksag added the comment:
Thanks for the report and for the PR, John. Karthikeyan is correct.
Many of the modules in the stdlib predate PEP 8. Also, making PEP 8-only
changes would make "git blame" less useful and can cause regressions (IIRC it
has happened at least once, b
Berker Peksag added the comment:
Thanks for the report and for the patch! This is a duplicate of issue 31734.
The Cache class is an implementation detail and it has no use of outside of the
sqlite3 implementation as you already said.
For option 3, there is an open issue: #30262. IMO
Change by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issue34695>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
New changeset c83c375ed907bdd54361aa36ce76130360f323a4 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-32933: Implement __iter__ method on mock_open() (GH-5974)
https://github.com/python/cpython/commit/c83c375ed907bdd54361aa36ce76130360f323a4
Berker Peksag added the comment:
Thanks, Ned!
Anthony, I'm one of the maintainers of https://github.com/testing-cabal/mock
and I'd be happy to merge a PR that backports the fix to the PyPI version of
mock.
--
versions: +Python 3.7
___
Python
Berker Peksag added the comment:
> 1) I know it has the name "format_list", but is it really intended to require
> a
> list? Why not a sequence, or a collection, or an iterable? I would think it
> would
> be fine to pass an iterable to traceback.format_list. Is it f
Berker Peksag added the comment:
It would be nice to make *reason* optional. Every time I needed to use
@unittest.skip() (even if I wanted to use it temporarily), I ended up passing
some random string as reason or use 'raise SkipTest' directly.
If we decide to keep *reason* required, I
Berker Peksag added the comment:
New changeset 0b9fe1734168d45861d6dc3022492387dec5a4a2 by Berker Peksag
(Zackery Spytz) in branch '2.7':
[2.7] bpo-20047: Remove Objects/bytesobject.c from 2.7 (GH-9268)
https://github.com/python/cpython/commit/0b9fe1734168d45861d6dc3022492387dec5a4a2
Berker Peksag added the comment:
Ned, as release manager of 3.6 and 3.7, what do you think about backporting
this to maintenance releases?
--
___
Python tracker
<https://bugs.python.org/issue32
Berker Peksag added the comment:
Closing this as a duplicate of issue 32933. Let's discuss backporting to
maintenance branches there.
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> mock_open does not support iteration
Berker Peksag added the comment:
Thanks for the patch, Anthony.I consider this a new feature, so I removed 3.6
and 3.7 from the versions field. We can backport to 3.7 if other core
developers think that it's worth to fix in the latest maintenance branch.
--
resolution: -> fi
Berker Peksag added the comment:
New changeset 2087023fdec2c89070bd14f384a3c308c548a94a by Berker Peksag (Tony
Flury) in branch 'master':
bpo-32933: Implement __iter__ method on mock_open() (GH-5974)
https://github.com/python/cpython/commit/2087023fdec2c89070bd14f384a3c308c548a94a
Berker Peksag added the comment:
New changeset 669429fb583031c7c87392e30b065e99a2d8ccda by Berker Peksag (Miss
Islington (bot)) in branch '2.7':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/669429fb583031c7c87392e30b065e99a2d8ccda
Berker Peksag added the comment:
Thanks, Alexey!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 6d726868cd1743623a28b8e048e31b9c3c52a399 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/6d726868cd1743623a28b8e048e31b9c3c52a399
Berker Peksag added the comment:
New changeset ec4d099b9f1951b08d1a53181c278173ff6a0cc1 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/ec4d099b9f1951b08d1a53181c278173ff6a0cc1
Berker Peksag added the comment:
New changeset 6f82bffd2df63a4072b3f0483cdbe93ddedb87e9 by Berker Peksag (Alexey
Izbyshev) in branch 'master':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/6f82bffd2df63a4072b3f0483cdbe93ddedb87e9
Berker Peksag added the comment:
Ok, let's close this issue then.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
Thanks for merging this, Petr. What do you think about backporting to 3.7?
--
components: -Documentation
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue26
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset b690b9b04729ba3d91c59bff1bb11c3dcc1b50fc by Berker Peksag in
branch 'master':
bpo-29386: Pass -1 to epoll_wait() when timeout is < -1 (GH-9040)
https://github.com/python/cpython/commit/b690b9b04729ba3d91c59bff1bb11c3dcc1b5
Berker Peksag added the comment:
Welcome, Noah! Feel free to work on this issue, but please note that there is
no consensus on the best place to document / signatures, so you may need to
move your changes between locations (e.g. from Doc/faq/programming.rst to
Doc/gloassary.rst) before we
Change by Berker Peksag :
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
PR 9079 looks good to me.
I think we can use this as an opportunity to make the rest of the examples in
the sqlite3 documentation more consistent and add missing "conn.close()" calls.
--
___
Python track
Berker Peksag added the comment:
> Should I remove or change this line as per Daniel's comment "Note that
> this does not automatically call :meth:`close` on the connection object."
I'd prefer to keep the current wording as-is.
--
__
Berker Peksag added the comment:
I'm working on converting Modules/_sqlite/* to Argument Clinic.
--
nosy: +berker.peksag
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue20
Berker Peksag added the comment:
Personally, I find parent/child more descriptive if it can be used in the same
context with master/slave, so I'm in favor of replacing master/slave with
parent/child where applicable.
However, I agree that the code changes in PR 9100 are a bit excessive
Berker Peksag added the comment:
We always explicitly document what the context manager does even if it simply
calls an object's close() method. See
https://docs.python.org/3/library/fileinput.html#fileinput.input and
https://docs.python.org/3/library/shelve.html#shelve.Shelf for example
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 4e519377b1b84c9414a360961276993d24198825 by Berker Peksag
(Zackery Spytz) in branch 'master':
bpo-23855: Add missing NULL checks for malloc() in _msi.c (GH-9038)
https://github.com/python/cpython/commit/4e519377b1b84c9414a360961276993d24198825
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8502
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue29386>
___
___
Py
Change by Berker Peksag :
--
type: enhancement -> crash
___
Python tracker
<https://bugs.python.org/issue33803>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
The resolve() method already solves symlinks, but I think this is a reasonable
feature request. I've just reviewed PR 8285.
--
nosy: +berker.peksag, pitrou
versions: +Python 3.8 -Python 3.7
___
Python tracker
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 3738fadc670274ecc4649f51b52a93602820a375 by Berker Peksag
(Michael Osipov) in branch 'master':
bpo-34448: Improve output of usable wchar_t check (GH-8846)
https://github.com/python/cpython/commit/3738fadc670274ecc4649f51b52a93602820a375
Change by Berker Peksag :
--
components: +Library (Lib)
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue28069>
___
___
Python-bugs-list m
Change by Berker Peksag :
--
nosy: +berker.peksag
type: -> enhancement
versions: +Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issu
Berker Peksag added the comment:
Issue 34480 is another relevant issue. The HTMLParse method doesn't have an
error() method and it doesn't raise any exceptions, but its base class still
does. I think there is a compatibility problem between html.parser.HTMLParser
Change by Berker Peksag :
--
stage: patch review -> test needed
___
Python tracker
<https://bugs.python.org/issue31844>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
After triaging issue 34480, I realized that we can't simply remove the error()
method because the _markupbase.ParserBase() class still uses it. I've just
closed PR 8562.
--
___
Python tracker
<ht
Change by Berker Peksag :
--
status: -> open
___
Python tracker
<https://bugs.python.org/issue34480>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Berker Peksag :
--
Removed message: https://bugs.python.org/msg323967
___
Python tracker
<https://bugs.python.org/issue34480>
___
___
Python-bugs-list m
<pre>
Berker Peksag <berker.pek...@gmail.com> added the comment:
Thanks for the report.
HTMLParser.error() was supposed to raise an exception, but the BeautifulSoup
project just prints a warning here:
def error(self, msg):
warnings.warn(msg)
<a rel="n
Berker Peksag added the comment:
The message is a bit more descriptive if wchar_t isn't usable:
> checking whether wchar_t is signed... yes
> no usable wchar_t found
I'm not sure if it's worth to backport to 3.6, but it's a nice improvement for
3.7 and master branches. Also, it simp
Berker Peksag added the comment:
Personally I wouldn't bother fixing 2.7, but let's see what other core devs
think.
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 48ce4897f8f8d91d948ecd1241ffab002df2be9e by Berker Peksag
(Michael Osipov) in branch 'master':
bpo-34412: Make signal.strsignal() work on HP-UX (GH-8786)
https://github.com/python/cpython/commit/48ce4897f8f8d91d948ecd1241ffab002df2be9e
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset c583919ffced0a3b6409766fc12f6e28bef4fac7 by Berker Peksag (Alexey
Izbyshev) in branch 'master':
bpo-34462: Add missing NULL check to _copy_raw_string() (GH-8863)
https://github.com/python/cpython/commit/c583919ffced0a3b6409766fc12f6e28bef4fac7
Berker Peksag added the comment:
Thanks for the suggestions and for the reviews!
--
assignee: brian.curtin ->
priority: high -> normal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python
Berker Peksag added the comment:
New changeset e7d4b2f205c711d056bea73a0093e2e2b200544b by Berker Peksag in
branch 'master':
bpo-2122: Make mmap.flush() behave same on all platforms (GH-8692)
https://github.com/python/cpython/commit/e7d4b2f205c711d056bea73a0093e2e2b200544b
--
nosy
Berker Peksag added the comment:
New changeset cdbf50cba1664f72ae6621a89c324a32fea70377 by Berker Peksag (Alexey
Izbyshev) in branch 'master':
bpo-34441: Fix ABC.__subclasscheck__ crash on classes with invalid
__subclasses__ (GH-8835)
https://github.com/python/cpython/commit
Berker Peksag added the comment:
poll.modify() is documented in both Python 2 and Python 3 docs:
* https://docs.python.org/2/library/select.html#select.poll.modify
* https://docs.python.org/3/library/select.html#select.poll.modify
> I believe that should be "Modify a registe
Berker Peksag added the comment:
Thanks for the report. In the title, you mentioned epoll.poll(), but you gave
the link to the poll.poll() documentation. Also, the part you quoted
If timeout is given, it specifies the length of time in milliseconds
which the system will wait
Change by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue25810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the review, Martin, and thanks for the report, Alon!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 225b05548027d55aafb11b65f6a4a2bef2f5196f by Berker Peksag in
branch 'master':
bpo-22057: Clarify eval() documentation (GH-8812)
https://github.com/python/cpython/commit/225b05548027d55aafb11b65f6a4a2bef2f5196f
Change by Berker Peksag :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/
Berker Peksag added the comment:
Thank you for the report, Xavier.
This is a duplicate of issue 22057.
PR 8812 clarifies the behavior when a dictionary without a "__builtins__" key
is passed as *globals* to eval(). I think that makes the opposite case much
easier to understand.
Berker Peksag added the comment:
I like Martin's suggestion in msg282262 and I've just created PR 8812 to
implement it.
--
nosy: +berker.peksag
type: -> behavior
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.pyth
Change by Berker Peksag :
--
pull_requests: +8290
___
Python tracker
<https://bugs.python.org/issue22057>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Ok, I think it would be a good idea to mention that the function accepts a code
object in the first sentence. I'd be happy to review such PR. The eval()
documentation is located at
https://github.com/python/cpython/blob/master/Doc/library/functions.rst
See
Berker Peksag added the comment:
Thank you for your report.
Quoting from https://docs.python.org/3.6/library/functions.html#eval
This function can also be used to execute arbitrary code objects
(such as those created by compile()). In this case pass a code
object instead
Berker Peksag added the comment:
Thanks for the report.
Looking at the Kernel source code, there doesn't seem to be any difference
between -1, -100, or -255:
https://github.com/torvalds/linux/blob/9bd553929f68921be0f2014dd06561e0c8249a0d/fs/eventpoll.c#L1747-L1761
Do you know any other OS
301 - 400 of 3698 matches
Mail list logo
