[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

2020-05-18 Thread Kevin Mooney
Kevin Mooney added the comment: Ok, so there are three potential solutions 1. Add cpython_ prefix to cpython headers 2. Remove cpython/initconfig.h from cpython/pystate.h 3. Include initconfig.h rather than cpython/initconfig.h 1 intoduces verbosity and touches more than the other solutions

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

2020-05-18 Thread Kevin Mooney
Kevin Mooney added the comment: Ok, I think I see. Is there a concern that removing the cpython/ prefix might lead to the wrong initconfig.h being included? So your proposal is all includes in the root will do #include "cpython/cpython_foo.h" And any includes done in the c

[issue39026] pystate.h contains non-relative of initconfig.h include causing macOS Framework include failure

2020-05-18 Thread Kevin Mooney
Change by Kevin Mooney : -- keywords: +patch nosy: +Kevin Mooney nosy_count: 5.0 -> 6.0 pull_requests: +19482 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20181 ___ Python tracker <https://bugs.python.org/i