Lorenzo M. Catucci added the comment:
On Sun, 19 May 2013, R. David Murray wrote:
RDM
RDM R. David Murray added the comment:
RDM
RDM Lorenzo, any chance you could supply a unit test that fails without
RDM smtplib_05_shutdown_socket.diff applied?
RDM
It would really be a functional test
Lorenzo M. Catucci added the comment:
OK, I'm uploading poplib_03_starttls_v5.diff; I only changed the
caps=self.capa() into caps = self.capa() in the @@ -352,21 +360,42 @@
class POP3: hunk.
Thank you for pointing at the line; I tried to run pep8.py on poplib.py, but
failed to find the line
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file28026/poplib_03_starttls_v4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file:
http://bugs.python.org/file28025/poplib_02_server_capabilities_v4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file28026/poplib_03_starttls_v4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file:
http://bugs.python.org/file26251/poplib_02_server_capabilities_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file26252/poplib_03_starttls_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Lorenzo M. Catucci added the comment:
Updated 02 and 03 patches (mostly) in line with Antoine's review comments:
2) poplib_02_server_capabilities_v3.diff:
- please try to follow PEP 8 (i.e. `capa = {}` not `capa={}`)
- I think the capa() result should be a dict mapping str keys to str
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26240/poplib_02_server_capabilities.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file:
http://bugs.python.org/file26133/poplib_02_server_capabilities.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file26134/poplib_03_starttls.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26241/poplib_03_starttls.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26242/poplib_03_starttls.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file26241/poplib_03_starttls.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
I've refreshed once more the patches, adding the implementation of the stls
command in test_poplib.py.
IMHO, the changes as they stand now are low risk, and could as well go into 3.3.
With many thanks to Giampaolo
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26250/poplib_01_socket_shutdown_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file:
http://bugs.python.org/file26251/poplib_02_server_capabilities_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26252/poplib_03_starttls_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file26132/poplib_01_socket_shutdown.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file:
http://bugs.python.org/file26240/poplib_02_server_capabilities.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file26242/poplib_03_starttls.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12188/poplib_03_SSL_refactor.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12172/poplib.rst.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12187/poplib_02_sock_shutdown.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12189/poplib_04_STLS.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26132/poplib_01_socket_shutdown.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26134/poplib_03_starttls.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12192/poplib_01_CAPA.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12965/test_popnet.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file12966/test_popnet.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file26133/poplib_02_server_capabilities.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
I've refreshed the patches to apply on 3.3, and adapted the to the
unit-test framework by giampaolo.rodola.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
I'd still prefer if smtplib_05_shutdown_socket_v2.patch could get in,
^^
since, this way the REMOTE socket close will be unconditionally correct,
instead
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file22401/v2_01_fix_lmtp_init
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file22402/v2_02_mock_socket_shutdown
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file22403/v2_03_shutdown_socket_on_close
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file22403/v2_03_shutdown_socket_on_close
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Removed file: http://bugs.python.org/file22402/v2_02_mock_socket_shutdown
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4470
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
Just finished testing both 2.7 and default branches' socket close behaviour,
and it seems 05 is not strictly needed.
I'd still prefer if smtplib_05_shutdown_socket_v2.patch since, this way the
REMOTE socket close
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
On Fri, 17 Jun 2011, R. David Murray wrote:
RDM
RDM R. David Murray rdmur...@bitdance.com added the comment:
RDM
RDM According to your traceback you should be seeing the error in the
RDM first line (the creation
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
As the tests are new, I hope sending the real file is the right way to
proceed.
Added file: http://bugs.python.org/file12963/test_imapnet.py
___
Python tracker rep...@bugs.python.org
http
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file12964/test_smtpnet.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
Added file: http://bugs.python.org/file12965/test_popnet.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it:
--
components: +Library (Lib)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4473
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
There is a problem I forgot to state with test_anonlogin:
since I try and test both SSL and starttls, the DoS checker at cmu kicks
in and refuse the login attempt in PopSSLTest. Since I'd rather avoid
cheating, I'm leaning
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
I'm enclosing the expected-failure version of test_popnet. It's much
simpler to talk and comment about something you can see!
Added file: http://bugs.python.org/file12966/test_popnet.py
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
I just found out that the gmail servers don't support connections on
the standard pop3/imapv4 ports, but only on the SSL wrapped ones.
I'm unsure if cmu.edu anonymous imap server admin's would be happy with
their server
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
Thanks for following-up, Bill.
While I fully understand the need for unit-testing, I don't have the
guts to start writing a dummy imap server from scratch.
I tested my changes on a couple of servers I manage, one running
uw
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12189/poplib_04_STLS.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file12170/poplib.py.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
I'm reasonably sure Victor is right about the original socket being
unneeded. How does the series look now?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
Changed CAPA as requested: now there is a proper docstring, and the
useless if ... else ... is gone.
Added file: http://bugs.python.org/file12192/poplib_01_CAPA.diff
___
Python tracker [EMAIL PROTECTED
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file12186/poplib_01_CAPA.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
As for the shutdown/close comment, I think there could be cases
where you are going to close but don't want to shutdown: e.g. you might
close a dup-ed socket, but the other owner would want to continue
working with his copy of the socket
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12186/poplib_01_CAPA.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12187/poplib_02_sock_shutdown.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12188/poplib_03_SSL_refactor.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
As requested, I've split the patch into three parts: the first one does
just refactor IMAP4_SSL, the second is really a one liner for shutting
down the socket before closing it, and the thirs does introduce the
starttls method in IMAP4
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12194/imaplib_02_shutdown.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12195/imaplib_03_starttls.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file12169/imaplib.py.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file12168/smtplib.py.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12197/smtplib_01_default_port.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12198/smtplib_02_fix_ssl.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12199/smtplib_03_use_makefile.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4470
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12200/smtplib_04_remove_fakefile.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4470
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
I've reworked the patch into a series, like haypo requested for
poplib and imaplib.
Added file: http://bugs.python.org/file12201/smtplib_05_shutdown_socket.diff
___
Python tracker [EMAIL PROTECTED]
http
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
I understand the need to keep things simple, but this time the split
seemed a bit overkill. If needed, I'll redo the patch into a small
series. Thinking of it... I was unsure if it really made sense to split
out smtp/pop/imap patches
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
As in #4473: if needed, I'll redo the patch into a small
series. I've cut and pasted the following.
As for the shutdown before close, it's needed to let the server know
we are leaving, instead of waiting until socket timeout
New submission from Lorenzo M. Catucci [EMAIL PROTECTED]:
The enclosed patch does three things:
1. enables SMTP_SSL working: the _get_socket method was setting
self.sock instead of returning the socket to the caller, which
did reset self.sock to None
2. replace home-grown SSLFakeFile
New submission from Lorenzo M. Catucci [EMAIL PROTECTED]:
In the enclosed patch, there are three changes:
1. Support starttls on IMAP4 connections
2. Rework of the IMAP_SSL, to replace home-grown file-like
methods with proper ones from ssl module's makefile();
3. Properly shutdown sockets
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
the needed changes to library documentation if the patch is accepted
Added file: http://bugs.python.org/file12171/imaplib.rst.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
The needed changes to documentation if the patch gets accepted
Added file: http://bugs.python.org/file12172/poplib.rst.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4473
73 matches
Mail list logo
