Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +16306
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16726
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38417>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
With task specific arguments. cwd, start_new_session, group, extra_groups,
user, etc..
We cannot provide a general do everything replacement and should not try.
It not possible.
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
preexec_fn has been mentally and advisability deprecated for years. :)
I'll mark it officially with pending deprecation in 3.9 destined to be removed
in 3.11. tracking that in its own rollup issue
https://bugs.python.org/issue38435
As far as posix_spawn
New submission from Gregory P. Smith :
subprocess's preexec_fn feature needs to enter PendingDeprecationWarning state
in 3.9, to become a DeprecationWarning in 3.10, with a goal of removing it in
3.11.
Rationale: We now live in a world full of threads, it is entirely unsafe to
call back
Gregory P. Smith added the comment:
We should not provide such an "run arbitrary python code before execing the
ultimate child" feature in the standard library.
It is complicated, and assumes you have an ability to execute a new interpreter
with its own slow startup time as an in
Gregory P. Smith added the comment:
We don't have to for all possible things, doing this just reduced friction for
existing uses. In this case, calling umask in our child ourselves would be
easy to support. (easier than the more important setuid/sid/gid/groups-ish
stuff that recently went
New submission from Gregory P. Smith :
Another use of the deprecated unsafe preexec_fn was to call os.umask in the
child prior to exec.
As seen in https://github.com/freeipa/freeipa/pull/3769 (see the code in there).
We should add an explicit feature for this to avoid people's desire
Gregory P. Smith added the comment:
preexec_fn is fundamentally unsupportable.
what code is using it, there should be a way not to rely on that.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by pmp-p :
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue38393>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from pmp-p :
when trying to build rc1 from a b4 venv to prepare a python host for cross
compilation on ubuntu xenial flavour x64
i got :
cd /tmp
python3.7 -m venv testenv
cd testenv/
. bin/activate
(testenv) /tmp/testenv $ tar xf /tmp/Python-3.8.0rc1.tar.xz && cd
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38326>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'd imagine an equivalent of the 3.6 PR would work for 3.5.
Someone should look at how to do similar in 2.7 _if_ the project(s) that
complained about the problem rely on such behavior in their last 2.7 compatible
releases
Change by Gregory P. Smith :
--
versions: -Python 3.6, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38216>
___
___
Pytho
Gregory P. Smith added the comment:
thanks Thomas!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 36c6fa968016a46a39c3cdbd0a17ea5490dfa343 by Gregory P. Smith in
branch '3.8':
bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079) (GH-16464)
https://github.com/python/cpython/commit/36c6fa968016a46a39c3cdbd0a17ea5490dfa343
Change by Gregory P. Smith :
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue37408>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset c5a7e0ce194c0eafe82eb3e431881012398e7d46 by Gregory P. Smith
(Pascal Chambon) in branch 'master':
bpo-37408: Precise that Tarfile "format" argument only concerns writing.
(GH-14389)
https://github.com/python/cpyt
Change by Gregory P. Smith :
--
pull_requests: +16049
pull_request: https://github.com/python/cpython/pull/16464
___
Python tracker
<https://bugs.python.org/issue38
Gregory P. Smith added the comment:
New changeset c8165036f374cd2ee64d4314eeb2514f7acb5026 by Gregory P. Smith (T.
Wouters) in branch 'master':
bpo-38115: Deal with invalid bytecode offsets in lnotab (GH-16079)
https://github.com/python/cpython/commit/c8165036f374cd2ee64d4314eeb2514f7acb5026
Gregory P. Smith added the comment:
As a note on the general pattern, a user at work diagnosed a ^C problem in
their code when running on 2.7 to be due to Queue.get's
acquire()
try:
...
finally:
release()
Pattern, with the KeyboardInterrupt triggering after acquire() but before the
try
Gregory P. Smith added the comment:
Regardless, since things have already shipped in stable releases, there is a
release that code _will_ encounter somewhere that does validate data but does
not support overruling that behavior. so i'm not sure if it actually matters
to have this in 3.7
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue37958>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Let me know when pr 111 is deployed on the build master so I can log in and
cleanup the current typo names.
otherwise, things are probably running fine for the moment.
--
___
Python tracker
<ht
Gregory P. Smith added the comment:
>From a yet another one of a plethora of reasons to hate buildbot point of
>view... A _log message_ saying "i'm not using this anymore, you can delete
>it" is infinitely worse than just going ahead and automatically deleting it.
>I
Gregory P. Smith added the comment:
I'm not going to spend time manually deleting the unused build directories
until the typo in the new buildsuffix that caused the disk to fill up is fixed.
https://github.com/python/buildmaster-config/pull/111
I don't even understand why the buildsuffix
Gregory P. Smith added the comment:
https://github.com/python/buildmaster-config/pull/108 is to blame.
--
___
Python tracker
<https://bugs.python.org/issue38
Gregory P. Smith added the comment:
It appears that something in the buildbot configuration (typo?) has changed
which caused an entire new set of directories for the builder to be created:
@clang-ubsan:/var/lib/buildbot/clang-ubsan$ ls -al
total 68056
drwxr-xr-x 14 buildbot buildbot 4096
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38269>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
i believe the issues surfaces in this are fixed at this point.
of note, my mock_call_test.py example now passes.
i'm not entirely sure that it _should_ pass though, but that depends on what we
want create_autospec of a class to do. should that autospec'd
Gregory P. Smith added the comment:
New changeset 4042e1afd252858de53e2b79d946a51a0182d1ba by Gregory P. Smith in
branch '3.7':
[3.7] bpo-36871: Handle spec errors in assert_has_calls (GH-16364) (GH-16374)
https://github.com/python/cpython/commit/4042e1afd252858de53e2b79d946a51a0182d1ba
Change by Gregory P. Smith :
--
pull_requests: +15954
pull_request: https://github.com/python/cpython/pull/16374
___
Python tracker
<https://bugs.python.org/issue36
Change by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38239>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
The test probably has a fragile regex. I don't spend time with gdb things much
myself.
--
___
Python tracker
<https://bugs.python.org/issue38
Gregory P. Smith added the comment:
New changeset 2180f6b058effbf49ec819f7cedbe76ddd4b700c by Gregory P. Smith
(Samuel Freilich) in branch 'master':
bpo-36871: Avoid duplicated 'Actual:' in assertion message (GH-16361)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
i don't have context for what test was needed where anymore, but
https://github.com/python/cpython/pull/12704 removed the
_at_fork_acquire_release_weakset.
--
resolution: -> out of date
stage: -> resolved
status: open -&g
Change by pmp-p :
--
nosy: +pmpp
type: enhancement -> performance
___
Python tracker
<https://bugs.python.org/issue35243>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
> I think this is a false dichotomy; in
> https://bugs.python.org/issue36274#msg351834 Jason proposed a few
> alternatives that allow for a secure and obvious default API while adding a
> new, explicitly unsafe API.
I'm not against
Gregory P. Smith added the comment:
All bug fixes are behavior changes. Any broken behavior can be relied upon by
someone.
So far the only ones who have popped up with this change as being a problem is
one project's test suite where the behavior was used by a test because
Gregory P. Smith added the comment:
What's needed here is a Decision. (release managers and steering councils make
those)
IMNSHO, this regression is intentional and does not feel like a bug.
The Python HTTP APIs were never designed with an explicit intent to allow
violations
Gregory P. Smith added the comment:
While I don't like how that get_small_int macro is defined...
and I don't like that Py_UNREACHABLE() was usable as an expression in the
past...
it is probably best to just revert 3ab61473ba7f3dca32d779ec2766a4faa0657923.
The choice to use a macro
Gregory P. Smith added the comment:
New changeset 5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586 by Gregory P. Smith in
branch 'master':
bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108)
https://github.com/python/cpython/commit/5b9ff7a0dcb16d6f5c3cd4f1f52e0ca6a4bde586
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue34706>
___
___
Python-
Change by Gregory P. Smith :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue34706>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +15726
pull_request: https://github.com/python/cpython/pull/16108
___
Python tracker
<https://bugs.python.org/issue34
Gregory P. Smith added the comment:
New changeset 995b5d38e7cc24cac3de8dfd516115f86b0bcf80 by Gregory P. Smith
(Christian Heimes) in branch 'master':
bpo-38153: Normalize hashlib algorithm names (GH-16083)
https://github.com/python/cpython/commit/995b5d38e7cc24cac3de8dfd516115f86b0bcf80
Gregory P. Smith added the comment:
as discussed, not pushing this back into 3.7 as we aren't hearing users call
this a problem.
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue38
Change by Gregory P. Smith :
--
pull_requests: +15712
pull_request: https://github.com/python/cpython/pull/16091
___
Python tracker
<https://bugs.python.org/issue36
Change by pmp-p :
--
nosy: +twouters -pmpp
___
Python tracker
<https://bugs.python.org/issue35243>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
AIX has the same error as RHEL and Fedora
https://buildbot.python.org/all/#/builders/161/builds/1615/steps/5/logs/stdio
--
___
Python tracker
<https://bugs.python.org/issue36
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue36046>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
and some Fedora and RHEL bots are failing with:
==
ERROR: test_extra_groups (test.test_subprocess.POSIXProcessTestCase
Gregory P. Smith added the comment:
The 'Debian root' buildbot exposed a unittest issue to deal with:
https://buildbot.python.org/all/#/builders/27/builds/3702/steps/5/logs/stdio
==
ERROR: test_user
Gregory P. Smith added the comment:
New changeset 7cad53e6b084435a220e6604010f1fa5778bd0b1 by Gregory P. Smith
(Christian Heimes) in branch 'master':
bpo-9216: Add usedforsecurity to hashlib constructors (GH-16044)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
I'm curious to see what weird things the various buildbot platforms find for
this one. crossing my fingers.
--
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
New changeset 2b2ead74382513d0bb9ef34504e283a71e6a706f by Gregory P. Smith
(Patrick McLean) in branch 'master':
bpo-36046: Add user and group parameters to subprocess (GH-11950)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
Adding a check for SUDO_USER would break existing uses as it would no longer be
reporting the user the process is running as.
--
assignee: -> gregory.p.smith
resolution: -> rejected
stage: patch review -> resolved
status: open ->
Gregory P. Smith added the comment:
thanks!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
While there is technically still time, it'd take people spending dedicated time
on it before the 3.8 release. I won't be.
Important? Sure. But not urgent; this bug is not new. We've lived with it
for many releases already. I believe it has been
Gregory P. Smith added the comment:
New changeset 98a4a713d001cf2dfb04a9e318e4aea899bc8fbd by Gregory P. Smith
(Miss Islington (bot)) in branch '3.8':
bpo-37935: Added tests for os.walk(), glob.iglob() and Path.glob() (GH-15956)
(GH-16043)
https://github.com/python/cpython/commit
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset c6734ee7c55add5fdc2c821729ed5f67e237a096 by Gregory P. Smith
(Sergey Fedoseev) in branch 'master':
bpo-37802: Slightly improve perfomance of PyLong_FromUnsigned*() (GH-15192)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
New changeset 4ffd05d7ec47cfd0d7fc95dce851633be9663255 by Gregory P. Smith
(animalize) in branch 'master':
bpo-21872: fix lzma library decompresses data incompletely (GH-14048)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
New changeset 2f1b857562b0f1601c9019db74c29b7d7e21ac9f by Gregory P. Smith
(Berker Peksag) in branch 'master':
bpo-36991: Fix incorrect exception escaping ZipFile.extract() (GH-13632)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
automated backport of the gdb/libpython change fails on 3.6, if this is needed
there (I haven't looked into the code on that branch), it's a tiny change to
apply. i'll leave that to the 3.6 RM to decide if at all.
--
resolution: -> fixed
st
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 99b54d68172ad64ba3d0fdc0137f0df88c28ea2b by Gregory P. Smith (T.
Wouters) in branch 'master':
Revert "Fix depth-first-search computation in compile.c (GH-16042)" (GH-16050)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
New changeset f9dc2ad89032201427ed5f08061c703794627ad9 by Gregory P. Smith
(Serhiy Storchaka) in branch 'master':
bpo-37935: Added tests for os.walk(), glob.iglob() and Path.glob() (GH-15956)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
New changeset 64117e059b79236c7345bc9afc1cc707162411de by Gregory P. Smith
(Christian Heimes) in branch 'master':
bpo-38134: Remove PKBDF2_HMAC_fast from _hashopenssl (GH-16028)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
New changeset 2c910c1e732c9a3ec4c67a7c43d789d6c729304a by Gregory P. Smith
(Julien Palard) in branch 'master':
bpo-36675: Remove obsolete code. (GH-16024)
https://github.com/python/cpython/commit/2c910c1e732c9a3ec4c67a7c43d789d6c729304a
--
nosy
Gregory P. Smith added the comment:
i reopened this without diving into the code to better understand based on
Samuels comment.
We could really do with a testcase that demonstrates the misleading error
message problem for some test driven development here.
--
keywords: -patch
Change by Gregory P. Smith :
--
resolution: fixed ->
stage: resolved -> needs patch
status: closed -> open
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: -> michael.foord
___
Python tracker
<https://bugs.python.org/issue36871>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
New changeset e20134f889a0cfcc37a46979f31a1c98b800de07 by Gregory P. Smith
(Jakub Kulík) in branch 'master':
bpo-38110: Use fdwalk for os.closerange() when available. (GH-15224)
https://github.com/python/cpython/commit
Gregory P. Smith added the comment:
"""On Solaris, we are patching (for many years now) `posix_closerange` function
to use `fdwalk` to close file descriptors instead of a for loop. While for a
long time only Solaris had `fdwalk`, but if I am not mistaken, some other OSes
imp
Change by Gregory P. Smith :
--
priority: normal -> low
___
Python tracker
<https://bugs.python.org/issue37091>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
Thanks. I believe this issue is fixed but you've identified follow-on issues.
lets follow up on those in their own bugs.
--
resolution: -> fixed
stage: patch review -> commit review
status: open -&g
Gregory P. Smith added the comment:
contribution from Jakub Kulík (see the PR)
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issu
New submission from Gregory P. Smith :
On POSIX platforms that support the fdwalk() API, use it within the
os.closerange() implementation.
--
components: Demos and Tools
messages: 351875
nosy: gregory.p.smith
priority: normal
severity: normal
stage: patch review
status: open
title
Gregory P. Smith added the comment:
New changeset c37447481ec8f6d0e49d0587ec0de3f9e7d56b28 by Gregory P. Smith in
branch 'master':
bpo-28494: install ziptestdata to fix install bot (GH-15902)
https://github.com/python/cpython/commit/c37447481ec8f6d0e49d0587ec0de3f9e7d56b28
Gregory P. Smith added the comment:
New changeset 7a0023e8d17566eb32c836b65c33663303a2224f by Gregory P. Smith
(smokephil) in branch 'master':
bpo-25810: Clarify eval() docs, it does not keywords (GH-15173)
https://github.com/python/cpython/commit/7a0023e8d17566eb32c836b65c33663303a2224f
Change by Gregory P. Smith :
--
pull_requests: +15543
pull_request: https://github.com/python/cpython/pull/15902
___
Python tracker
<https://bugs.python.org/issue28
Gregory P. Smith added the comment:
For some context here, the pathlib scandir code was written by Serhiy in
https://bugs.python.org/issue26032 and related commit
https://github.com/python/cpython/commit/680cb152c5d220a74321fa905d4fc91bdec40fbb.
> Any optimization can be accepted only w
Gregory P. Smith added the comment:
The new ziptestdata/ subdir appears to not be part of the install that make
install does. :/
--
___
Python tracker
<https://bugs.python.org/issue28
Gregory P. Smith added the comment:
Shai, please open the 'Your Details' link in the bugs.python.org sidebar and
make sure you have your github username filled in. it needs to say ShaiAvr for
our CLA automation to understand.
Avoiding calling list() on the output of scandir() is always
New submission from Gregory P. Smith :
https://github.com/python/cpython/pull/15274
--
assignee: gregory.p.smith
messages: 351700
nosy: gregory.p.smith
priority: normal
severity: normal
status: open
title: unneeded assignment to wb.len in PyBytes_Concat using buffer protocol
versions
Change by Gregory P. Smith :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue38047>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +15502
pull_request: https://github.com/python/cpython/pull/15853
___
Python tracker
<https://bugs.python.org/issue28
Change by Gregory P. Smith :
--
nosy: +benjamin.peterson
___
Python tracker
<https://bugs.python.org/issue1652>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
I believe this has been addressed.
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.4
___
Python tracker
<https://bugs.python.org/issue13788>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
oh well, no pony for us this decade. :)
--
___
Python tracker
<https://bugs.python.org/issue37055>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
META: Do we still have platforms we support that we do not also require a
modern enough OpenSSL version in order for CPython to build that'd provide
blake2 for us?
I'd love to ditch maintenance of our own copies of the various secure hash
function
Gregory P. Smith added the comment:
FWIW, _posixsubprocess.fork_exec() should be safe to allow.
The only thing within it to disallow, if you're going to bother to check this
at all, is any use of the legacy preexec_fn support.
--
nosy: +gregory.p.smith
Gregory P. Smith added the comment:
The signal handler in this case is CPython's internal signal handling system
thus any such onus falls on us...
The great signal handling hack of "set a flag that the interpreter loop checks
on occasion" trick lasted a long time, but our VM
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue29988>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue32949>
___
___
Python-bugs-list mailin
New submission from Gregory P. Smith :
21 tests failed:
test_asynchat test_asyncore test_docxmlrpc test_eintr test_epoll
test_ftplib test_httplib test_imaplib
test_multiprocessing_forkserver test_multiprocessing_spawn
test_nntplib test_os test_poplib test_robotparser
901 - 1000 of 5107 matches
Mail list logo
