Quentin Pradet added the comment:
Thanks, you're right, I ran `git bisect` on Linux and the commit that causes
the issue is
https://github.com/python/cpython/commit/135cabd328504e1648d17242b42b675cdbd0193b
("Copy free variables in bytecode to allow calls to inner func
Quentin Pradet added the comment:
The ABI between alpha 2 and alpha 3 changed, see
https://bugs.python.org/issue46320. If pip built (say) cffi in CI for alpha2
and put it in the cache, then it reused that wheel for alpha3 and the segfault
is expected.
--
nosy: +Quentin.Pradet
Quentin Pradet added the comment:
Oh my god. You're right, I had a cffi wheel compiled for Python 3.11 before
that commit. But the wheel was not coming from PyPI, it was coming from pip's
own cache! And we recently enabled pip's cache in GitHub Actions too.
So the wheel compiled locally
Quentin Pradet added the comment:
We haven't opened an issue for this, but discussed it in Discord, sorry. It
also does not always crash on GitHub Actions. Here's an example of a crash:
https://github.com/urllib3/urllib3/runs/4740730329?check_suite_focus=true
If nox can't find your Python
Quentin Pradet added the comment:
Yes, exactly. `pip install nox && nox -Rs test-3.11`. My reproducer is still
too big to be useful, and I failed to reproduce this on Docker. If you can't
reproduce, I'll work on the reproducer more
Quentin Pradet added the comment:
For what it's worth, this refactoring led to a 100% reproducible crash on my
Fedora laptop: https://bugs.python.org/issue46320. (And led to various crashes
in urllib3's CI, but they were more random.)
--
nosy: +Quentin.Pradet
Quentin Pradet added the comment:
Sorry, I pasted the same crash twice. Here's the segmentation fault in
`selectors`:
```
=
test session starts
New submission from Quentin Pradet :
Since
https://github.com/python/cpython/commit/32a67246b0d1e08cd50fc3bfa58052cfeb515b2e
which was introduced through https://bugs.python.org/issue46008 and shipped as
part of alpha 3, the urllib3 test suite reliably crashes on Fedora 35 (ie.
gives
Quentin Pradet added the comment:
Thank you for the quick fix! Both the reproducer and the urllib3 test suite
run fine with this change.
However, we can't trust `HAS_NEVER_CHECK_COMMON_NAME` anymore, because it will
be True in Python versions where `hostname_checks_common_name` does
Change by Quentin Pradet :
Added file: https://bugs.python.org/file49883/server.key
___
Python tracker
<https://bugs.python.org/issue43522>
___
___
Python-bugs-list m
Change by Quentin Pradet :
Added file: https://bugs.python.org/file49881/client.pem
___
Python tracker
<https://bugs.python.org/issue43522>
___
___
Python-bugs-list m
Change by Quentin Pradet :
Added file: https://bugs.python.org/file49882/server.pem
___
Python tracker
<https://bugs.python.org/issue43522>
___
___
Python-bugs-list m
Change by Quentin Pradet :
Added file: https://bugs.python.org/file49880/app.py
___
Python tracker
<https://bugs.python.org/issue43522>
___
___
Python-bugs-list mailin
New submission from Quentin Pradet :
urllib3 is preparing a v2 with various SSL improvements, such as leaning on the
ssl module to match hostnames when possible and reject certificates without a
SAN. See
https://urllib3.readthedocs.io/en/latest/v2-roadmap.html#modern-security-by-default
Quentin Pradet added the comment:
Thanks levkivskyi, it fixed the issue for me!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Quentin Pradet <quentin.pra...@gmail.com>:
--
nosy: +Quentin.Pradet
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Quentin Pradet:
>From https://docs.python.org/3.6/howto/unicode.html#the-string-type:
> The following examples show the differences::
>
> >>> b'\x80abc'.decode("utf-8", "strict") #doctest: +NORMALIZE_WHITESPA
Quentin Pradet added the comment:
Martin, yes, I'd be glad to see a fix if it's not too complicated.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21049
Changes by Quentin Pradet quentin.pra...@gmail.com:
--
nosy: +Quentin.Pradet
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21052
___
___
Python
Quentin Pradet added the comment:
I've also been affected by this when testing integration with a third-party
library (NLTK). NLTK does need to be fixed, but the ResourceWarning already say
so.
The new one-liner doesn't seem contrived to me.
--
nosy: +Quentin.Pradet
Quentin Pradet added the comment:
The branch appears to exist now.
--
nosy: +Quentin.Pradet
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18983
21 matches
Mail list logo