[issue31186] Support heapfix() and heapremove() APIs in heapq module

2017-08-13 Thread Rajath Agasthya
Rajath Agasthya added the comment: And yes, both of these methods do take index as the argument as shown in my patch file. I should've probably specified that. The signatures are: heapfix(heap, pos) heapremove(heap, pos) -- ___ Python tracker

[issue31186] Support heapfix() and heapremove() APIs in heapq module

2017-08-13 Thread Rajath Agasthya
Rajath Agasthya added the comment: > The only hacks around that I could think of required a more complex kind of > heap; e.g., restricting heap items to objects usable as dict keys, using a > hidden dict to map heap items to their current index, and fiddling all the > heap operat

[issue31186] Support heapfix() and heapremove() APIs in heapq module

2017-08-13 Thread Rajath Agasthya
Rajath Agasthya added the comment: Thanks, Raymond. I think it's fair comment, but I'm not sure which operation is O(n) though. FWIW, Go supports these operations (https://golang.org/pkg/container/heap/), so the usage is there. -- ___ Python

[issue31186] Support heapfix() and heapremove() APIs in heapq module

2017-08-11 Thread Rajath Agasthya
New submission from Rajath Agasthya: I'd like to suggest a couple of utility methods for the heapq module which I think are useful: 1. heapfix() - Re-establishes heap invariant after item at 'any index' in the heap changes its value. Currently, the way to fix the heap after an arbitrary item

[issue31029] test_tokenize fails when run directly

2017-08-03 Thread Rajath Agasthya
Changes by Rajath Agasthya <rajathagast...@gmail.com>: -- pull_requests: +3035 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue29510] gitignore settings files for Eclipse IDE

2017-03-24 Thread Rajath Agasthya
Changes by Rajath Agasthya <rajathagast...@gmail.com>: -- pull_requests: +715 ___ Python tracker <rep...@bugs.python.org> <http://bugs.python