Sean Reifschneider added the comment:
Toshio and Matthias: This approach seems sane to me, Nick asked me to review
this ticket. I'm not coming up with any objections. +1 for retiring SO at
some point after 3.2, and EXT_SUFFIX and SHLIB_SUFFIX.
What documentation needs to be changed? PEP
Sean Reifschneider added the comment:
This may be related to: http://bugs.python.org/issue17424
Perhaps there is a common fix that can address this for both?
--
nosy: +jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17053
Sean Reifschneider added the comment:
This might be a duplicate of issue17053, but the patch provided there doesn't
resolve the issue, at least as far as I know it. Here is an example, from
David Beazley's talk at PyCon 2013:
from inspect import Parameter, Signature
def make_signature(names
Sean Reifschneider added the comment:
I've tried to test this but v4 doesn't apply cleanly after pure2 is applied,
and v4 doesn't include enough to test it (applying v4 only causes test
failures).
I reviewed v4 and it looks fine in general. I do see that there are changes in
it unrelated
New submission from Sean Reifschneider:
David Beazley in his tutorial pointed out that you could use a metaclass to
create function signatures for the common use case of:
class foo:
def __init__(self, name, value, high, low):
self.name = name
self.value = value
Sean Reifschneider j...@tummy.com added the comment:
Working on this.
--
nosy: +jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14259
Sean Reifschneider j...@tummy.com added the comment:
Attached is a patch which implements this, including updated tests. I would
appreciate a review of this patch.
--
assignee: - ezio.melotti
keywords: +needs review, patch
stage: - patch review
Added file: http://bugs.python.org
Sean Reifschneider j...@tummy.com added the comment:
Michele: Do you know what needs to be done to determine the resolution to the
_warnings/pgen question? If not, maybe asking the question on python-dev could
get some advice.
--
nosy: +jafo
Sean Reifschneider j...@tummy.com added the comment:
The attached patch does change the semantics somewhat, but I don't fully
understand how much. In particular:
It changes the get() call to be turned into get(timeout=1.0) if inqueue
doesn't have a _reader attribute.
In the case that inqueue
Sean Reifschneider j...@tummy.com added the comment:
Martin: They are looking for you to review this, in particular see:
http://bugs.python.org/issue7511#msg106420
--
assignee: tarek - loewis
nosy: +jafo
___
Python tracker rep...@bugs.python.org
Sean Reifschneider j...@tummy.com added the comment:
Éric: In http://bugs.python.org/issue8954#msg135902 are you saying:
This issue needs to be re-targeted to a newer Python.
Close -- won't fix.
Something else?
This issue seems to be stuck here, any ideas on what needs to be done to move
Sean Reifschneider j...@tummy.com added the comment:
Committed in r88500.
--
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Sean Reifschneider j...@tummy.com added the comment:
Thanks. I had just read that a day or so ago, reviewing it for Brett's work.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Sean Reifschneider j...@tummy.com added the comment:
At this point I'm going to consider this good to go, and will commit it after
the 3.2 final release. Thanks for the review everyone. Of course, I'm open to
further suggestions until then, just not expecting any...
--
assignee
Changes by Sean Reifschneider j...@tummy.com:
--
nosy: -jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
___
Python-bugs-list mailing
Changes by Sean Reifschneider j...@tummy.com:
Removed file: http://bugs.python.org/file20428/python-underscore_crypt-3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Sean Reifschneider j...@tummy.com added the comment:
Sure thing, here's an svn diff. I had switched to the diff because I
couldn't get it to patch into a fresh trunk, but the format looked fine; not
sure why it couldn't find the files. Anyway, here's a new version.
--
Added file
Sean Reifschneider j...@tummy.com added the comment:
Not sure if that was meant to be a suggestion for why my local patching wasn't
working from the svn diff output, but obviously -5 was messed up. Here's a
new version that I can apply to my fresh trunk and passes make test
Sean Reifschneider j...@tummy.com added the comment:
Thanks for the pointer about patch -p0. I *HAD* tried that, but it didn't
seem to work either. I'll double check that though... svn diff is what I'd
prefer, because then I can svn commit it when it's ready.
Any other review feedback
Sean Reifschneider j...@tummy.com added the comment:
Affirmative on the svn mv for the C module.
The duplicated code, thanks for pointing that out. Someone else mentioned it,
but I didn't understand what they were saying and they didn't reply to my
request for clarification. Fixed
Changes by Sean Reifschneider j...@tummy.com:
Removed file: http://bugs.python.org/file20433/python-underscore_crypt-4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Changes by Sean Reifschneider j...@tummy.com:
Removed file: http://bugs.python.org/file20442/python-underscore_crypt-5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Changes by Sean Reifschneider j...@tummy.com:
Removed file: http://bugs.python.org/file20443/python-underscore_crypt-6.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Sean Reifschneider j...@tummy.com added the comment:
Oops, thanks. It's in there now, though for some reason I can't get this patch
to apply to trunk, but I'll have to look at that later this afternoon. I
wanted to get this new version up in the interim since it definitely does
include
Changes by Sean Reifschneider j...@tummy.com:
Removed file: http://bugs.python.org/file20422/python-underscore_crypt.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Sean Reifschneider j...@tummy.com added the comment:
I've made a new .patch file using diff -c rather than svn diff. This is
the same code, but applies without manual intervention.
--
Added file: http://bugs.python.org/file20428/python-underscore_crypt-3.patch
Changes by Sean Reifschneider j...@tummy.com:
Removed file: http://bugs.python.org/file20427/python-underscore_crypt-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10924
Sean Reifschneider j...@tummy.com added the comment:
Thanks for the review. Attached is a new version of the patch.
1) Done.
2) Good point, I didn't think of that. I've changed it into a class that
stores the methods list, and made the module methods point to that method on
an instance
New submission from Sean Reifschneider j...@tummy.com:
Over the years I've written the same code over and over to create a random salt
string of 2 characters. Worse, the Modular Crypt Format is difficult to find
documentation on, so creating stronger hashed passwords is difficult to get
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Some time ago I accepted a patch to base the memcache client module on
the threading.local class. Now I've got some reports of issues with
this that I'm not sure what the best way to resolve is.
Bug #530229:
Sean Reifschneider j...@tummy.com added the comment:
This issue came up on #python IRC, and that combined with the number of times
this has been duplicated makes me think that maybe the mention of the
SortedCollection recipe should be a little more prominent.
Perhaps either moved up
Sean Reifschneider j...@tummy.com added the comment:
Committed to 2.7 in 81681 and 3.x in 81682.
--
keywords: +needs review -patch
resolution: - accepted
stage: - committed/rejected
status: open - closed
type: - feature request
___
Python tracker
Sean Reifschneider j...@tummy.com added the comment:
In this case, the docs.python.org link you point to seems to be correct, saying
that it returns a timedelta. It is the docstring that says it's minutes east
of UTC.
I've attached a patch which changes this wording to:
timedelta() showing
Sean Reifschneider j...@tummy.com added the comment:
Alternately, here is a patch that just takes the docs.python.org description.
--
Added file: http://bugs.python.org/file17496/python-utcoffsetdoc2.patch
___
Python tracker rep...@bugs.python.org
Sean Reifschneider j...@tummy.com added the comment:
Then how about:
timedelta() showing offset from UTC, negative values indicating West of UTC
?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8810
Sean Reifschneider j...@tummy.com added the comment:
I'm fine without ().
I thought the direction was generally initial-capped, but I may be wrong there.
Let's go with west.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Sean Reifschneider j...@tummy.com added the comment:
This won't go into 2.7.0. I will do a patch for 3.x, and wait for 2.7.0 to see
if it can go into 2.7.1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8214
Sean Reifschneider j...@tummy.com added the comment:
This won't go into 2.7.0. I will do a patch for 3.x, and wait for 2.7.0 to see
if it can go into 2.7.1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8214
Changes by Sean Reifschneider j...@tummy.com:
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8214
___
___
Python-bugs-list mailing list
Sean Reifschneider j...@tummy.com added the comment:
I have completed the exception handling code as prototyped in msg101687.
Please review.
--
assignee: - jafo
keywords: +needs review
stage: needs patch - patch review
Added file: http://bugs.python.org/file17159/logexception2.patch
Sean Reifschneider j...@tummy.com added the comment:
Jack Diederich commented:
I don't have my tracker login on this computer so I'll post here.
I'd +1 on making the module python with just the core functionality
imported from C (it releases the GIL when doing IO). Then you
could replace
Sean Reifschneider j...@tummy.com added the comment:
Thanks for the review Jack.
I was very tempted to split it into C and Python components, but I decided
against it because it's so close to the 2.7 release. I think it would be
best to defer that for the Python 3 release, because of potential
Sean Reifschneider j...@tummy.com added the comment:
Changed to use import_module.
--
Added file: http://bugs.python.org/file17177/logexception4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8214
Sean Reifschneider j...@tummy.com added the comment:
Switched to using assertTrue/assertFalse.
--
Added file: http://bugs.python.org/file17179/logexception5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8214
Sean Reifschneider j...@tummy.com added the comment:
I believe I have the first function implemented. See the attached patch for
that code and feel free to review.
--
keywords: +patch
nosy: -haypo
Added file: http://bugs.python.org/file17089/logexception.diff
Sean Reifschneider j...@tummy.com added the comment:
Collin: Antoine has asked for some feedback, can you answer that question?
--
assignee: - collinwinter
nosy: +jafo
priority: - normal
___
Python tracker rep...@bugs.python.org
http
Sean Reifschneider j...@tummy.com added the comment:
Committed as 80396. Included a change to let openlog(3) pick the ident instead
of using the static string python.
--
resolution: - accepted
status: open - closed
___
Python tracker rep
Sean Reifschneider j...@tummy.com added the comment:
Ported to python3 and committed as 80401.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8451
Sean Reifschneider j...@tummy.com added the comment:
Ok, so I left the argument style in the docs as it was.
*** NOTE ***: Sean: Change this for the 3 trunk commit.
Setting the python string is outside of the argv function because we want to
use python on any of the many places where
Changes by Sean Reifschneider j...@tummy.com:
Added file: http://bugs.python.org/file16983/syslog-kwargs2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8451
Sean Reifschneider j...@tummy.com added the comment:
Antoine: I believe I have everything you mentioned addressed with the new
patch. That was an awesome review, thank you so much.
The only things I didn't do were parts of the last two items you bring up:
If PyTuple_New(0) fails, bail out
New submission from Sean Reifschneider j...@tummy.com:
As discussed in this thread:
http://mail.python.org/pipermail/python-dev/2010-March/098500.html
The syslog module is using the C argv[0] as the program name, not the python
sys.argv[0]. So, in most cases this means that unless you
Changes by Sean Reifschneider j...@tummy.com:
Added file: http://bugs.python.org/file16982/syslog-kwargs.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8451
Changes by Sean Reifschneider j...@tummy.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8451
___
___
Python-bugs-list
Sean Reifschneider j...@tummy.com added the comment:
Sorry for the delay in getting to this patch.
I've reviewed this patch and it seems fine to me. The only thing I see
outstanding is the recommendation made by Alexandre about changing the C module
to also implement this.
Aaron: You may
Sean Reifschneider j...@tummy.com added the comment:
Ugh, I forgot to check the output of my test run before submitting the last
reply. With the patch applied, make test fails with:
test_pickle
Fatal Python error: Cannot recover from stack overflow.
Fatal Python error: Cannot recover from
Sean Reifschneider j...@tummy.com added the comment:
pickle_batch_list_exact_py3k.diff applies cleanly on current py3k trunk and
passes tests. cpickle_list.patch applies cleanly against 2.x trunk and passes
make test.
I don't see any objections brought up about this set of patches, so we can
Sean Reifschneider j...@tummy.com added the comment:
From a cursory glance, I don't see any problems with this patch. Though I
admit that I don't know the traceback code nearly as well as you, Amaury. The
tests pass on py3k trunk on my Linux box.
If you want other review, perhaps ask
Changes by Sean Reifschneider j...@tummy.com:
--
priority: - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6543
___
___
Python-bugs-list
Sean Reifschneider j...@tummy.com added the comment:
Since this needs review, and Christian is the author of that PEP, I'm assigning
it to him. If not appropriate, any suggestions on where to get visibility to
get reviewers?
--
assignee: ronaldoussoren - christian.heimes
nosy
Changes by Sean Reifschneider j...@tummy.com:
--
priority: - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7072
___
___
Python-bugs-list
Sean Reifschneider j...@tummy.com added the comment:
Tarek: This patch seems reasonable to me, is this something that can be applied?
--
nosy: +jafo
priority: - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4931
Sean Reifschneider j...@tummy.com added the comment:
The final word on this seems to be this:
- Wait until when we aren't in a beta release. (DONE)
- Quoting:
Well, For Py3K at least we might need to consider going through the C
API and fixing it so that these incorrect
Sean Reifschneider j...@tummy.com added the comment:
Andrew: There have been changes committed within the last week to #7712, which
Florent suggested might be related. Can you please re-test this to see if it
still exists, and if it does, bug me and I'll try to get some more movement
Sean Reifschneider j...@tummy.com added the comment:
I've posted to python-dev asking for a reviewer for this, the thread is at
http://mail.python.org/pipermail/python-dev/2010-March/098597.html
--
nosy: +jafo
___
Python tracker rep
Sean Reifschneider j...@tummy.com added the comment:
Committed to release26-maint as 77514.
Committed to trunk as 77515.
Committed to 3k as 77516.
--
resolution: - accepted
stage: - committed/rejected
status: open - closed
___
Python tracker rep
New submission from Sean Reifschneider j...@tummy.com:
As detailed in the python-dev post:
http://mail.python.org/pipermail/python-dev/2009-July/090791.html
I have found a bug in the handling of PyArg_ParseTuple where a NUL in an
argument causes a message like this:
syslog.syslog('hello
Sean Reifschneider j...@tummy.com added the comment:
Fixed in python trunk commit 74277.
Fixed in py3k trunk commit 74278.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6624
free to either discuss
it on the python mailing list or via e-mail to jafo-commun...@tummy.com
Thanks,
Sean
--
Never interrupt your enemy when he is making a mistake.
-- Napoleon Bonaparte
Sean Reifschneider, Member of Technical Staff j...@tummy.com
tummy.com, ltd. - Linux
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I'm attaching a new version here, which addresses the object call type
comments.
Added file: http://bugs.python.org/file11948/pass-examples-2.patch
___
Python tracker [EMAIL PROTECTED]
http
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I originally had that, but then I realized that if I make it a comment I
can then do something like dw. on that line when I start filling in
the code to keep the comment around. Because I find that when I fill in
the high level comments
New submission from Sean Reifschneider [EMAIL PROTECTED]:
I'm giving a Python tutorial to a bunch of local people and have decided
to use the Python.org tutorial to go by. One of the things I found I
wanted in the section on the pass statement was more information about
it's use. But I also
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Don't modify Modules/Setup*, do as the message says and modify setup.py.
Search for 4, 5, and change that to 4, 6, then run configure and
make and it will build without this message.
I have done this against the py3k trunk and it built
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I just tested it under Linux Fedora 8 Firefox 3 and it shows results for
the searches move and rename and got reasonable-looking results.
--
nosy: +jafo
priority: - normal
resolution: later - works for me
status: pending - closed
Sean Reifschneider [EMAIL PROTECTED] added the comment:
This patch looks ok to me, but I'd like jlt63 to review it since they
were the last to touch these regexes.
--
assignee: - jlt63
keywords: +easy
nosy: +jafo, jlt63
priority: - normal
type: - behavior
Sean Reifschneider [EMAIL PROTECTED] added the comment:
This patch looks good to me. Greg?
--
assignee: - gward
components: +Distutils -Library (Lib)
keywords: +easy
nosy: +gward, jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Back-ported to 2.5 and committed in rev 61675.
--
nosy: +jafo
priority: - normal
status: pending - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2238
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I would agree with Georg that there isn't anything we can do about this.
I had someone try from the Windows XP command shell and: dir /w
reports that it can't run the combined command, where: dir /w works just
fine.
My conclusions
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
assignee: - georg.brandl
nosy: +georg.brandl
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2243
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Fred: You most recently touched the code impacted by this test, does
this sound reasonable?
--
assignee: - fdrake
nosy: +fdrake, jafo
priority: - normal
type: behavior - resource usage
versions: +Python 2.6
Sean Reifschneider [EMAIL PROTECTED] added the comment:
It's actually been quite a while since it changed from being
Modules/Setup to being in setup.py, I think a couple of years at least.
And, yes, I realize that Fedora is changing the Modules/Setup file in
their SRPM, but with Python 3k
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I'm going to push this to pending until you can get a patch. Thanks, Jamie.
--
nosy: +jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
status: open - pending
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2211
__
___
Python-bugs-list mailing list
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Kei: The documentation does not say that quit() returns a value, so the
current behavior is correct. However, SMTP defines a return value for
QUIT, so there is a case for smtplib.quit() returning that value.
This patch does need
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Is a straightforward patch, but I'd like NAS to comment on the change in
behavior. Probably would also need a documentation change, are you up
for doing that Lorenz?
--
assignee: - nascheme
keywords: +easy
nosy: +jafo, nascheme
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue
__
___
Python-bugs-list mailing list
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
assignee: - fdrake
components: +Documentation -Interpreter Core
nosy: +fdrake
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2102
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Giampaolo: Can you pleaes bring this up on python-dev or the normal
python mailing list for further discussion on the issue?
--
assignee: - akuchling
keywords: +patch
nosy: +akuchling, jafo
priority: - normal
type: - feature
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Daniele: Please provide an updated version of this patch based on the
feedback below.
--
assignee: - gregory.p.smith
keywords: +patch
nosy: +gregory.p.smith, jafo
priority: - normal
type: crash - behavior
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Rick: In the future, please provide a context or unified diff (diff
-c) so that we get the file name that the diff is for and some
additional context.
--
assignee: - tim_one
keywords: +patch
nosy: +jafo, tim_one
priority
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
assignee: - loewis
keywords: +patch
nosy: +loewis
priority: - normal
title: [patch] Read support for Records in msilib - Read support for Records
in msilib
__
Tracker [EMAIL PROTECTED]
http
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Martin: What do you think of this patch?
--
assignee: - loewis
nosy: +jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1390
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Marc-Andre: Wit the udpated patches, is this a set of patches we can accept?
--
assignee: - lemburg
keywords: +patch
nosy: +jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Marc-Andre: How should we proceed with this bug? Discuss on python-dev
or c.l.python?
--
assignee: - lemburg
keywords: +patch
nosy: +jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http
Sean Reifschneider [EMAIL PROTECTED] added the comment:
smtplib is for sending messages via SMTP, not for testing to see if a
user is behind an ISP that is incorrectly blocking outgoing SMTP
connections. I would argue the incorrectly because they are dropping
rather than rejecting
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
assignee: - ping
nosy: +ping
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2141
__
___
Python
Changes by Sean Reifschneider [EMAIL PROTECTED]:
--
assignee: - loewis
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2148
__
___
Python-bugs-list
Sean Reifschneider [EMAIL PROTECTED] added the comment:
Patch is inline.
--
assignee: - gward
keywords: +patch
nosy: +gward, jafo
priority: - normal
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2155
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I don't see the problem with the example listed in the last message. It
sounds like the Tix documentation is confirming that this is the desired
behavior.
--
nosy: +jafo
priority: - normal
resolution: - works for me
status: open
Sean Reifschneider [EMAIL PROTECTED] added the comment:
I'm closing this as a duplicate of #1858.
--
nosy: +jafo
resolution: - duplicate
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1741
1 - 100 of 292 matches
Mail list logo
