Re: Code smells: too many parameters, too many attributes (was: pylint -- should I just ignore it sometimes?)

2010-10-19 Thread Seebs
On 2010-10-20, Ben Finney wrote: > It's a code smell. Many discrete attributes is a sign that the design > can be improved by combining related attributes into a complex type. Ahh. I think that makes sense. In this case, I don't think it's worth it, but I can see why it would be in some cases.

Code smells: too many parameters, too many attributes (was: pylint -- should I just ignore it sometimes?)

2010-10-19 Thread Ben Finney
Seebs writes: > I'm pretty much mystified by a claim that something with seven > instance attributes is "too complicated". It's a code smell. Many discrete attributes is a sign that the design can be improved by combining related attributes into a complex type. It's pretty much the same smell,