Changes by Éric Araujo mer...@netwok.org:
--
resolution: accepted - out of date
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
Éric Araujo mer...@netwok.org added the comment:
Changing “if s in 'yn'” to “if s in ('y', 'n')” is not really an
improvement. It’s not more readable to always use tuples or frozensets
for membership testing; str has __contains__ for a reason :)
Let me eat my words: using “in 'yn'” matches
Changes by Michael Mulich michael.mul...@gmail.com:
--
nosy: +michael.mulich
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
___
Éric Araujo mer...@netwok.org added the comment:
FYI, the mkcfg module has seen a lot of change since last summer, some of which
have bad style. I still have this bug on my todo list to fix that.
--
___
Python tracker rep...@bugs.python.org
Changes by Sean Reifschneider j...@tummy.com:
--
nosy: -jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
___
Python-bugs-list mailing
Changes by Éric Araujo mer...@netwok.org:
--
versions: +3rd party -Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Éric Araujo mer...@netwok.org added the comment:
I have six changesets that make progressive improvements on cosmetic things, so
that the code gets more readable. You can start with
http://bitbucket.org/Merwok/distutils2-killsetup/changeset/5e2906cabeab and
follow the parent links.
The other
Éric Araujo mer...@netwok.org added the comment:
After speaking with a Montreal-Python hacker about my use case and reading the
PyMOTW page for cmd, I think that using raw_input and print is actually the way
to go. We don’t want the user to enter commands, just to answer questions.
--
Éric Araujo mer...@netwok.org added the comment:
I’m assigning this bug to myself as part of my work on #8252. Dan, I’ll sort
the various fixes in your patch and replay them incrementally. I’ll be pleased
to work with you if you have time (find me in #distutils or through email), if
you don’t
Changes by Éric Araujo mer...@netwok.org:
--
resolution: accepted - fixed
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3758
___
Éric Araujo mer...@netwok.org added the comment:
I’ve started to review your patch but I find it a bid unwieldy to read. Would
you mind exporting changesets to patches? I tried to look at your repo, but
didn’t know which branch to look at.
So, thanks for giving us the occasion of thinking
Dan Buch daniel.b...@gmail.com added the comment:
@merwok much thanks for the feedback. After seeing how you're working via
bitbucket I've decided to create a fresh fork from tarek and recreate my patch
in multiple changesets all within the default branch. I'll update the issue
when
Changes by Dan Buch daniel.b...@gmail.com:
Removed file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Added file: http://bugs.python.org/file17406/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Added file: http://bugs.python.org/file17407/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Removed file: http://bugs.python.org/file17406/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
Added file: http://bugs.python.org/file17408/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
___
Changes by Dan Buch daniel.b...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file17385/mkpkg-round-of-pylinting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
Dan Buch daniel.b...@gmail.com added the comment:
The attached mkpkg-round-of-pylinting.patch is known to cleanly apply to
tarek's branch @ 541f90ef0636
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
Dan Buch daniel.b...@gmail.com added the comment:
I've started work on cleanup of ``mkpkg.py`` per instruction from jafo, am
pushing to a branch 'mbh/mkpkg-cleanup' of my distutils2 fork:
http://bitbucket.org/meatballhat/distutils2/changeset/be40174c59e2
I'll attach patch(es) when
Dan Buch daniel.b...@gmail.com added the comment:
bump.
Would it be more helpful if I were to submit a patch, too, or is doing so prior
to guidance from the driver (Tarek) frowned upon?
--
___
Python tracker rep...@bugs.python.org
Tarek Ziadé ziade.ta...@gmail.com added the comment:
I am adding Sean (jafo) who wrote this module. He'll have the best answer :)
--
nosy: +jafo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8591
New submission from Dan Buch daniel.b...@gmail.com:
On first glance, `distutils2.mkpkg` does not reflect the latest and greatest in
Python coding standards. I'd like to take a stab at PEP-(7|8)'ing the whole
thing, although I know there are other issues open to add features to the
module, so
Éric Araujo mer...@netwok.org added the comment:
Pepeightification is ok for things like whitespace that do not break
compatibility (don’t waste time doing it manually though, we have automated
tools that can be used to reindent the whole of Distutils2). However, renaming
classes and
folks like myself may look at the source code for
the script
- said curious folks may either be new to Python or new to
programming in general
- I don't want newcomers getting the wrong idea about Python
coding standards
I should also mention that I have the same concern
Brett Cannon [EMAIL PROTECTED] added the comment:
2.7 through r66819, 2.6 through r66820, and 3.0 through r66821.
--
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
___
Ralph Corderoy [EMAIL PROTECTED] added the comment:
The patchcheck target isn't in .PHONY at the end of the file.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
___
Changes by Brett Cannon [EMAIL PROTECTED]:
--
status: closed - open
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
___
___
Python-bugs-list mailing
Brett Cannon [EMAIL PROTECTED] added the comment:
The attached patch renames the target to patchcheck.
--
keywords: +needs review, patch
Added file: http://bugs.python.org/file11394/rename_check.diff
___
Python tracker [EMAIL PROTECTED]
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Patch looks fine to me.
--
keywords: -needs review
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
___
Brett Cannon [EMAIL PROTECTED] added the comment:
On the trunk with r66237 and 3.0 with r66238.
--
resolution: - accepted
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
Brett Cannon [EMAIL PROTECTED] added the comment:
OK, I am going to go with ``make patchcheck`` since that is the script's
name and the command does nothing but execute the script.
I will wait until after rc1 to deal with this.
___
Python tracker [EMAIL
Brett Cannon [EMAIL PROTECTED] added the comment:
Or how about ``make precommit``?
--
priority: - low
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
___
Benjamin Peterson [EMAIL PROTECTED] added the comment:
That suggests that it only need to run by committers. I find it useful,
just for the reindenting whenever I'm writing a patch.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
=markup
Unfortunately, GNU coding standards have cemented in many people's minds
that check is the target for self-tests, e.g. make clean all check
install. http://www.gnu.org/prep/standards/standards.html#Standard-Targets
I realise Python doesn't fall under those coding standards, but none
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Brett, how about patchcheck?
--
assignee: - brett.cannon
nosy: +benjamin.peterson, brett.cannon
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3758
Brett Cannon [EMAIL PROTECTED] added the comment:
On Tue, Sep 2, 2008 at 7:17 AM, Benjamin Peterson
[EMAIL PROTECTED] wrote:
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Brett, how about patchcheck?
Maybe. I will see if any inspiration comes to me in the near future.
Obviously
'Good code' is code that works, is bug free, and is readable and
maintainable. Standards need to be followed for coding. Read more...
http://brsx.co.uk/SWtesting/FAQs/FAQs012.asp
--
http://mail.python.org/mailman/listinfo/python-list
[EMAIL PROTECTED] a écrit :
'Good code' is code that works, is bug free, and is readable and
maintainable. Standards need to be followed for coding. Read more...
http://brsx.co.uk/SWtesting/FAQs/FAQs012.asp
You misstyped your URL and referenced a C++ related document, for Python
its here:
Python makes coding standards obsolete;)
But Python has the advantage, that your coding standards can concentrate on
the important things and skip most of the formatting rules, that are often
part of other languages coding standards.
Better to say, almost obsolete, i guess :D
--
Soni
organisations have coding standards...
and a majority does not control them ;o) What is the situation at your
location? Does this lack of control really hurt?
--
http://mail.python.org/mailman/listinfo/python-list
editormt wrote:
A majority of the participating organisations have coding standards...
and a majority does not control them ;o) What is the situation at your
location? Does this lack of control really hurt?
A Foolish Consistency is the Hobgoblin of Little Minds
from: http://www.python.org/dev
Soni Bergraj wrote:
editormt wrote:
A majority of the participating organisations have coding standards...
and a majority does not control them ;o) What is the situation at your
location? Does this lack of control really hurt?
A Foolish Consistency is the Hobgoblin of Little Minds
from
Does anyone have any knowledge of where to find details of docs like
Requirements for Software Coding Standards, etc applicable for work within
the US govt (preferably non-military).
Thanks in advance
Dr Tim Couper UK
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus
would like to do,
since we are all new to the language, is to define a set of guidelines and
best practices as our coding standards.
Does anyone know where I can get some information about what the community
is doing? Are there any well defined guidelines established?
http
of guidelines and
best practices as our coding standards.
Does anyone know where I can get some information about what the community
is doing? Are there any well defined guidelines established?
Thanks,
--
Isaac Rodriguez
SWE Autodesk.
There are 10 types
to the language, is to define a set of guidelines and
best practices as our coding standards.
Does anyone know where I can get some information about what the community
is doing? Are there any well defined guidelines established?
http://www.python.org/peps/pep-0008.html
Cheers,
Trent
--
Trent Mick
to do,
since we are all new to the language, is to define a set of guidelines and
best practices as our coding standards.
Does anyone know where I can get some information about what the community
is doing? Are there any well defined guidelines established?
One such document:
http://python.org
Isaac Rodriguez [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Does anyone know where I can get some information about what
the community is doing? Are there any well defined guidelines
established?
Besides PEP8, there is also the library code itself. When reading that
though,
49 matches
Mail list logo
