Re: your feedback to my first project please

2012-01-11 Thread D'Arcy Cain
On 12-01-08 02:46 PM, patr...@bierans.de wrote: Thanks for the feedback! You're welcome. D'Arcy wrote: [code examples] But I will keep some of my underscores for "private" attributes and methods. And I googled: "dim" was basic. I know too many languages and start mixing the keywords - shame

Re: your feedback to my first project please

2012-01-10 Thread Terry Reedy
On 1/10/2012 9:06 AM, Jean-Michel Pichavant wrote: - I quite dislike your avg method which does more than averaging, it also inserts a value and removes another modifying the object in place. It could be very confusing for someone reading your code. Fortunately, you have documented it, that make

Re: your feedback to my first project please

2012-01-10 Thread patr...@bierans.de
> Jean-Michel wrote: Module names should be lowercase You're right. I was too lazy and just copied the class name. I will keep that in mind for the future. ;) > Jean-Michel wrote: I quite dislike your avg method which does more than > averaging, it also inserts a value and removes another modifyi

Re: your feedback to my first project please

2012-01-10 Thread Jean-Michel Pichavant
patr...@bierans.de wrote: Thanks for the feedback! I took the time reading and understanding it and to let it getting into my bones. And I also lost time on reading more of this freaky and interesting documentation and was testing a lot of different stuff with my enviroment. My current code can

Re: your feedback to my first project please

2012-01-08 Thread patr...@bierans.de
Thanks for the feedback! I took the time reading and understanding it and to let it getting into my bones. And I also lost time on reading more of this freaky and interesting documentation and was testing a lot of different stuff with my enviroment. My current code can be seen here if you are int

Re: your feedback to my first project please

2012-01-07 Thread Peter Otten
patr...@bierans.de wrote: > I know the TestCases are ugly, I still have no feeling for it. I forgot to mention: instead of testing each and every thing in one big method put each test into a short dedicated TestCase.test_... method. That reduces the risk of undetected side effects and often all

Re: your feedback to my first project please

2012-01-07 Thread D'Arcy Cain
On 12-01-07 07:10 AM, patr...@bierans.de wrote: It's my first script in python and I'd like to know if my way of coding so far is right and if YOU have some little tips for me or if you can point my nose on some things I've missed so far. Looks pretty good overall. I have a little armchair qua

Re: your feedback to my first project please

2012-01-07 Thread Peter Otten
patr...@bierans.de wrote: >It's my first script in python and I'd like to know if my way >of coding A warm welcome and a grumpy "please post in plain-text" ;) >I am settled - so you can go full on. ;) You seem to be sure you won't regret that ;) >- What about my coding style i

Re: My first project

2010-04-18 Thread Kushal Kumaran
On Sat, Apr 17, 2010 at 11:46 PM, Someone Something wrote: > no one cares? :( > > On Sat, Apr 17, 2010 at 8:41 AM, Someone Something > wrote: >> >> This is my first large-scale (sort of) project in python. It is still >> under daily development, but the core is pretty stable (although, I'm still

Re: My first project

2010-04-17 Thread Someone Something
no one cares? :( On Sat, Apr 17, 2010 at 8:41 AM, Someone Something wrote: > This is my first large-scale (sort of) project in python. It is still under > daily development, but the core is pretty stable (although, I'm still adding > features). Here's the code: http://github.com/Poincare/PyEventL

My first project

2010-04-17 Thread Someone Something
This is my first large-scale (sort of) project in python. It is still under daily development, but the core is pretty stable (although, I'm still adding features). Here's the code: http://github.com/Poincare/PyEventLoop or http://code.google.com/p/pyeventloop/ Tell me what you guys think of it (I'l