Re: Splitting up large python module impact on performance?

2018-06-13 Thread Rick Johnson
On Wednesday, June 13, 2018 at 4:27:35 AM UTC-5, Chris Angelico wrote: > It's more his definition of "large" and "small" that I was > disagreeing with. You're absolutely right that a dense > global scope is a problem; but a "one class per file" rule > is a terrible idea. What if the "one class"

Re: Splitting up large python module impact on performance?

2018-06-13 Thread Steven D'Aprano
On Wed, 13 Jun 2018 14:08:35 +1000, Cameron Simpson wrote: > I was going to say something along these lines, but to some extent this > feels like an unfair finger pointing exercise. Huge files can be a PITA; > having something that aids moving around them reduces the pain, but > doesn't remove

Re: Splitting up large python module impact on performance?

2018-06-13 Thread Chris Angelico
On Wed, Jun 13, 2018 at 5:56 PM, Ed Kellett wrote: > On 2018-06-13 05:24, Chris Angelico wrote: >> Oh wait, your code isn't anything remotely sane. But for the rest of >> us, large files aren't a problem. > > I don't like large files--I think mostly because files are an > organisational tool,

Re: Splitting up large python module impact on performance?

2018-06-13 Thread Ed Kellett
On 2018-06-13 05:24, Chris Angelico wrote: > Oh wait, your code isn't anything remotely sane. But for the rest of > us, large files aren't a problem. I don't like large files--I think mostly because files are an organisational tool, they're quite good at that job, and one might as well use them.

Re: Splitting up large python module impact on performance?

2018-06-13 Thread Cameron Simpson
On 13Jun2018 17:53, Greg Ewing wrote: Chris Angelico wrote: A few thousand lines in a file is only a problem if you're using an editor that lacks a Find feature. My editor has a find feature, but I still find it a nuisance to have to use it every single time I want to find something. Tags

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Gregory Ewing
Chris Angelico wrote: A few thousand lines in a file is only a problem if you're using an editor that lacks a Find feature. My editor has a find feature, but I still find it a nuisance to have to use it every single time I want to find something. -- Greg --

Re: Splitting up large python module impact on performance?

2018-06-12 Thread dieter
Bill Deegan writes: > I'm doing some refactoring on a fairly large python codebase. > Some of the files are > 4000 lines long and contain many classes. I am typically working with systems consisting of hundreds of modules (Zope/Plone). Such large systems have a significant impact on startup time

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Chris Angelico
On Wed, Jun 13, 2018 at 2:15 PM, Rick Johnson wrote: > On Tuesday, June 12, 2018 at 10:35:47 PM UTC-5, Chris Angelico wrote: > [...] >> A few thousand lines in a file is only a problem if you're >> using an editor that lacks a Find feature. Or if you use >> bad function/class names that you can't

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Rick Johnson
On Tuesday, June 12, 2018 at 10:35:47 PM UTC-5, Chris Angelico wrote: [...] > A few thousand lines in a file is only a problem if you're > using an editor that lacks a Find feature. Or if you use > bad function/class names that you can't search for. I'm unaware of any text editor that doesn't

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Cameron Simpson
On 13Jun2018 13:35, Chris Angelico wrote: On Wed, Jun 13, 2018 at 1:23 PM, Rick Johnson wrote: Bill Deegan wrote: I'm doing some refactoring on a fairly large python codebase. Some of the files are > 4000 lines long and contain many classes. I would argue that files of such size are a

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Chris Angelico
On Wed, Jun 13, 2018 at 1:23 PM, Rick Johnson wrote: > Bill Deegan wrote: >> I'm doing some refactoring on a fairly large python >> codebase. Some of the files are > 4000 lines long and >> contain many classes. > > I would argue that files of such size are a total pain to > navigate and thus,

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Rick Johnson
Bill Deegan wrote: > I'm doing some refactoring on a fairly large python > codebase. Some of the files are > 4000 lines long and > contain many classes. I would argue that files of such size are a total pain to navigate and thus, edit. I prefer to place only one -- or only a handful of classes --

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Steven D'Aprano
On Tue, 12 Jun 2018 15:00:44 -0700, Bill Deegan wrote: > Greetings, > > I'm doing some refactoring on a fairly large python codebase. Some of > the files are > 4000 lines long and contain many classes. > > Should I expect any performance hit from splitting some of the classes > out to other

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Gregory Ewing
Bill Deegan wrote: Should I expect any performance hit from splitting some of the classes out to other files? I doubt it. Time taken to load modules is mostly dependent on the total amount of code, not how many files it lives in. If you had a *very* large number of tiny files, it might be a

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Chris Angelico
On Wed, Jun 13, 2018 at 10:32 AM, Cameron Simpson wrote: > I think I'm saying: don't worry unless your applications are very time > critical (eg invoked very frequently and/or doing almost nothing after the > "import" phase) or you notice a significant slowdown after your changes. And > it is

Re: Splitting up large python module impact on performance?

2018-06-12 Thread Cameron Simpson
On 12Jun2018 15:00, Bill Deegan wrote: I'm doing some refactoring on a fairly large python codebase. Some of the files are > 4000 lines long and contain many classes. Should I expect any performance hit from splitting some of the classes out to other files? In general, nothing significant.

Splitting up large python module impact on performance?

2018-06-12 Thread Bill Deegan
Greetings, I'm doing some refactoring on a fairly large python codebase. Some of the files are > 4000 lines long and contain many classes. Should I expect any performance hit from splitting some of the classes out to other files? Thanks, Bill --