[issue30420] [doc] subprocess module: Clarify kwarg handing for convenience APIs

Change by Alex Waygood : -- title: Clarify kwarg handing for subprocess convenience APIs -> [doc] subprocess module: Clarify kwarg handing for convenience APIs ___ Python tracker <https://bugs.python.org/issu

[issue7438] Allow to use a part of subprocess module during building Python

Irit Katriel added the comment: Closed after 12 years of inactivity. The code has moved on quite a bit since then. -- nosy: +iritkatriel resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41151] Support for new Windows pseudoterminals in the subprocess module

Change by Chad Smith : -- nosy: +cs01 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41151] Support for new Windows pseudoterminals in the subprocess module

Eryk Sun added the comment: > However, the API is a bit weird. Unlike Unix, when you create a > Windows pty, there's no way to directly get access to the "slave" > handle. Instead, you first call CreatePseudoConsole to get a > special "HPCON" object, which is similar to a Unix pty master.

[issue41151] Support for new Windows pseudoterminals in the subprocess module

Change by Gregory P. Smith : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41151] Support for new Windows pseudoterminals in the subprocess module

cally, what you have to do is set a special entry in the "lpAttributeList", with type "PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE". Details: https://docs.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session Unfortunately, the subprocess module does not provide any w

Re: Where is getstatusoutput() in subprocess module?

to the subprocess module. Where are they? Here: https://docs.python.org/3/library/subprocess.html#subprocess.getstatusoutput -- https://mail.python.org/mailman/listinfo/python-list

Re: Where is getstatusoutput() in subprocess module?

() have been moved to the subprocess > module. > > Where are they? Doh, never mind. They were only moved in Python3. I didn't realize that the "In Python 3.x" qualifier from the beginning of the previous sentence applied to the entire paragraph. -- Grant Edwards

Where is getstatusoutput() in subprocess module?

I'm trying to update a python2 app to make it python3 compatible. It uses commands.getstatusoutput(), which according to https://docs.python.org/2/library/commands.html#commands.getstatusoutput ... getstatusoutput() and getoutput() have been moved to the subprocess module. Where

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: Aye, we can :) -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35486] subprocess module import hooks breaks back compatibility

Ned Deily added the comment: I've merged the doc changes for 3.6, thanks. Can we close this now? -- ___ Python tracker ___ ___

[issue35486] subprocess module import hooks breaks back compatibility

Ned Deily added the comment: New changeset 1edb3dc6ff70db88a7e89586578e58a86ee0e75e by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-35486: Note Py3.6 import system API requirement change (GH-11540) (GH-11588)

[issue35486] subprocess module import hooks breaks back compatibility

miss-islington added the comment: New changeset 422db3777874f4f31fc8f4e718f440a2abc59347 by Miss Islington (bot) in branch '3.7': bpo-35486: Note Py3.6 import system API requirement change (GH-11540) https://github.com/python/cpython/commit/422db3777874f4f31fc8f4e718f440a2abc59347

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11279, 11280, 11281, 11282, 11283 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11278, 11279, 11280 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11279, 11280, 11281, 11283 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11279, 11280, 11283 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35486] subprocess module import hooks breaks back compatibility

miss-islington added the comment: New changeset cee29b46a19116261b083dc803217aa754c7df40 by Miss Islington (bot) (Nick Coghlan) in branch 'master': bpo-35486: Note Py3.6 import system API requirement change (GH-11540)

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11278, 11279 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35486] subprocess module import hooks breaks back compatibility

Change by miss-islington : -- pull_requests: +11278 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: dw: we routinely impose new requirements on folks modifying runtime internals in new feature releases, so the only aspect we missed for this changing is to explicitly call it out in the Porting section of the Python 3.6 What's New document as a potential

[issue35486] subprocess module import hooks breaks back compatibility

Change by Nick Coghlan : -- keywords: +patch, patch pull_requests: +11147, 11148 stage: test needed -> patch review ___ Python tracker ___

[issue35486] subprocess module import hooks breaks back compatibility

Change by Nick Coghlan : -- keywords: +patch, patch, patch pull_requests: +11147, 11148, 11149 stage: test needed -> patch review ___ Python tracker ___

[issue35486] subprocess module import hooks breaks back compatibility

Change by Nick Coghlan : -- keywords: +patch pull_requests: +11147 stage: test needed -> patch review ___ Python tracker ___ ___

[issue35486] subprocess module import hooks breaks back compatibility

David Wilson added the comment: Hi Nick, The purpose of ModuleNotFoundError is clear and unrelated to the problem documented here. The problem is that due to the introduction of ModuleNotFoundError, ImportError's semantics have been changed within a minor release in a breaking,

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: Note that the above distinction is also the rationale for introducing the new subtype: so that it's easy to tell the difference between "that module was not found at all" (ModuleNotFoundError) and "the module was found, but attempting to actually load it

[issue35486] subprocess module import hooks breaks back compatibility

Nick Coghlan added the comment: The two errors mean different things: ModuleNotFoundError means literally that the module could not be found at all (i.e. no import hook offered to try to load it) A plain ImportError then means that the module was located, but attempting to actually load it

[issue35486] subprocess module import hooks breaks back compatibility

Brett Cannon added the comment: RE: "PEP-302 and PEP-451 are the definitive specifications for how sys.meta_path is supposed to work" That's actually not true. In the case of import the language reference is considered the reference for import:

[issue35486] subprocess module import hooks breaks back compatibility

Change by Terry J. Reedy : -- nosy: +brett.cannon, eric.snow, ncoghlan stage: -> test needed title: subprocess module breaks backwards compatibility with import hooks -> subprocess module import hooks breaks back compatibility type: ->

[issue35486] subprocess module breaks backwards compatibility with import hooks

David Wilson added the comment: Having considered this for a few hours, it seems the following is clear: - 3.6 introduces ModuleImportError - 3.7 begins using it within importlib - 3.8 first instance of stdlib code catching it - PEP-302 and PEP-451 are the definitive specifications for how

[issue35486] subprocess module breaks backwards compatibility with import hooks

Change by David Wilson : -- title: subprocess module breaks backwards compatibility with older import hooks -> subprocess module breaks backwards compatibility with import hooks ___ Python tracker <https://bugs.python.org/issu

[issue35486] subprocess module breaks backwards compatibility with older import hooks

David Wilson added the comment: Corrected GitHub link for the commit: https://github.com/python/cpython/commit/880d42a3b24 -- ___ Python tracker ___

[issue35486] subprocess module breaks backwards compatibility with older import hooks

unclear to me what need the new subtype is addressing, whether this is a problem with the subprocess module or the subtype as a whole, or indeed whether any of this should be considered a bug. It seems clear that some kind of regression is in the process of occurring during a minor release

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

On Mon, Nov 12, 2018 at 11:20 PM Anssi Saari wrote: > > Chris Angelico writes: > > > On Fri, Nov 9, 2018 at 11:11 PM Anssi Saari wrote: > >> > >> Chris Angelico writes: > >> > >> > No helper needed. Safe against command injection. Uses the known > >> > format of the command's output; if you

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

Chris Angelico writes: > On Fri, Nov 9, 2018 at 11:11 PM Anssi Saari wrote: >> >> Chris Angelico writes: >> >> > No helper needed. Safe against command injection. Uses the known >> > format of the command's output; if you want other information as well >> > as the type, you could get that too.

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

srinivasan wrote: > Even after changing as per the below > "blkid -o export %s | grep 'TYPE' | cut -d'=' -f3" > or: > 'blkid -o export %s | grep "TYPE" | cut -d"=" -f3' > or: > "blkid -o export %s | grep \"TYPE\" | cut -d\"=\" -f3" > > Still my output is: > */dev/mmcblk1p1: LABEL="efi"

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

On Fri, Nov 9, 2018 at 11:11 PM Anssi Saari wrote: > > Chris Angelico writes: > > > No helper needed. Safe against command injection. Uses the known > > format of the command's output; if you want other information as well > > as the type, you could get that too. > > Can someone let me in on

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

Chris Angelico writes: > No helper needed. Safe against command injection. Uses the known > format of the command's output; if you want other information as well > as the type, you could get that too. Can someone let me in on this secret helper module? Doesn't seem to match the helper module in

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

Many Thanks a lot , I can use for reliably "lsblk %s -n -o FSTYPE" in the reused code of mine as below cmd = "lsblk %s -n -o FSTYPE" % partition_path return self._helper.execute_cmd_output_string(cmd) I really appreciate for all your support w.r.t this.. I feel I have kick

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

srinivasan writes: > Even after changing as per the below > "blkid -o export %s | grep 'TYPE' | cut -d'=' -f3" > or: > 'blkid -o export %s | grep "TYPE" | cut -d"=" -f3' > or: > "blkid -o export %s | grep \"TYPE\" | cut -d\"=\" -f3" > > Still my output is: > */dev/mmcblk1p1: LABEL="efi"

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

On Wed, Nov 7, 2018 at 11:42 PM srinivasan wrote: > > Some I managed to fix temporarily as below, might be useful for others. Also > please correct me if anything wrong or for any improvements in the below > > cmd = "blkid -o export %s" % partition_path > out =

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

Some I managed to fix temporarily as below, might be useful for others. Also please correct me if anything wrong or for any improvements in the below cmd = "blkid -o export %s" % partition_path out = self._helper.execute_cmd_output_string(cmd) var = out.split("TYPE=",

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

On Wed, Nov 7, 2018 at 11:36 PM Qian Cai wrote: > > srinivasan wrote: > > Even after changing as per the below > > "blkid -o export %s | grep 'TYPE' | cut -d'=' -f3" > > or: > > 'blkid -o export %s | grep "TYPE" | cut -d"=" -f3' > > or: > > "blkid -o export %s | grep \"TYPE\" | cut -d\"=\" -f3"

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

srinivasan wrote: > Even after changing as per the below > "blkid -o export %s | grep 'TYPE' | cut -d'=' -f3" > or: > 'blkid -o export %s | grep "TYPE" | cut -d"=" -f3' > or: > "blkid -o export %s | grep \"TYPE\" | cut -d\"=\" -f3" > > Still my output is: > */dev/mmcblk1p1: LABEL="efi"

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

Even after changing as per the below "blkid -o export %s | grep 'TYPE' | cut -d'=' -f3" or: 'blkid -o export %s | grep "TYPE" | cut -d"=" -f3' or: "blkid -o export %s | grep \"TYPE\" | cut -d\"=\" -f3" Still my output is: */dev/mmcblk1p1: LABEL="efi" UUID="1084-AA42" TYPE="vfat"* My expected

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

On Wed, 2018-11-07 at 10:22 +0100, srinivasan wrote: > blkid -o export %s | grep \'TYPE\' | cut -d\"=\" -f3 You don't need to escape the single quotes. Try either: "blkid -o export %s | grep 'TYPE' | cut -d'=' -f3" or: 'blkid -o export %s | grep "TYPE" | cut -d"=" -f3' or: "blkid -o export %s |

Re: [Tutor] SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

quot; > > Other issues may also be there. > -Original Message- > From: Tutor On Behalf Of > Alan Gauld via Tutor > Sent: Tuesday, November 6, 2018 7:37 PM > To: tu...@python.org > Cc: python-...@python.org > Subject: Re: [Tutor] SyntaxError: can't assign to literal wh

Re: SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

On 06/11/2018 18:10, srinivasan wrote: root:~/qa/test_library# python3 sd.py File "sd.py", line 99 *cmd = "blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)* * ^* *SyntaxError: can't assign to literal* Look at the 'cut' element of the pipeline. You have used double

SyntaxError: can't assign to literal while using ""blkid -o export %s | grep 'TYPE' | cut -d"=" -f3" % (fs)" using subprocess module in Python

Dear Python Experts Team, As am newbie to python development, I am trying to use the below function to get verify the filesystem type of the SD card parition using bash command in python using subprocess module, I ma seeing the below Error "SyntaxError: can't assign to literal&qu

[issue31296] support pty.fork and os.forkpty actions in posix subprocess module

(Lib) messages: 300968 nosy: gregory.p.smith priority: normal severity: normal status: open title: support pty.fork and os.forkpty actions in posix subprocess module versions: Python 3.7 ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

STINNER Victor added the comment: New changeset 2097b9e0ef32ab7a0d745edc0f707c615780c006 by Victor Stinner in branch '2.7': [2.7] bpo-30764: test_subprocess uses SuppressCrashReport (#2405) (#2412) https://github.com/python/cpython/commit/2097b9e0ef32ab7a0d745edc0f707c615780c006 --

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

STINNER Victor added the comment: New changeset 9ad50d94599aed0c37beaf78948ec271c8aa3881 by Victor Stinner in branch '3.6': bpo-30764: test_subprocess uses SuppressCrashReport (#2405) (#2410) https://github.com/python/cpython/commit/9ad50d94599aed0c37beaf78948ec271c8aa3881 --

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

STINNER Victor added the comment: New changeset 849b062a82ca2f09e33259d34067faba196c9e23 by Victor Stinner in branch '3.5': bpo-30764: test_subprocess uses SuppressCrashReport (#2405) (#2411) https://github.com/python/cpython/commit/849b062a82ca2f09e33259d34067faba196c9e23 --

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by STINNER Victor : -- pull_requests: +2461 ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by STINNER Victor : -- pull_requests: +2459 ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

STINNER Victor added the comment: New changeset cdee3f14f7f4c995e7eedb0bf6a67e260c739f7d by Victor Stinner in branch 'master': bpo-30764: test_subprocess uses SuppressCrashReport (#2405) https://github.com/python/cpython/commit/cdee3f14f7f4c995e7eedb0bf6a67e260c739f7d --

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by STINNER Victor : -- pull_requests: +2453 ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: Fixed applied to subprocess32 in https://github.com/google/python-subprocess32/commit/0f1958e982bf44db569470def7281bcafa2a8b0e -- stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: New changeset 56bc3b768c3cc3817031b56d5e7a279aa1296bc9 by Gregory P. Smith in branch 'master': bpo-29335 - apply suggested test_subprocess simplifications from haypo and Zach: (#1757)

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith : -- pull_requests: +1843 ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Serhiy Storchaka : -- pull_requests: -916 ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Donald Stufft : -- pull_requests: +916 ___ Python tracker ___ ___

[issue7438] Allow to use a part of subprocess module during building Python

Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Zach Riggle added the comment: Neat, though that's not in the standard library. The current logic for getting a handle to libc could also be simplified via ctypes.util.find_library (https://docs.python.org/3/library/ctypes.html#finding-shared-libraries). Darwin: >>> import ctypes.util

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

STINNER Victor added the comment: If you want crashes, look at the portable faulthandler._sigsegv() :-) -- ___ Python tracker ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Zach Riggle added the comment: Of note, there's no need to actually cause a SIGSEGV to generate the signal. The tests might be more clear to replace: libc.printf(ctypes.c_char_p(0xdeadbeef)) with os.kill(os.getpid(), signal.SIGSEGV) --

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: thanks Ned, I was awaiting interesting buildbot results. :) fixed in 2.7 and 3.5 onwards. thanks for the report Zach. not closing until I also apply the fix to the subprocess32 backport. -- resolution: -> fixed stage: patch review -> commit review

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Roundup Robot added the comment: New changeset 8e3d412f8e89 by Gregory P. Smith in branch '2.7': Issue #29335: Fix subprocess.Popen.wait() when the child process has https://hg.python.org/cpython/rev/8e3d412f8e89 -- ___ Python tracker

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Ned Deily added the comment: Among other buildbot failures: http://buildbot.python.org/all/builders/x86%20Tiger%203.6/builds/142/steps/test/logs/stdio == ERROR: test_child_terminated_in_stopped_state

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Roundup Robot added the comment: New changeset 269296b2a047 by Gregory P. Smith in branch '3.5': Issue #29335: Fix subprocess.Popen.wait() when the child process has https://hg.python.org/cpython/rev/269296b2a047 New changeset ed5255a61648 by Gregory P. Smith in branch '3.6': Issue #29335: Fix

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: test added. -- stage: test needed -> patch review type: -> behavior Added file: http://bugs.python.org/file46386/issue29335-gps02.diff ___ Python tracker

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: The attached patch should fix it. I want to incorporate a bug.py like regression test into test_subprocess.py. -- keywords: +patch stage: -> test needed Added file: http://bugs.python.org/file46385/issue29335-gps01.diff

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith <g...@krypto.org>: -- title: Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD -> subprocess module does not check WIFSTOPPED on SIGCHLD ___ Python tracker <rep...@bugs.python.org> <http

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

Zach Riggle added the comment: To further clarify the report: When the attached proof-of-concept is executed, a RuntimeException is raised, which has a comment "Should never happen". The issue isn't due to SIGCHLD, but rather following a waitpid() call. The code attempts to suss the exit

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Ned Deily : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

New submission from Zach Riggle: The attached script hits some "This should never happen" code in the subprocess module. These lines here: https://github.com/python/cpython/blob/2.7/Lib/subprocess.py#L1036-L1038 The root cause is a lack of checking WIFSTOPPED and WSTOPSIG in t

[issue26240] Docstring of the subprocess module should be cleaned up

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26240] Docstring of the subprocess module should be cleaned up

Roundup Robot added the comment: New changeset 720865fa61a4 by Martin Panter in branch '3.5': Issue #26240: Clean up the subprocess module doc string https://hg.python.org/cpython/rev/720865fa61a4 New changeset 8358c68579e9 by Martin Panter in branch '3.6': Issue #26240: Merge subprocess doc

[issue26240] Docstring of the subprocess module should be cleaned up

Changes by Martin Panter : Added file: http://bugs.python.org/file45180/subprocess3-2.7.patch ___ Python tracker ___

[issue26240] Docstring of the subprocess module should be cleaned up

Martin Panter added the comment: Here are corresponding patches for 3.5 and 2.7. -- stage: patch review -> commit review Added file: http://bugs.python.org/file45179/subprocess3-3.5.patch ___ Python tracker

[issue26240] Docstring of the subprocess module should be cleaned up

Martin Panter added the comment: V3 looks good to me -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26240] Docstring of the subprocess module should be cleaned up

Tim Mitchell added the comment: Changes as per Martins review. -- Added file: http://bugs.python.org/file45159/subprocess3.patch ___ Python tracker ___

[issue26240] Docstring of the subprocess module should be cleaned up

Martin Panter added the comment: . I left some comments on the code review. Also, I’m not sure about the links to the online documentation. We don’t do this for other modules as far as I know. The pydoc module and help() commands already add their own links, which can be configured via

[issue26240] Docstring of the subprocess module should be cleaned up

Tim Mitchell added the comment: Am now working from tip of default in mercurial (Python 3.6). * Removed all changes to subprocess.rst. subprocess.__doc__ * Trimmed down even further - removed function signatures. * added note to see Python docs for complete description. Exception docs * just

[issue26240] Docstring of the subprocess module should be cleaned up

Martin Panter added the comment: Thanks for tackling this one Tim. I agree with Berker that the :const:`True` changes are out of scope (some introduce errors and inaccuracies). class CalledProcessError(SubprocessError): -"""Raised when a check_call() or check_output() process returns

[issue26240] Docstring of the subprocess module should be cleaned up

Tim Mitchell added the comment: hg patch with changes forthcoming -- ___ Python tracker ___ ___

[issue26240] Docstring of the subprocess module should be cleaned up

Changes by Antony Lee : -- nosy: -Antony.Lee ___ Python tracker ___ ___

[issue26240] Docstring of the subprocess module should be cleaned up

Berker Peksag added the comment: Thanks for the patch, Tim. > Changed true -> :const:`True` in subprocess.rst. This is out of scope for this issue and I actually prefer the current form. Having method and class signatures in subprocess.__doc__ would make it less maintainable. I'd prefer

[issue26240] Docstring of the subprocess module should be cleaned up

Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.7 ___ Python tracker

[issue26240] Docstring of the subprocess module should be cleaned up

Tim Mitchell added the comment: Have stripped down the module __doc__ to a list of contents. I chose to indent the descriptions of each argument to Popen. I know this is non-standard but it is such a long ramble otherwise. Changed true -> :const:`True` in subprocess.rst. -- keywords:

[issue26240] Docstring of the subprocess module should be cleaned up

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___

[issue28165] The 'subprocess' module leaks memory when called in certain ways

Changes by Xavion : Added file: http://bugs.python.org/file44763/Test-3a-gc.log ___ Python tracker ___

[issue28165] The 'subprocess' module leaks memory when called in certain ways

Changes by Xavion : Added file: http://bugs.python.org/file44762/Test-3a-no-gc.log ___ Python tracker ___

[issue28165] The 'subprocess' module leaks memory when called in certain ways

all of the collateral stuff from your "Test-3.py" script and reattached it here as "Test-3a.py". -- resolution: not a bug -> status: closed -> open title: The 'subprocess' module leaks 4 kiB memory for each thread -> The 'subprocess' module leaks memory when

[issue28165] The 'subprocess' module leaks 4 kiB memory for each thread

STINNER Victor added the comment: Test-2.py has issues: * it doesn't call Timer.join() * it uses a weak synchronization between the main thread and the Timer thread: see msg276990 for an example using Event If you use a better synchronization code, call timer.join() and call gc.collect(),

[issue28165] The 'subprocess' module leaks 4 kiB memory for each thread

Xavion added the comment: haypo: So, what is the result when you run "Test-2.py" and monitor the memory usage with "Test.sh"? ztane: The code you've provided is the same as "Test-1.py". You need to run "Test-2.py" in order to see the bug! -- ___

[issue28165] The 'subprocess' module leaks 4 kiB memory for each thread

ccordingly -- title: The 'subprocess' module leaks memory when called in certain ways -> The 'subprocess' module leaks 4 kiB memory for each thread ___ Python tracker <rep...@bugs.python.org> <http://bugs

  1   2   3   4   5   6   >