[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-04-07 Thread Victor Kung
Victor Kung added the comment: I see. @Christian Heimes Thank you for the response. -- ___ Python tracker ___ ___

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-04-03 Thread Christian Heimes
Christian Heimes added the comment: The suggested approach is merely a heuristic that reduces the impact of a zipbomb. An attacker can circumvent the heuristic. In best case scenario, the approach just increases the cost factor for a successful DoS. For example an attacker may have to

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-04-03 Thread Victor Kung
Victor Kung added the comment: Hello Python community, I’m curious why the patch or pitfall prevention in ZipFile are not suggested. I have no idea if everyone read documentation in detail. It seems straightforward to add the methods in ZipFile with well documented rather than just warn

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-04-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I am against such trivial methods in ZipFile. Its interface is already complicate. The advantage of Python is that you do not need tons of methods for every possible query -- you can just combine few Python features into a one-line expression. As for the

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-04-02 Thread JUN-WEI SONG
decompression, but once it is decompressed, it will exhaust system resources. You can protect your system by limiting system resources, limiting compression ratio (zip bombs are usually quite high), and checking for nested zip files. We are also pleasure to provide a patch to enhance

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-28 Thread KunYu Chen
KunYu Chen added the comment: Thank you for the responses. I agree with Christian Heimes. It's indeed better to improve the documentation rather than directly implement the heuristic. -- ___ Python tracker

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-28 Thread JUN-WEI SONG
JUN-WEI SONG added the comment: Thank you python community, these two issues are indeed the same problem. I also think that it is good to make a related document to reduce such problems. -- stage: -> resolved status: -> closed ___ Python tracker

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: All these are simple one-liners: len(zf.infolist()) sum(zi.compress_size for zi in zf.infolist()) sum(zi.file_size for zi in zf.infolist()) -- nosy: +serhiy.storchaka ___ Python tracker

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-28 Thread Christian Heimes
Christian Heimes added the comment: Issue #36462 contains more information. The reporter claims that the zipfile module is inherent insecure because it does not provide any heuristics to make zipbomb attacks harder. I'm -1 to implement such a heuristic. The zipfile module is a low level

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

2019-03-27 Thread Cheryl Sabella
Cheryl Sabella added the comment: Is there interest in having this patch converted to a pull request? -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 3.6 ___ Python tracker <https://bugs.python.org/issue16

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-03-18 Thread Julien Palard
Julien Palard added the comment: New changeset 869652b426bb34a30ce7b39f0a0ac242ed5b1016 by Julien Palard in branch '2.7': [2.7] bpo-35605: Fix documentation build for sphinx<1.6 (GH-12413) https://github.com/python/cpython/commit/869652b426bb34a30ce7b39f0a0ac242ed5b1016 --

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-03-18 Thread Julien Palard
Change by Julien Palard : -- pull_requests: +12367 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9499] Python C/API Execution namespace undocumented. (patch included)

2019-03-15 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2889] curses for windows (alternative patch)

2019-03-15 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-12 Thread KunYu Chen
KunYu Chen added the comment: Thank you Karthikeyan Singaravelan. We're working on it :D Kunyu Chen -- ___ Python tracker ___ ___

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-11 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-11 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: You can find the process to report security vulnerabilities at https://www.python.org/news/security/ . Please email the details to secur...@python.org and who will analyze the report before public disclosure. -- nosy: +xtreak

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-11 Thread KunYu Chen
KunYu Chen added the comment: Dear community, I am one of the discoverer of this vulnerability, please tell us what to do next :D Kunyu Chen -- nosy: +18z ___ Python tracker

[issue36260] Cpython/Lib vulnerability found and request a patch submission

2019-03-11 Thread Nick Sung
New submission from Nick Sung : Dear Python Community, We’ve found a vulnerability in cpython Lib and already received a cve number (CVE-2019-9674) https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-9674 We also have a patch for this vulnerability, please tell us what to do next. Since

[issue16296] Patch to fix building on Win32/64 under VS 2010

2019-02-24 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6164] [AIX] Patch to correct the AIX C/C++ linker argument used for 'runtime_library_dirs'

2019-02-24 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21018] [patch] added missing documentation about escaping characters for configparser

2019-02-15 Thread Cheryl Sabella
Change by Cheryl Sabella : -- versions: -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-02-03 Thread Ned Deily
Ned Deily added the comment: I agree that this can go into 3.6. Thanks, everyone! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-02-03 Thread Ned Deily
Ned Deily added the comment: New changeset 9bacdce451618a5f0bf62cb1b6f966ebde0492c6 by Ned Deily (Anthony Sottile) in branch '3.6': [3.6] bpo-35605: Fix documentation build for sphinx<1.6 (GH-11368) https://github.com/python/cpython/commit/9bacdce451618a5f0bf62cb1b6f966ebde0492c6

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-18 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +11348, 11349, 11350 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-18 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +11348, 11349 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-18 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +11348 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-17 Thread Felipe
; @berker.peksag I have converted the patch at > https://bugs.python.org/file40470/issue23078.patch and pushed it to a > GitHub branch > https://github.com/python/cpython/compare/master...tirkarthi:bpo23078 . I > am willing to open a PR attributing to @fov in case you haven't had the >

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-17 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: @berker.peksag I have converted the patch at https://bugs.python.org/file40470/issue23078.patch and pushed it to a GitHub branch https://github.com/python/cpython/compare/master...tirkarthi:bpo23078 . I am willing to open a PR attributing to @fov

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2019-01-15 Thread John Parejko
John Parejko added the comment: Were you able to make any progress on this? Do you need any help? -- nosy: +parejkoj-3 ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-01-03 Thread Anthony Sottile
Anthony Sottile added the comment: I also had to update the patch for sphinx.util.status_iterator which was also introduced in sphinx 1.6 -- ___ Python tracker <https://bugs.python.org/issue35

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm going to close this as 3.7 and 3.8 are good now, but if someone wants to see the same thing done in 2.7 it should be possible for them make a PR. This is primarily just a configure.ac change. -- resolution: -> fixed stage: commit review ->

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset a144feeb7ec501aaf30072d50e70d54b200e5ef0 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) (GH-11376)

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- stage: patch review -> commit review ___ Python tracker <https://bugs.python.org/issue28503> ___ ___ Python-bugs-list mai

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: As this is internal only rather than a feature, i'll bring this into 3.7 as well. -- versions: +Python 3.7 ___ Python tracker ___

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +10718 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 387512c7ecde6446f2e29408af2e16b9fc043807 by Gregory P. Smith in branch 'master': bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) https://github.com/python/cpython/commit/387512c7ecde6446f2e29408af2e16b9fc043807

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +10718, 10719 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +10718, 10719, 10720 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10712, 10713, 10714 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10712, 10713 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +10712 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2018-12-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-30 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch, patch pull_requests: +10704, 10705, 10706 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-30 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +10704, 10705 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-30 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +10704 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35605> ___ _

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-29 Thread Julien Palard
Julien Palard added the comment: The patch (try/except) to make https://github.com/python/cpython/pull/11251/files work with what Doc/conf.py says about minimum sphinx version (1.2) is OK for me. No need to apply it on 3.7 which needs_sphinx 1.6.6 according to its Doc/conf.py

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Ned Deily
Ned Deily added the comment: Julien (@mdk) is the doc builds expert. -- assignee: docs@python -> mdk ___ Python tracker ___ ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
Anthony Sottile added the comment: I assume that means I should only target 3.6 -- does the patch look like the right approach? I can make a PR -- ___ Python tracker <https://bugs.python.org/issue35

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Steve Dower
Steve Dower added the comment: I think we're okay to increase the minimum version on the active branches. -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
Anthony Sottile added the comment: If I add a patch which is essentially: try: # sphinx>=1.6 from sphinx.util.logging import getLogger except ImportError: # sphinx<1.6 from logging import getLogger will that be fine? and should I open that against 3.7 to be backported o

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Ned Deily
Ned Deily added the comment: I would view this as a build regression in 3.6.8 so I would accept a fix for the 3.6 branch. -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Steve Dower
Steve Dower added the comment: We need Ned's approval to fix anything in 3.6 now. Typically we do consider build issues, and this one is fairly innocent (the affected code should only be used on Windows, but the import may trigger elsewhere). I'd be happy to take a patch to use logging when

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +mdk, steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
Anthony Sottile added the comment: oops, pressed the button too quickly, meant to mention that sphinx 1.6 was released 2017-05 -- ___ Python tracker ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
New submission from Anthony Sottile : Noticed this while packaging 3.6.8 for deadsnakes (ubuntu ppa) This patch: https://github.com/python/cpython/pull/11251 Requires a version of sphinx where `sphinx.util.logging.getLogger` is available. It appears that the first version which

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-12-09 Thread Andrew Tennikoff
Change by Andrew Tennikoff : -- nosy: +atenni ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-11-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the pings. I will work on this issue this weekend. Note that 3.4 and 3.5 are in security-fix-only mode now, so I removed them from the versions field. -- assignee: -> berker.peksag versions: -Python 3.4, Python 3.5

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-11-27 Thread John Parejko
John Parejko added the comment: Adding to the list of "I just ran into this". The patch submitted by fov seems straightforward enough: what can we do to help shepherd it along? -- nosy: +John Parejko2 ___ Python tracker <https://bu

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-11-26 Thread Tom Dalton
Tom Dalton added the comment: Here's a minimal example so my comment is not totally vacuous: ``` import unittest from unittest import mock class Foo: @classmethod def bar(cls, baz): pass class TestFoo(unittest.TestCase): def test_bar(self): with

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-11-26 Thread Tom Dalton
Tom Dalton added the comment: I've just come across this too, so would be great if the patch can be progressed. -- nosy: +tom.dalton.fanduel ___ Python tracker <https://bugs.python.org/issue23

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-08-01 Thread Kamil Gałuszka
Kamil Gałuszka added the comment: This affects all versions from 3.4 up to 3.8-dev. Would be nice if someone could do the review of the supplied patch. Thanks for awesome work on Python! I'm here because it just hit me also and I was for 1 h thinking that I don't know how to use patch/mock

[issue31297] Unpickleable ModuleImportError in unittest patch not backported to 2.7

2018-07-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

Re: overlooked patch?

2018-06-28 Thread Terry Reedy
Yep. We do not have enough people reviewing patches. Perhaps you could do so with this one. On 6/28/2018 12:02 PM, Marco Prosperi wrote: hello, just to give evidence that there is a bug in python 3.6/3.7 for which there is a patch prepared a long time ago but probably it has never been

overlooked patch?

2018-06-28 Thread Marco Prosperi
hello, just to give evidence that there is a bug in python 3.6/3.7 for which there is a patch prepared a long time ago but probably it has never been applied because the status/stage of the bug is 'needs patch'. https://bugs.python.org/issue29097 Marco -- https://mail.python.org/mailman

[issue1792] o(n*n) marshal.dumps performance for largish objects with patch

2018-05-19 Thread Matthias Bussonnier
Change by Matthias Bussonnier : -- pull_requests: +6645 ___ Python tracker ___

[issue21018] [patch] added missing documentation about escaping characters for configparser

2018-03-17 Thread Arun Persaud
Arun Persaud added the comment: created github PR #6137. Hope everything is in the correct format. Arun -- ___ Python tracker

[issue21018] [patch] added missing documentation about escaping characters for configparser

2018-03-17 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +5894 ___ Python tracker ___

[issue21018] [patch] added missing documentation about escaping characters for configparser

2018-03-16 Thread Arun Persaud
Arun Persaud <arun.pers...@gmail.com> added the comment: > @Arun.Persaud, would you be interested in converting your patch to a Github > pull request? sure, I'll give it a try. Arun -- ___ Python tracker <rep...@bugs.pyt

[issue21018] [patch] added missing documentation about escaping characters for configparser

2018-03-12 Thread Cheryl Sabella
Cheryl Sabella <chek...@gmail.com> added the comment: @Arun.Persaud, would you be interested in converting your patch to a Github pull request? -- nosy: +csabella versions: +Python 3.7, Python 3.8 -Python 3.5 ___ Python tracke

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-01-25 Thread Dean Liao
Dean Liao added the comment: I planned to upgrade Chromium OS's mock module to 2.0.0. I also encountered the issue that classmethod cannot be patched as callable mock. Reviewers, can we start the review process? -- nosy: +deanliao

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2017-12-03 Thread Roundup Robot
Change by Roundup Robot <devn...@psf.upfronthosting.co.za>: -- pull_requests: +4604 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2017-12-03 Thread Ed Schouten
Ed Schouten added the comment: Ah, you folks switched to Git + Github in the mean time. Nice! I've just sent this pull request: https://github.com/python/cpython/pull/4691 -- ___ Python tracker

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2017-11-08 Thread Germano
Germano added the comment: Hi, I hit this problem wile mocking one static method and found this fix. Tested it and works for me. However, I did not find it pushed anywhere: no Python 3.x and no mock for 2.7. Is there any reason why it is not pushed anywhere, yet?

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

2017-11-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.7 -Python 2.7 ___ Python tracker ___

[issue5368] curses patch add color_set and wcolor_set , and addchstr family of functions

2017-11-01 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker ___

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2017-10-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: This sgtm. Can you send a PR? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2017-10-25 Thread Ed Schouten
Ed Schouten added the comment: Having looked at various implementations of crypt() and crypt_r(), I can't think of a reason why there would be any significant difference in performance. On systems like FreeBSD, crypt() is just a simple wrapper around crypt_r():

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2017-10-25 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm not sure performance matters. Modern crypt() algorithms should actually be slow enough (using a large number of rounds) to make brute-force attacks impractical... -- nosy: +pitrou versions: +Python 3.7 -Python 3.6

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

2017-10-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the performance of crypt_r() in comparison with crypt()? -- nosy: +serhiy.storchaka ___ Python tracker

[issue31609] PCbuild\clean.bat fails if the patch contains whitespaces

2017-09-27 Thread Serhiy Storchaka
3126 nosy: paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: PCbuild\clean.bat fails if the patch contains whitespaces type: behavior ___ Python tracker <rep...@bugs.python.org> <https

[issue31297] Unpickleable ModuleImportError in unittest patch not backported to 2.7

2017-08-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm guessing the backport may end up non-trivial. Do you want to try submitting a PR for it? -- ___ Python tracker

To mock/patch or not to, was Re: doctest random output?

2017-08-29 Thread Peter Otten
Steven D'Aprano wrote: > Wait... are you saying that importing test_mymodule monkey-patches the > current library? And doesn't un-patch it afterwards? That's horrible. There's something in the library, unittest.mock that makes this relatively safe -- if not painless with mock

[issue31297] Unpickleable ModuleImportError in unittest patch not backported to 2.7

2017-08-28 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +pitrou ___ Python tracker ___ ___

[issue31297] Unpickleable ModuleImportError in unittest patch not backported to 2.7

2017-08-28 Thread Rachel Tobin
exceptions instead. This was fixed in Python 3.4 with this patch: https://bugs.python.org/issue22903 Given that 2.7 is still supported, this patch should be backported. -- components: Library (Lib) messages: 300969 nosy: Rachel Tobin priority: normal severity: normal status: open title

[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface

2017-06-29 Thread Terry J. Reedy
Changes by Terry J. Reedy <tjre...@udel.edu>: -- assignee: kbk -> terry.reedy stage: needs patch -> patch review versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <rep...@bugs.python.org> <h

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The reason of using bytes concatenating rather than accumulating in the list, is that in most cases one of arguments is an empty bytes object (appending to the empty buffer or uncompressing a file with large compression block), and this case is optimized in

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-26 Thread Shubha Ramani
Shubha Ramani added the comment: Upon comparing the PyPy changes from attached diff to the latest cpython3 github, I don't find a need for improvement. Looks like cpython3 zipfile.py has the same changes and the read() method in class ZipExtFile(io.BufferedIOBase) is vastly improved compared

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm not the initial author of zipfile. That initial code for decrypting was added in issue698833. I like your idea about replacing the generating code with the precomputed table. Please open a separate issue for this. --

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Alecsandru Patrascu
Alecsandru Patrascu added the comment: Serhiy, I am curious why did you have chosen to compute the CRC32 table everytime? It is standard (the generator polynomial does not change) and always will output the same values. And it is also less computational intensive to loading a precomputed

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Shubha Ramani
Shubha Ramani added the comment: Serhiy yes what you said makes sense. Thanks for clarifying. Updates (benchmarking results) shortly...stay tuned. -- ___ Python tracker

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I assigned this issue to me as the maintainer of the zipfile module. This means that I undertake to examine the results of benchmarking, make the review of the proposed patch, and merge it if it improves the performance and doesn't have negative side

[issue30467] Propagate zipfile.py pypy issue #905 patch to CPython 2.7

2017-05-25 Thread Shubha Ramani
Shubha Ramani added the comment: Please assign this bug to me. -- ___ Python tracker ___ ___ Python-bugs-list

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Shubha Ramani
Shubha Ramani added the comment: serhiy sure I will attach proof of the performance bottle-neck on 2.7 and 3.7 before I submit a patch. Please assign this bug to me. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Shubha Ramani
Shubha Ramani added the comment: Please assign this bug to me. I will submit a patch -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you provide a benchmarkin script that demonstrates a performance bottleneck? The patch is against 2.7. Please provide a patch against the master branch. -- ___ Python tracker <rep...@bugs.python.org>

[issue30467] Propagate zipfile.py pypy issue #905 patch to CPython 2.7

2017-05-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is the same as issue30468. It isn't worth to open separate issues for different versions. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Propagate zipfile.py pypy issu

[issue30468] Propagate zipfile.py pypy issue #905 patch to CPython 3.7

2017-05-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka components: +Library (Lib) nosy: +alanmcintyre, serhiy.storchaka, twouters ___ Python tracker

<    1   2   3   4   5   6   7   8   9   10   >