[issue28066] [Patch] Fix the ability to cross compile Python when doing a rebuild of importlib.h

a rebuild of importlib.h during the cross compilation process, using Programs/_freeze_importlib. We've run into a couple of issues that require us to patch up the build system to make this work: - First of all, Programs/_freeze_importlib is built using the compiler for the target. There is no way

[issue28058] [Patch] Don't use st_uid and st_gid on CloudABI

of these fields, as it also needs to treat Windows similarly. Attached is a patch that simply adds CloudABI to the relevant '#if' in posixmodule.c. -- components: Extension Modules files: patch-st_uid-st_gid messages: 275591 nosy: EdSchouten priority: normal severity: normal status: open title

[issue1481032] patch smtplib:when SMTPDataError, rset crashes with sslerror

Christian Heimes added the comment: Is this still an issue? The bug is 10 years old and the patch two years. -- nosy: +christian.heimes status: open -> pending versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4 ___ Python tracker &

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Christian Heimes added the comment: LGTM, but it's Victor's final call. -- assignee: -> haypo ___ Python tracker ___

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Ed Schouten added the comment: Sure thing! Attached is an updated patch. -- Added file: http://bugs.python.org/file44434/patch-arc4random ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Christian Heimes added the comment: Thanks. The bare call to arc4random_buf() looks wrong at first. Please add a comment that arc4random_buf() cannot fail / does not report back errors. -- ___ Python tracker

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Nick Coghlan added the comment: Victor, Christian - this looks like another interesting platform-specific corner case for the system RNG wrapper. -- nosy: +christian.heimes, haypo, ncoghlan ___ Python tracker

[issue27395] Patch to Increase test coverage of unittest.runner.TextTestResult

Changes by Berker Peksag <berker.pek...@gmail.com>: -- nosy: +berker.peksag stage: -> patch review type: -> enhancement versions: +Python 3.5 ___ Python tracker <rep...@bugs.python.org> <http://bugs.

[issue27395] Patch to Increase test coverage of unittest.runner.TextTestResult

Changes by Pam McA'Nulty <pam...@mcanulty.org>: -- title: Increase test coverage of unittest.runner.TextTestResult -> Patch to Increase test coverage of unittest.runner.TextTestResult ___ Python tracker <rep...@bugs.pytho

[issue27764] [Patch] Complete bits necessary for making fcntl's file locking optional

-descriptor. This means that processes cannot safely be composed or decomposed. Attached is a relatively small patch to make flock() and lockf() optional, only compiling them when the necessary APIs are present. The LOCK_* constants are now also defined optionally. -- components: Extension

[issue21018] [patch] added missing documentation about escaping characters for configparser

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue21018] [patch] added missing documentation about escaping characters for configparser

Berker Peksag added the comment: Thanks for the patch. Two things: * We want to keep docstrings short so could you please revert the changes in Lib/configparser.py? * It would be better to just add an example of escaping these characters in the "Interpolation of values" section (

[issue27701] [posixmodule] [Refactoring patch] Simply call into *at() functions unconditionally when present

Changes by Alex Willmer : -- nosy: +Alex.Willmer ___ Python tracker ___ ___

[issue27702] [Patch] Only use SOCK_RAW when defined

Roundup Robot added the comment: New changeset 535f88ad80d8 by Berker Peksag in branch 'default': Issue #27702: Only expose SOCK_RAW when defined https://hg.python.org/cpython/rev/535f88ad80d8 -- nosy: +python-dev ___ Python tracker

[issue27702] [Patch] Only use SOCK_RAW when defined

Changes by Stéphane Wirtel : -- nosy: +matrixise ___ Python tracker ___ ___

[issue27702] [Patch] Only use SOCK_RAW when defined

Python's socketmodule.c does try to use it unconditionally. Comply to POSIX by only exposing it optionally, just like we do for some of the other socket types (SOCK_RDM, etc). -- components: Extension Modules files: sock_raw.diff keywords: patch messages: 272117 nosy: EdSchouten priority

[issue27701] [posixmodule] [Refactoring patch] Simply call into *at() functions unconditionally when present

Changes by Stéphane Wirtel : -- nosy: +matrixise ___ Python tracker ___ ___

[issue27701] [posixmodule] [Refactoring patch] Simply call into *at() functions unconditionally when present

(). In os.link(), os.rename() and os.replace(), we call into dir_fd_converter() unconditionally, only to let the respective implementation functions perform additional checks. If dir_fd_unavailable() would be used instead, the implementations would be cleaner. The attached patch does this refactoring

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: I backported the patch to 2.7. Now I get no warnings about syntax highlighting from 2.7 (there were only a few reported before). -- resolution: -> fixed stage: needs patch -> resolved status: open -&g

[issue26462] Patch to enhance literal block language declaration

Roundup Robot added the comment: New changeset 6e9a040a993f by Martin Panter in branch '2.7': Issue #26462: Doc: avoid literal_block warnings, fix syntax highlighting. https://hg.python.org/cpython/rev/6e9a040a993f -- ___ Python tracker

[issue27655] [Patch] Don't require presence of POLLPRI

Ed Schouten added the comment: Believe it our not, dealing with the absence of those system calls is more contained than you'd think. What is pretty nice about Python is that (almost) all of the file system operations are performed through posixmodule.c. Most of the changes in that area are

[issue27655] [Patch] Don't require presence of POLLPRI

Benjamin Peterson added the comment: Are you planning on sending us patches to make Python compile without open(2)? Putting #ifdef around various constants is one thing but it seems like this could become quite invasive. -- ___ Python tracker

[issue27655] [Patch] Don't require presence of POLLPRI

Ed Schouten added the comment: That's a very good question. One of the goals of CloudABI's C library is to leave out definitions for things that are known not to work in the environment. For example, our doesn't contain open(), as with our security model (Capsicum), there is nothing

[issue27655] [Patch] Don't require presence of POLLPRI

Benjamin Peterson added the comment: Why do you remove the flag rather than just making it a noop? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue27656] [Patch] Make presence of SCHED_* optional

Roundup Robot added the comment: New changeset 095b424127e7 by Benjamin Peterson in branch '3.5': all SCHED_ constants are optional (closes #27656) https://hg.python.org/cpython/rev/095b424127e7 New changeset 64b763290da9 by Benjamin Peterson in branch 'default': merge 3.5 (#27656)

[issue27656] [Patch] Make presence of SCHED_* optional

it is present in C, but doesn't do this for the other SCHED_* constants. This is problematic for CloudABI (https://mail.python.org/pipermail/python-dev/2016-July/145708.html), which doesn't support any scheduler interaction at all. Attached is a patch to only define these if present

[issue27655] [Patch] Don't require presence of POLLPRI

es provide support for POLLIN and POLLOUT, but not for POLLPRI. Attached is a patch that patches up the selectmodule to not define POLLPRI in case the host environment does not support it. -- components: Extension Modules files: pollpri.diff keywords: patch messages: 271689 nosy:

[issue27654] [Patch] Use arc4random_buf() on CloudABI

for its presence. Be sure to let me know and I'll update the patch accordingly. -- components: Interpreter Core files: patch-arc4random messages: 271680 nosy: EdSchouten priority: normal severity: normal status: open title: [Patch] Use arc4random_buf() on CloudABI versions: Python 3.6 Added

[issue27653] [Patch] Also disable the use of on CloudABI

low-level network properties, such as TCP socket attributes. For this reason is missing, just like on a couple of other platforms (Symbian, Cygwin, etc). The attached patch extends the current '#ifndef' to also take CloudABI into consideration. -- components: Extension Modules files

[issue27652] [Patch] Make use of non-standard error number ESHUTDOWN optional

. It's not part of POSIX. Attached is a patch to make its use optional. -- components: Interpreter Core files: patch-no-eshutdown messages: 271678 nosy: EdSchouten priority: normal severity: normal status: open title: [Patch] Make use of non-standard error number ESHUTDOWN optional versions

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: Okay, leaving this open for a 2.7 patch. BTW thanks for your work; I tried to tackle these warnings a while ago, but I didn’t know enough about Sphix/RST/etc. The 2.7 change should be fairly easy; I can give it a crack if you’re not that interested in 2.7

[issue26462] Patch to enhance literal block language declaration

Changes by Martin Panter : -- versions: +Python 2.7 ___ Python tracker ___ ___

[issue26462] Patch to enhance literal block language declaration

Roundup Robot added the comment: New changeset 8bac90be by Martin Panter in branch '3.5': Issue #26462: Doc: reduce literal_block warnings, fix syntax highlighting. https://hg.python.org/cpython/rev/8bac90be New changeset 6fbb7c9d77c6 by Martin Panter in branch 'default': Issue #26462:

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Decorater: Colors used by the documentation are defined here: https://github.com/sphinx-doc/sphinx/blob/master/sphinx/pygments_styles.py#L22 you can easily modify it and rebuild the doc ``(cd Doc; make html)``. Take a look at existing themes

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Martin: OK, let's apply this to 3.6 / 3.5 with this one, and I'll provide independent patch for 2.7 if needed (long time without building 2.7 doc). -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue26462] Patch to enhance literal block language declaration

R. David Murray added the comment: Martin: your summary is correct. A new feature should also have a What's New entry, of course; I think that's the only essential you left out. Decorator: general comments (eg: color of docs, etc) aren't really useful comments on a specific bug report, and

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: Usually my technique is to apply the 3.6 patch to 3.5, fix up any conflicts, and leave the 3.6-only bits out (which get rejected by the patch process anyway). But dedicated patch(es) may be useful. Especially for 2.7, where there are probably independent

[issue26462] Patch to enhance literal block language declaration

Decorater added the comment: Also I was thinking maybe I could figure out how to Add in asyncio to 2.7 anyway (well latest one that is) because why not. With as many things using asyncio now days it would be cake for those python 2 users. -- ___

[issue26462] Patch to enhance literal block language declaration

Decorater added the comment: tbh it would be nice if the entire documentation was recolored to look more 'interesting' to read. And to also have it in a way that people who lean visually can learn the info easier instead of them trying to read a giant wall of text that they may or may not

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Hi, Would you like me to also provide patches for different versions? I only provided patches for the default branch, but I'll gladly see this applied on other branches, as I often build them all. Also is a documented policy about maintaining the documentation? I

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Hi, Indentation in whatsnew/3.2 fixed. Colors in this block are clearly not perfect, but I think that's another subject. -- Added file: http://bugs.python.org/file43923/issue26462.v7.diff ___ Python tracker

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: One last change I think needs making to the same demo, the “code-block” needs indenting under the bullet point: * The interpreter can now be started with a quiet option, ``-q``, to prevent the copyright and version information from being displayed in the

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Hi, You're right, nice catch! Removing `python -q` from the code block demonstrating it was a bad idea. I fixed it in the v6. Thanks! -- Added file: http://bugs.python.org/file43916/issue26462.v6.diff ___ Python tracker

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: V5 looks pretty good to me. With your blessing of restoring the python -q example from v4 (see review), I think it is ready to commit. -- stage: patch review -> commit review ___ Python tracker &

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: @martin I reviewed my changes on `decimal.rst` and I now just fixing the indentation problem, so I don't change anything unrealated to fixing warnings, and don't break doctests. -- ___ Python tracker

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Here a new patch after reviewing comments on rietveld. -- Added file: http://bugs.python.org/file43892/issue26462.v5.diff ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: I’ve finished going over the latest patch. There are a couple of problems; see the review link. Also, why did you add the changes in Doc/library/decimal.rst? In your second patch, you removed one of these changes, but now you have added more. They seem

[issue26462] Patch to enhance literal block language declaration

Changes by Martin Panter : Added file: http://bugs.python.org/file43885/issue26462.v4_regen.diff ___ Python tracker ___

[issue13963] dev guide has no mention of mechanics of patch review

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: I think generating it with Mercurial (and not using Mercurial’s Git patch format) is the best way. I just left some more notes at <https://bugs.python.org/issue13963#msg271260>. -- ___ Python tracke

[issue13963] dev guide has no mention of mechanics of patch review

Martin Panter added the comment: FTR: The Mercurial bug has wandered to <https://bz.mercurial-scm.org/show_bug.cgi?id=3761>. It suggests using “hg --config diff.git=0 diff”. Also, this 2011 post has some details of how the Git patch format is accepted or not (not sure if anything has c

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Oh and, is there a proper way for me to generate a diff that rietveld can eat without someone regeneratig it? -- ___ Python tracker

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Upladed a new patch, I was working on 3.5 branch so I did not get all errors. I'm still having: WARNING: Could not parse literal_block as "ini". highlighting skipped. But it may be considered another bug: pygments ini parser can't parse ini s

[issue26462] Patch to enhance literal block language declaration

Martin Panter added the comment: With Julien’s patch applied, these are the remaining warnings: /media/disk/home/proj/python/cpython/Doc/library/configparser.rst:240: WARNING: Could not lex literal_block as "ini". Highlighting skipped. /media/disk/home/proj/python/cpython/D

[issue26462] Patch to enhance literal block language declaration

Changes by Martin Panter : Added file: http://bugs.python.org/file43872/issue26462.v3_regen.diff ___ Python tracker ___

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Hi, I completly missed the "review" link, sry. I reviewed comments, and I'm trying to provide an up-to-date patch that you'll hopefully won't have to doctor to make Rietveld eat it. -- Added file: http://bugs.python.org/file43847/issue

[issue26462] Patch to enhance literal block language declaration

Zachary Ware added the comment: Hi Julien, there are still a few unanswered review comments. Check the 'review' link on 'issue26462_regen.diff' (which was your patch, I just recreated it in a format that our Rietveld review tool would accept

[issue26462] Patch to enhance literal block language declaration

Julien added the comment: Hi, Look like it has not been merged, is there something I can do to help with this? Bests -- ___ Python tracker ___

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

Changes by Benjamin Peterson : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

Roundup Robot added the comment: New changeset 5b64175c6c24 by Martin Panter in branch '3.2': Issue #27369: Don’t test error message detail that changed in Expat 2.2.0 https://hg.python.org/cpython/rev/5b64175c6c24 New changeset 1c06e02b968a by Martin Panter in branch '3.3': Issue #27369: Merge

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

Chi Hsuan Yen added the comment: Added a patch. -- nosy: +Chi Hsuan Yen ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27369> ___ __

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

Changes by Chi Hsuan Yen <yan12...@gmail.com>: Added file: http://bugs.python.org/file43652/issue27369.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue27439] product function patch

Steven D'Aprano added the comment: On Sat, Jul 02, 2016 at 11:40:48AM +, Utkan Gezer wrote: > > New submission from Utkan Gezer: > > An issue of enhancement by the introduction of a built-in product() > function for the multiplication operation, functions similar to how > sum does for

[issue27439] product function patch

Utkan Gezer added the comment: The use case is similar to the use case of sum() function, which is analogous to the sigma notation in mathematics, and is analogous to the use case of the pi notation in mathematics. Regular loop should be equally enough to achieve the function of sum(), yet

[issue27439] product function patch

Emanuel Barry added the comment: What is the use case, and why is a regular for loop not enough? The bar for adding new builtin functions is high, and I don't think this meets it. -- nosy: +ebarry ___ Python tracker

[issue27439] product function patch

://bugs.python.org/issue1093 -- messages: 269706 nosy: Utkan Gezer priority: normal severity: normal status: open title: product function patch type: enhancement versions: Python 3.6 ___ Python tracker <rep...@bugs.python.org> <http://bugs.p

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

this actually be applied to all security versions, or just 3.5+ and 2.7? I guess can see the benefit of fixing 3.2+, and I remember doing this once before when the test suite fell over and it was not Python’s fault. -- nosy: +martin.panter stage: -> patch rev

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

Changes by sping <sebast...@pipping.org>: Added file: http://bugs.python.org/file43515/0001-Fix-Python-3.x.x-tests-for-Expat-2.2.0.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue27369] [PATCH] Tests break with --with-system-expat and Expat 2.2.0

versions in a backwards-compatible way. Please consider application upstream. Thanks! Best, Sebastian -- components: Tests files: 0001-Fix-Python-2.7.11-tests-for-Expat-2.2.0.patch keywords: patch messages: 269079 nosy: sping priority: normal severity: normal status: open title: [PATCH

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

Martin Panter added the comment: Closing now that platform._sys_version() can tolerate the truncated version info. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.pytho

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

Roundup Robot added the comment: New changeset b86e259271b3 by Martin Panter in branch '2.7': Issue #21313: Tolerate truncated buildinfo in sys.version https://hg.python.org/cpython/rev/b86e259271b3 New changeset 4deec876db0d by Martin Panter in branch '3.5': Issue #21313: Tolerate truncated

[issue25941] Add 'How to Review a Patch' section to devguide

Ned Deily added the comment: The revised patch looks good to me (other than some trailing whitespace). Camilla, thanks for your contribution. If you haven't already, please sign a contributor form to cover this and future contributions as noted elsewhere in the Developer's Guide: https

[issue25941] Add 'How to Review a Patch' section to devguide

Roundup Robot added the comment: New changeset 8b3f4473432e by Ned Deily in branch 'default': Issue #25941: Add "How To Review A Patch" section to the devguide. https://hg.python.org/devguide/rev/8b3f4473432e -- nosy: +python-dev ___ Pyth

[issue25941] Add 'How to Review a Patch' section to devguide

Camilla Montonen added the comment: Thank you very much for your comments. I have cleaned up the previous patch and merged it with the Lifecycle of a Patch article. -- Added file: http://bugs.python.org/file42893/patchreview18May.patch ___ Python

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

Martin Panter added the comment: >>> Py_GetBuildInfo = pythonapi.Py_GetBuildInfo >>> Py_GetBuildInfo.restype = c_char_p >>> Py_GetBuildInfo() # Not truncated 'qbase qtip subprocess-stderr_redirect_with_no_stdout_redirect-2.diff tip:0b641285389d+, May 13 2016, 02:10:26' Demo of my problem with

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

(), but it would be nice if the test suite would run :) -- keywords: +patch nosy: +martin.panter versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file42836/parse-version.patch ___ Python tracker <rep...@bugs.python.org>

[issue26505] [PATCH] Spelling of ANY in the license of Modules/getaddrinfo.c

Ned Deily added the comment: Thanks for noticing and for the patch, Alex! -- nosy: +ned.deily resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker <rep...@bug

[issue26505] [PATCH] Spelling of ANY in the license of Modules/getaddrinfo.c

Roundup Robot added the comment: New changeset c6b0204c23c5 by Ned Deily in branch '2.7': Issue #26505: Fix typos in getaddrinfo license text. https://hg.python.org/cpython/rev/c6b0204c23c5 New changeset a6b07ad3d14d by Ned Deily in branch '3.5': Issue #26505: Fix typos in getaddrinfo license

[issue26505] [PATCH] Spelling of ANY in the license of Modules/getaddrinfo.c

committed. -- files: getaddrinfo-license-ANY.patch keywords: patch messages: 261301 nosy: Alex.Willmer priority: normal severity: normal status: open title: [PATCH] Spelling of ANY in the license of Modules/getaddrinfo.c Added file: http://bugs.python.org/file42083/getaddrinfo-license-ANY.patch

[issue26462] Patch to enhance literal block language declaration

Georg Brandl added the comment: Looks good now! I left a few comments on Rietveld. -- ___ Python tracker ___

[issue26462] Patch to enhance literal block language declaration

Zachary Ware added the comment: Attaching regenerated patch to coax Rietveld into accepting it for easier review. -- nosy: +zach.ware Added file: http://bugs.python.org/file42058/issue26462_regen.diff ___ Python tracker <rep...@bugs.python.

[issue26462] Patch to enhance literal block language declaration

e). I keeped the explicit pycon lexer in the "Doc/extending/extending.rst" file which have a ".. highlightlang:: c". Here is the new patch, and thanks for this usefull review ! -- Added file: http://bugs.python.org/file42057/literal_blocks_languages.patch _

[issue26462] Patch to enhance literal block language declaration

Georg Brandl added the comment: Thanks for the patch! Most "bash" blocks should be "console" (since the prompt is shown). "pycon" should not be needed, since it is detected automatically. -- ___ Python tracker

[issue26462] Patch to enhance literal block language declaration

Changes by Serhiy Storchaka <storch...@gmail.com>: -- nosy: +georg.brandl, serhiy.storchaka stage: -> patch review versions: +Python 3.6 ___ Python tracker <rep...@bugs.python.org> <http://bugs.pyt

[issue26462] Patch to enhance literal block language declaration

thon.org/3.5/library/pyexpat.html is now nicely colored: http://www.afpy.org/doc/python/3.5/library/pyexpat.html -- assignee: docs@python components: Documentation files: literal_blocks_languages.patch keywords: patch messages: 261035 nosy: docs@python, sizeof priority: normal severity: norma

[issue2704] IDLE: Patch to make PyShell behave more like a Terminal interface

Changes by irdb : -- nosy: +irdb ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

Changes by Erik Purins : -- nosy: +epu ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23942] Explain naming of the patch files in the bug tracker

Ezio Melotti added the comment: I think this is not worth fixing, for two reasons: 1) we are moving away from Rietveld; 2) even if we document it, most people won't go looking for naming conventions and just use reasonable names (and most of the times they will just work); I'm therefore going

[issue23942] Explain naming of the patch files in the bug tracker

”, “.v3” etc for the revised patches. If I just gave them an issue number, it would get lost my Mercurial patch queue among a sea of other numbers. If I did not add the “.v2” revision number, people would have to refer to the patches by upload date rather than name or version. -- nosy

[issue23942] Explain naming of the patch files in the bug tracker

Maciej Szulik added the comment: Ezio, I've meant we should provide some guidelines with information the system will pick whatever they choose based on submission date. More informational than as a requirement. -- ___ Python tracker

[issue23942] Explain naming of the patch files in the bug tracker

Changes by R. David Murray : -- nosy: -r.david.murray ___ Python tracker ___ ___

[issue13963] dev guide has no mention of mechanics of patch review

Ezio Melotti added the comment: Since we are moving away from rietveld, I'm going to close this as out of date. -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <rep...@bugs.pytho

[issue23942] Explain naming of the patch files in the bug tracker

Ezio Melotti added the comment: FWIW I use e.g. issue1234.diff and if further patches are needed I add an increasing suffix: issue1234-2.diff, issue1234-3.diff, etc. Since the name doesn't matter too much, I'm not sure it's worth documenting and/or enforcing a specific convention. --

[issue25941] Add 'How to Review a Patch' section to devguide

Ezio Melotti added the comment: +1 to the above message. There are also a couple of things that should be corrected: * bugtracker -> bug tracker * If the patch makes codechanges to C codebase -> If the patch affects any C file This could also be condensed a bit and merged with

[issue25941] Add 'How to Review a Patch' section to devguide

SilentGhost added the comment: Content of the article is in very reasonable shape, I have only couple of notes: 1. I don't think "production" is a good description of the python's repository workflow, so I'd suggest changing it to "repository". 2. Lack of links: instead of saying "check the

[issue25941] Add 'How to Review a Patch' section to devguide

Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___

[issue25941] Add 'How to Review a Patch' section to devguide

New submission from Camilla Montonen: This list is based on helpful tips and discussions received on the core-mentorship list and aims to help new beginners review patches in the bug tracker. The submitted patch is still in progress (the layout is a bit wonky and some details are still

[issue23895] [PATCH] python socket module fails to build on Solaris when -zignore is in LDFLAGS

Changes by Andrew Stormont <andyjstorm...@gmail.com>: -- title: python socket module fails to build on Solaris when -zignore is in LDFLAGS -> [PATCH] python socket module fails to build on Solaris when -zignore is in LDFLAGS ___ Python tra

[issue23564] Patch fixing sanity check for ordered fd sequence in _posixsubprocess.c

Gregory P. Smith added the comment: Hisham, could you sign the Python contributor agreement? https://www.python.org/psf/contrib/contrib-form/ thanks! -- ___ Python tracker

<    1   2   3   4   5   6   7   8   9   10   >