[issue45606] pathlib.Path.glob() does not list dangling symlink when pattern is the exact filename

2022-01-22 Thread Andrei Kulakov
Change by Andrei Kulakov : -- title: pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane -> pathlib.Path.glob() does not list dangling symlink when pattern is the exact filename versions: +Python 3.11 -Python

[issue45619] Mentioning structural pattern matching in the list of binding

2021-11-25 Thread Guido van Rossum
Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45619] Mentioning structural pattern matching in the list of binding

2021-11-25 Thread miss-islington
miss-islington added the comment: New changeset 7842aed7a7938df20b652177458407683e7f1a0b by Miss Islington (bot) in branch '3.10': bpo-45619: documentation of execution model: clarify and update binding summary (GH-29232)

[issue45619] Mentioning structural pattern matching in the list of binding

2021-11-25 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset cd876c84932ecc2f7a6c41f3fc800a34d5b06b95 by Arthur Milchior in branch 'main': bpo-45619: documentation of execution model: clarify and update binding summary (#29232)

[issue45619] Mentioning structural pattern matching in the list of binding

2021-11-25 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +28023 pull_request: https://github.com/python/cpython/pull/29787 ___ Python tracker

[issue22276] pathlib glob ignores trailing slash in pattern

2021-11-20 Thread Andrei Kulakov
Andrei Kulakov added the comment: Generally if Path is created with a trailing separator, I think it should error out for all methods that apply to files, for example `.touch()`, `read*()`, `write*()`, others. This is consistent with shell commands: touch xyz/

[issue22276] pathlib glob ignores trailing slash in pattern

2021-11-20 Thread Andrei Kulakov
Andrei Kulakov added the comment: I meant to say: path.glob('myfile/') => [PosixPath('myfile')] -- ___ Python tracker ___ ___

[issue22276] pathlib glob ignores trailing slash in pattern

2021-11-20 Thread Andrei Kulakov
Andrei Kulakov added the comment: I have also run into this when looking into path.glob('dangling_symlink') issue. I can add a few things (in the examples, *myfile* is a file, not a directory): This is probably more common / less obscure than '*/': path.glob('myfile/') => True This is

[issue45606] pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane

2021-11-19 Thread Andrei Kulakov
Andrei Kulakov added the comment: By the way note that path.glob('**/my_symlink') also does return the dangling symlink match. And glob.glob('my_symlink') also returns a dangling symlink. -- ___ Python tracker

[issue45606] pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane

2021-11-19 Thread Andrei Kulakov
Andrei Kulakov added the comment: Rasmus: thanks for the report, it does seem like a bug to me. -- ___ Python tracker ___ ___

[issue45606] pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane

2021-11-19 Thread Andrei Kulakov
Andrei Kulakov added the comment: The issue is that _PreciseSelector follows the symlink when it checks if a path exists before yielding it as a result. I've put up a PR with a fix; I've also added a *follow_symlinks* arg to `exists()` method because it seems more logical to be able to test

[issue45606] pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane

2021-11-19 Thread Andrei Kulakov
Change by Andrei Kulakov : -- keywords: +patch nosy: +andrei.avk nosy_count: 1.0 -> 2.0 pull_requests: +27897 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29655 ___ Python tracker

[issue45619] Mentioning structural pattern matching in the list of binding

2021-10-26 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45619] Mentioning structural pattern matching in the list of binding

2021-10-26 Thread Arthur Milchior
Change by Arthur Milchior : -- keywords: +patch pull_requests: +27495 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29232 ___ Python tracker ___

[issue45619] Mentioning structural pattern matching in the list of binding

2021-10-26 Thread Arthur Milchior
New submission from Arthur Milchior : https://docs.python.org/3/reference/executionmodel.html list all of the way a variable may be bound. However, it seems that it was not updated. Indeed, structural pattern matching in 3.10 also allows to bind a variable and is not mentionned

[issue45606] pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane

2021-10-25 Thread Rasmus Bondesson
r is it intentional? -- components: Library (Lib) messages: 404996 nosy: raek priority: normal severity: normal status: open title: pathlib.Path.glob() does not list dangling symlink when pattern is the exact filenane type: behavior versions: Python 3.10, Python 3.8, Python

[issue45458] "\W" pattern with re.ASCII flag is not equivalent to "[^a-zA-Z0-9_]"

2021-10-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It works as expected: >>> re.sub(r'\W', '', '½ a', 0, re.ASCII) 'a' You just passed re.ASCII as the count argument, not as the flags argument. >>> help(re.sub) Help on function sub in module re: sub(pattern, repl, string, count=0, f

[issue45458] "\W" pattern with re.ASCII flag is not equivalent to "[^a-zA-Z0-9_]"

2021-10-13 Thread Owen
New submission from Owen : "\W" regex pattern, when used with `re.ASCII`, is expected to have the same behavior as "[^a-zA-Z0-9_]" (see [1]). For example, the following `sub()` call ``` >>> re.sub('\W', '', '½ a', re.ASCII) '½a' ``` should return the same as this

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-30 Thread Dong-hee Na
Dong-hee Na added the comment: > https://github.com/brandtbucher/patmaperformance Nice benchmark suite, I will take a look :) -- ___ Python tracker ___

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-30 Thread Brandt Bucher
Brandt Bucher added the comment: I'm also in the process of creating some pattern matching benchmarks. You might find them useful for benching optimizations like this in the future: https://github.com/brandtbucher/patmaperformance In particular, I'm curious to see the impact of this change

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-30 Thread Brandt Bucher
Brandt Bucher added the comment: Thanks, this is awesome. FYI, there's probably more low-hanging fruit like this scattered about the pattern matching implementation. It's all very new code, mostly written by one person ;). (I wouldn't worry too much about the pattern compiler, though

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-30 Thread Dong-hee Na
Dong-hee Na added the comment: For the record, Final benchmark with optimization build + thin LTO option. +---+---+--+ | Benchmark | thin_lto_base | thin_lto_opt | +===+===+==+ | bench pattern

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-30 Thread Dong-hee Na
Change by Dong-hee Na : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-30 Thread Dong-hee Na
Dong-hee Na added the comment: New changeset e6497fe698f6e87344501a68ffdea106eafcb257 by Dong-hee Na in branch 'main': bpo-45045: Optimize mapping patterns of structural pattern matching (GH-28043) https://github.com/python/cpython/commit/e6497fe698f6e87344501a68ffdea106eafcb257

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Tim Peters
Change by Tim Peters : Removed file: https://bugs.python.org/file50242/runstack.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Tim Peters
Change by Tim Peters : -- Removed message: https://bugs.python.org/msg400568 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Tim Peters
Tim Peters added the comment: And another runstack.py adds `shivers4()`, which reworks `shivers3()` (length-adaptive ShiversSort) so that division, log2(), and floor() aren't used anymore. It does need a loop, though, which needs to go around a number of times `k` such that k is the

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Dong-hee Na
Dong-hee Na added the comment: With Ken Jin's suggestion +---++--+ | Benchmark | base | PR 28043 | +===++==+ | bench pattern | 482 ns | 373 ns: 1.29x faster

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Dong-hee Na
Change by Dong-hee Na : -- keywords: +patch pull_requests: +26488 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28043 ___ Python tracker ___

[issue45045] Optimize mapping patterns of structural pattern matching

2021-08-29 Thread Dong-hee Na
| +===++==+ | bench pattern | 482 ns | 417 ns: 1.15x faster | +---++--+ -- components: Interpreter Core files: bench_pattern.py messages: 400549 nosy: corona10 priority: normal severity: normal status: open title: Optimize mapping patterns

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-29 Thread Pierre Quentel
Pierre Quentel added the comment: I found why len() is required, it's to avoid trying to match the subject (thus consuming a part of it) if its length is less than the number of non-star patterns, as explained in the PEP. My mistake, sorry. --

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-28 Thread Brandt Bucher
Change by Brandt Bucher : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-28 Thread miss-islington
miss-islington added the comment: New changeset 405f5c54914483607194a3ba6d4e50533d92bad1 by Miss Islington (bot) in branch '3.10': [3.10] bpo-43897: Reject "_" captures and top-level MatchStar in the AST validator (GH-27432) (GH-27435)

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-28 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 8d0647485db5af2a0f0929d6509479ca45f1281b by Brandt Bucher in branch 'main': bpo-43897: Reject "_" captures and top-level MatchStar in the AST validator (GH-27432) https://github.com/python/cpython/commit/8d0647485db5af2a0f0929d6509479ca45f1281b

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-28 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +25964 pull_request: https://github.com/python/cpython/pull/27435 ___ Python tracker

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-28 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +25961 pull_request: https://github.com/python/cpython/pull/27432 ___ Python tracker ___

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-28 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 31bec6f1b178dadec3cb43353274b4e958a8f015 by Batuhan Taskaya in branch 'main': bpo-43897: AST validation for pattern matching nodes (GH24771) https://github.com/python/cpython/commit/31bec6f1b178dadec3cb43353274b4e958a8f015

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-27 Thread Pierre Quentel
Pierre Quentel added the comment: Oh, I did not invent this class, it is in the test script for pattern matching : https://github.com/python/cpython/blob/6948964ecf94e858448dd28eea634317226d2913/Lib/test/test_patma.py#L1932 With this class, [x, *_, y] matches, but not [x, *w, y

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-27 Thread Guido van Rossum
Guido van Rossum added the comment: Given that the class used to demonstrate this behavior has a bug (__len__ is inconsistent with __getitem__), I don't think it matters much -- if doing it your way is (as I suspect) slower than the current implementation for other (well-behaved) sequences,

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-27 Thread Pierre Quentel
version of the PEP). There are obvious similarities between [x, *y, z] = A and match A: case [x, *y, z]: print('ok') but a big difference, put forward in PEP 634 : the classes supported for pattern matching are limited (unpacking a generator expression is possible

[issue42128] Structural Pattern Matching (PEP 634)

2021-07-26 Thread Andrei Kulakov
Change by Andrei Kulakov : -- nosy: +andrei.avk nosy_count: 13.0 -> 14.0 pull_requests: +25916 pull_request: https://github.com/python/cpython/pull/27384 ___ Python tracker

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Steven D'Aprano
Steven D'Aprano added the comment: Ah, I missed that and totally misinterrpreted other comments. Confirmation bias at work: I saw the code I expected to see, not the code that was actually there :-( All good, I agree that it is a bug in the class, not in the language. Sorry for the noise.

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Brandt Bucher
Brandt Bucher added the comment: > All the examples that are said to go into an infinite loop work fine in 3.9. > [...] At the very least, the examples shouldn't swallow the IndexError and go > into an infinite loop. Note that the original example posted did not include a "raise IndexError"

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Steven D'Aprano
Steven D'Aprano added the comment: How is this not a regression? And a very serious one by the sound of it. All the examples that are said to go into an infinite loop work fine in 3.9. (Obviously I can't check the match statement example in 3.9.) If the Sequence Protocol really has been

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Brandt Bucher
Brandt Bucher added the comment: I agree, Pablo. The only thing that makes me pause is that, depending on the pattern, *sometimes* we use iteration and *sometimes* we use indexing. That might be sort of surprising to classes like Seq if you change patterns or major Python versions

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: In general I would propose to close this as "not a bug" -- ___ Python tracker ___ ___

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Pablo Galindo Salgado
;Anything that tries to iterate on this thing will hang" I think that whatever we do, we should make it *predictable* and consistency across the language, and IMHO only fixing it in pattern matching doesn't make it predictable. Being said that, I don't think these use cases justifies a major ove

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Brandt Bucher
hree paths (we'll just also need to use BUILD_LIST / LIST_APPEND to actually collect the starred items). It will simplify the pattern compiler a bit, but I imagine it will also come with a performance penalty as well. In my opinion, I don't think we should rewrite everything to support Seq (thou

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Brandt Bucher
Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44741] Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence

2021-07-26 Thread Pierre Quentel
of stopping when the expected number of items in w is reached. -- components: Interpreter Core messages: 398226 nosy: quentel priority: normal severity: normal status: open title: Pattern Matching - star subpattern with a subject derived from collections.abc.Sequence type: crash versions

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-07-18 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: -25772 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-07-18 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 8.0 -> 9.0 pull_requests: +25772 pull_request: https://github.com/python/cpython/pull/27228 ___ Python tracker

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-16 Thread Jack DeVries
Jack DeVries added the comment: The PR and backport to 3.10 have both been merged, so I think this issue can be closed. -- ___ Python tracker ___

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Is something left here? -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-14 Thread miss-islington
miss-islington added the comment: New changeset 016af14d93cfba43e7a95721a97fa954c534af8e by Miss Islington (bot) in branch '3.10': [3.10] bpo-44589: raise a SyntaxError when mapping patterns have duplicate literal keys (GH-27131) (GH-27157)

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-14 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +25694 pull_request: https://github.com/python/cpython/pull/27157 ___ Python tracker

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-14 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 2693132292b2acf381ac6fa729bf3acf41d9d72b by Jack DeVries in branch 'main': bpo-44589: raise a SyntaxError when mapping patterns have duplicate literal keys (GH-27131)

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-14 Thread Jack DeVries
Jack DeVries added the comment: @brandtbucher, I'm sorry for the miscommunication. I started working on this patch at the beginning of the week after message 397215... I'm a new contributor too, and I wasn't sure if I would be able to make something that worked, so I just kept my mouth

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-14 Thread Brandt Bucher
Brandt Bucher added the comment: Thanks for the patch @jack__d! I'll try to find time to review it today. I do wish you would have coordinated with me here before writing it, though. I'd already begun working on a patch with a few new contributors yesterday, as I mentioned in my comment.

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-13 Thread Jack DeVries
Jack DeVries added the comment: @brandtbucher, I think that my PR implements the solution you've described here. What do you think? -- ___ Python tracker ___

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-13 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch nosy: +jack__d nosy_count: 3.0 -> 4.0 pull_requests: +25674 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27131 ___ Python tracker

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-10 Thread Brandt Bucher
Change by Brandt Bucher : -- assignee: -> brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-09 Thread Pierre Quentel
Pierre Quentel added the comment: Sorry, I don't know C so I can't write a PR for this change. -- ___ Python tracker ___ ___

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 2f7636887e9f978352aa47b18d5f376263663ba1 by Batuhan Taskaya in branch '3.10': [3.10] bpo-43897: ast validation for pattern matching nodes (GH-27074) https://github.com/python/cpython/commit/2f7636887e9f978352aa47b18d5f376263663ba1

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-09 Thread Guido van Rossum
Guido van Rossum added the comment: Agreed with everything that Brandt said. These wording issues are subtle! Note in particular that the original wording implies that {‘x’: 1, ‘x’: 1, z: 1} would be a runtime error, but it clearly should be a compile time error.-- --Guido (mobile) --

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-09 Thread Brandt Bucher
Brandt Bucher added the comment: Sorry, that should be PEP 634, not 638. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-09 Thread Brandt Bucher
Brandt Bucher added the comment: Nice find! In my opinion, we should do two things here: - Update PEP 638 to specify that a SyntaxError is raised "if *any duplicate* key patterns are literal patterns". This was absolutely our original intention... I think the nuances were just lost in the

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-09 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44589] Pattern Matching - duplicate keys in mapping patterns

2021-07-09 Thread Pierre Quentel
New submission from Pierre Quentel : PEP 634 specifies that "A mapping pattern may not contain duplicate key values. (If all key patterns are literal patterns this is considered a syntax error; otherwise this is a runtime error and will raise ValueError.)" but this is not wh

[issue43897] Implement support for validation of pattern matching ASTs

2021-07-08 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- pull_requests: +25624 pull_request: https://github.com/python/cpython/pull/27074 ___ Python tracker ___

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-04 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: @Łukasz thanks for your merging spree! I'm actually not sure this should go into 3.9. Seems potentially dangerous that people upgrading from an earlier 3.9 patch release will now see new names injected into their namespace if they do `from typing import *`.

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-04 Thread Łukasz Langa
Łukasz Langa added the comment: Fix merged to main (3.11), 3.10, and 3.9. Not applicable to older Pythons as they are security fixes only. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.6

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-04 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 00726e51ade10c7e3535811eb700418725244230 by Miss Islington (bot) in branch '3.9': bpo-38352: Add to typing.__all__ (GH-25821) (#25885) https://github.com/python/cpython/commit/00726e51ade10c7e3535811eb700418725244230 --

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-04 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset e1bcc88a502aa0239b6bcc4da3fe024307fd27f4 by Miss Islington (bot) in branch '3.10': bpo-38352: Add to typing.__all__ (GH-25821) (#25884) https://github.com/python/cpython/commit/e1bcc88a502aa0239b6bcc4da3fe024307fd27f4 -- nosy:

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +24559 pull_request: https://github.com/python/cpython/pull/25885 ___ Python tracker ___

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-04 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +24558 pull_request: https://github.com/python/cpython/pull/25884 ___ Python tracker

[issue43754] Eliminate bindings for partial pattern matches

2021-05-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 39494285e15dc2d291ec13de5045b930eaf0a3db by Pablo Galindo in branch 'master': bpo-43754: Fix compiler warning in Python/compile.c (GH-25855) https://github.com/python/cpython/commit/39494285e15dc2d291ec13de5045b930eaf0a3db --

[issue43754] Eliminate bindings for partial pattern matches

2021-05-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +24539 pull_request: https://github.com/python/cpython/pull/25855 ___ Python tracker ___

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-02 Thread Jelle Zijlstra
Change by Jelle Zijlstra : -- keywords: +patch pull_requests: +24508 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25821 ___ Python tracker ___

[issue38352] In typing docs, note explicit import needed for IO and Pattern/Match

2021-05-02 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: It turns out that IO, TextIO, BinaryIO, Match, and Pattern aren't in typing.__all__. As Walter points out above, there's no clear reason for this. I am submitting a PR to add them to __all__. -- nosy: +Jelle Zijlstra

[issue43754] Eliminate bindings for partial pattern matches

2021-05-02 Thread Brandt Bucher
Change by Brandt Bucher : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue43754] Eliminate bindings for partial pattern matches

2021-05-02 Thread Brandt Bucher
Brandt Bucher added the comment: New changeset 0ad1e0384c8afc5259a6d03363491d89500a5d03 by Brandt Bucher in branch 'master': bpo-43754: Eliminate bindings for partial pattern matches (GH-25229) https://github.com/python/cpython/commit/0ad1e0384c8afc5259a6d03363491d89500a5d03

[issue42128] Structural Pattern Matching (PEP 634)

2021-04-26 Thread Saiyang Gou
Change by Saiyang Gou : -- nosy: +gousaiyang nosy_count: 12.0 -> 13.0 pull_requests: +24335 pull_request: https://github.com/python/cpython/pull/25642 ___ Python tracker ___

[issue43754] Eliminate bindings for partial pattern matches

2021-04-24 Thread Brandt Bucher
Brandt Bucher added the comment: Since the feature freeze is coming up (and this changes the bytecode), I'd like to open this up for review now. It probably shouldn't actually be merged before the AST changes in issue 43892, though. There will be quite a few conflicts that need resolving,

[issue43897] Implement support for validation of pattern matching ASTs

2021-04-22 Thread Nick Coghlan
Change by Nick Coghlan : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43897] Implement support for validation of pattern matching ASTs

2021-04-22 Thread Nick Coghlan
Change by Nick Coghlan : -- priority: normal -> critical ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42128] Structural Pattern Matching (PEP 634)

2021-04-20 Thread Brandt Bucher
Change by Brandt Bucher : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue43897] Implement support for validation of pattern matching ASTs

2021-04-20 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42128] Structural Pattern Matching (PEP 634)

2021-04-20 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > Actually, I didn't see that there are still 2 open linked PRs. I'll wait > until those are merged. I've moved the AST validator to its own separate issue so feel free to close this Brandt! -- ___ Python

[issue42128] Structural Pattern Matching (PEP 634)

2021-04-20 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- pull_requests: -23539 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43897] Implement support for validation of pattern matching ASTs

2021-04-20 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +24213 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24771 ___ Python tracker ___

[issue43897] Implement support for validation of pattern matching ASTs

2021-04-20 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- dependencies: +Make match patterns explicit in the AST ___ Python tracker ___ ___ Python-bugs-list

[issue43897] Implement support for validation of pattern matching ASTs

2021-04-20 Thread Batuhan Taskaya
: BTaskaya priority: normal severity: normal status: open title: Implement support for validation of pattern matching ASTs versions: Python 3.10 ___ Python tracker <https://bugs.python.org/issue43

[issue43761] Documenting dataclass and namedtuple changes for structural pattern matching

2021-04-12 Thread Brandt Bucher
Brandt Bucher added the comment: > For named tuples, there isn't an include/exclude option, so no extra mention > is warranted. I think a note in the docs could still be valuable, if only because defining __match_args__ for named tuples changes the inherited tuple behavior for positional

[issue43686] re.match appears to hang with certain combinations of pattern and string

2021-04-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: Try something like https://pypi.org/project/pyre2/ or _maybe_ https://pypi.org/project/regex/ (I didn't think that one tried to do a breadth first approach though so maybe not) I'm marking this a duplicate of the age old issue around degenerate patterns

[issue43761] Documenting dataclass and namedtuple changes for structural pattern matching

2021-04-10 Thread Eric V. Smith
Eric V. Smith added the comment: > Do you need anything from me here? No, I don't think so. Thanks. -- ___ Python tracker ___ ___

[issue43761] Documenting dataclass and namedtuple changes for structural pattern matching

2021-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: Do you need anything from me here? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43761] Documenting dataclass and namedtuple changes for structural pattern matching

2021-04-10 Thread Adrian Freund
Adrian Freund added the comment: I think for namedtuple a short mention in the opening paragraph, where it also mentions the generation of a docstring and __repr__ method should be enough. -- ___ Python tracker

  1   2   3   4   5   6   7   8   9   10   >