Re: [Python-mode] one more myrkwid bug

2011-04-16 Thread Andreas Röhler
Am 16.04.2011 16:38, schrieb Eric S. Johansson: On 4/16/2011 10:00 AM, Georg Brandl wrote: what about `py-indent-honor-multiline-listing' ? I think the "listing" is the strange word here. For me, a listing is a snippet of code printed in a book. I agree. Wouldn't it make sense to say someth

Re: [Python-mode] one more myrkwid bug

2011-04-16 Thread Eric S. Johansson
On 4/16/2011 10:00 AM, Georg Brandl wrote: what about `py-indent-honor-multiline-listing' ? I think the "listing" is the strange word here. For me, a listing is a snippet of code printed in a book. I agree. Wouldn't it make sense to say something like "python-indent-honor-multi-line-indent

Re: [Python-mode] one more myrkwid bug

2011-04-16 Thread Georg Brandl
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 16.04.2011 09:42, schrieb Andreas Röhler: > Am 16.04.2011 13:01, schrieb Georg Brandl: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Am 15.04.2011 23:41, schrieb Andreas Röhler: >>> Am 15.04.2011 22:24, schrieb Barry Warsaw: On Apr

Re: [Python-mode] one more myrkwid bug

2011-04-16 Thread Andreas Röhler
Am 16.04.2011 13:01, schrieb Georg Brandl: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 15.04.2011 23:41, schrieb Andreas Röhler: Am 15.04.2011 22:24, schrieb Barry Warsaw: On Apr 15, 2011, at 10:28 PM, Andreas Röhler wrote: Am 15.04.2011 22:09, schrieb Barry Warsaw: On Apr 15, 2011, at

Re: [Python-mode] one more myrkwid bug

2011-04-16 Thread Georg Brandl
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 15.04.2011 23:41, schrieb Andreas Röhler: > Am 15.04.2011 22:24, schrieb Barry Warsaw: >> On Apr 15, 2011, at 10:28 PM, Andreas Röhler wrote: >> >>> Am 15.04.2011 22:09, schrieb Barry Warsaw: On Apr 15, 2011, at 10:01 PM, Andreas Röhler wrote:

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Barry Warsaw
On Apr 15, 2011, at 11:41 PM, Andreas Röhler wrote: >Am 15.04.2011 22:24, schrieb Barry Warsaw: >> How about then, calling it py-indent-honor-open-paren? > >Also good. > >But let's reflect maybe a little further: >point for me is not just the open paren, but the multiline-form it introduces. >Ope

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Andreas Röhler
Am 15.04.2011 22:24, schrieb Barry Warsaw: On Apr 15, 2011, at 10:28 PM, Andreas Röhler wrote: Am 15.04.2011 22:09, schrieb Barry Warsaw: On Apr 15, 2011, at 10:01 PM, Andreas Röhler wrote: checked in the fix meanwhile. Behavior of trunk now default again. I just grabbed the update and it

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Barry Warsaw
On Apr 15, 2011, at 10:28 PM, Andreas Röhler wrote: >Am 15.04.2011 22:09, schrieb Barry Warsaw: >> On Apr 15, 2011, at 10:01 PM, Andreas Röhler wrote: >> >>> checked in the fix meanwhile. Behavior of trunk now default again. >> >> I just grabbed the update and it looks good. Thanks, I'll use this

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Andreas Röhler
Am 15.04.2011 22:09, schrieb Barry Warsaw: On Apr 15, 2011, at 10:01 PM, Andreas Röhler wrote: checked in the fix meanwhile. Behavior of trunk now default again. I just grabbed the update and it looks good. Thanks, I'll use this version over the weekend. As for the new variable, would pref

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Barry Warsaw
On Apr 15, 2011, at 10:01 PM, Andreas Röhler wrote: >checked in the fix meanwhile. Behavior of trunk now default again. I just grabbed the update and it looks good. Thanks, I'll use this version over the weekend. >As for the new variable, would prefer a pure boolean for simplicity. >Maybe `py-i

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Andreas Röhler
Am 15.04.2011 21:28, schrieb Barry Warsaw: On Apr 15, 2011, at 05:05 PM, Andreas Röhler wrote: Am 15.04.2011 13:49, schrieb Barry Warsaw: Hi Andreas, On Apr 15, 2011, at 08:59 AM, Andreas Röhler wrote: def foo(): x = dict( a=1, b=2, c=3,

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Barry Warsaw
On Apr 15, 2011, at 05:05 PM, Andreas Röhler wrote: >Am 15.04.2011 13:49, schrieb Barry Warsaw: >> Hi Andreas, >> >> On Apr 15, 2011, at 08:59 AM, Andreas Röhler wrote: >> >>> def foo(): >>> x = dict( >>> a=1, >>> b=2, >>> c=3, >>> ) >>>

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Andreas Röhler
Am 15.04.2011 13:49, schrieb Barry Warsaw: Hi Andreas, On Apr 15, 2011, at 08:59 AM, Andreas Röhler wrote: def foo(): x = dict( a=1, b=2, c=3, ) which looks okay for me. Except it's a regression from the trunk. Hi Barry, that

Re: [Python-mode] one more myrkwid bug

2011-04-15 Thread Barry Warsaw
Hi Andreas, On Apr 15, 2011, at 08:59 AM, Andreas Röhler wrote: >def foo(): > x = dict( > a=1, > b=2, > c=3, > ) > > >which looks okay for me. Except it's a regression from the trunk. When the open paren ends a line, subsequent lines shoul

Re: [Python-mode] one more myrkwid bug

2011-04-14 Thread Andreas Röhler
Am 14.04.2011 23:09, schrieb Barry Warsaw: On Apr 14, 2011, at 11:18 PM, Andreas Röhler wrote: think we have discussed that with bug #748198: col 8 will be reached _after_ the closing paren, not before. When inside a dict, its pairs get piled up. Unless you want to have that otherwise

Re: [Python-mode] one more myrkwid bug

2011-04-14 Thread Barry Warsaw
On Apr 14, 2011, at 07:59 PM, Eric S. Johansson wrote: >On 4/14/2011 5:18 PM, Andreas Röhler wrote: >> Further fixes still ahead will take a little bit longer probably. >> Maybe we should keep the trunk for some days before a release, to get som >e > more testers. > >I can spend a little time this

Re: [Python-mode] one more myrkwid bug

2011-04-14 Thread Eric S. Johansson
On 4/14/2011 5:18 PM, Andreas Röhler wrote: Further fixes still ahead will take a little bit longer probably. Maybe we should keep the trunk for some days before a release, to get some more testers. I can spend a little time this weekend testing. what do I grab? __

Re: [Python-mode] one more myrkwid bug

2011-04-14 Thread Barry Warsaw
On Apr 14, 2011, at 11:18 PM, Andreas Röhler wrote: >think we have discussed that with bug #748198: > >col 8 will be reached _after_ the closing paren, not before. > >When inside a dict, its pairs get piled up. > >Unless you want to have that otherwise Hi Andreas, yes this is slightly differe

Re: [Python-mode] one more myrkwid bug

2011-04-14 Thread Andreas Röhler
Am 14.04.2011 22:41, schrieb Barry Warsaw: Hi Andreas, One more indentation bug. -snip snip- def foo(): d = dict( -snip snip- Put point after the open paren on the last night and hit return. You'll end up on column 13 on the new line, but you should be on column 8. Hi B

[Python-mode] one more myrkwid bug

2011-04-14 Thread Barry Warsaw
Hi Andreas, One more indentation bug. -snip snip- def foo(): d = dict( -snip snip- Put point after the open paren on the last night and hit return. You'll end up on column 13 on the new line, but you should be on column 8. I think once you've fixed this, myrkwid will be rea