Re: [python-tulip] Add timeout to StreamReader read methods

2015-09-03 Thread Tomasz Elendt
Hi, How about specifying minimal throughput in a form of two values: number of bytes N that have to "arrive" every T seconds? This would solve the problem I guess. Best, Tomasz > On 03 Sep 2015, at 17:04, Victor Stinner wrote: > > Hi, > > I proposed a patch to add timeout to StreamReader rea

Re: [python-tulip] Add timeout to StreamReader read methods

2015-09-03 Thread Yury Selivanov
On 2015-09-03 1:11 PM, Guido van Rossum wrote: I agree (unsurprisingly since it seems I brought it up in the first place :-). I wonder if the parameter name should be other than timeout, since it may surprise people that a readline() with a timeout of 5 secs can take longer than 5 secs to compl

Re: [python-tulip] Add timeout to StreamReader read methods

2015-09-03 Thread Yury Selivanov
On 2015-09-03 11:04 AM, Victor Stinner wrote: Hi, I proposed a patch to add timeout to StreamReader read methods: http://bugs.python.org/issue23236 I'm +1, but there are some subtleties that I want to better understand: The idea is to reset the timeout each time we receive new data. It is l

Re: [python-tulip] Add timeout to StreamReader read methods

2015-09-03 Thread Guido van Rossum
I agree (unsurprisingly since it seems I brought it up in the first place :-). I wonder if the parameter name should be other than timeout, since it may surprise people that a readline() with a timeout of 5 secs can take longer than 5 secs to complete. But I have no good suggestion for a better nam

[python-tulip] Add timeout to StreamReader read methods

2015-09-03 Thread Victor Stinner
Hi, I proposed a patch to add timeout to StreamReader read methods: http://bugs.python.org/issue23236 The idea is to reset the timeout each time we receive new data. It is less strict than wait(read(), timeout) which restricts the total duration. The subtle risk is that a server can "DoS" a clien