Re: [python-tulip] Please try with the patch from Issue 25593

2015-11-18 Thread Aymeric Augustin
Hello, With this change, the patch for issue 25593 no longer causes problems :-) I believe it makes the websockets tests more robust and predictable as well. Thank you! -- Aymeric. > On 18 nov. 2015, at 16:42, Guido van Rossum wrote: > > The way to fix that test helper is: > >loop.cal

Re: [python-tulip] Please try with the patch from Issue 25593

2015-11-18 Thread Guido van Rossum
The way to fix that test helper is: loop.call_soon(loop.stop) loop.run_forever() On Wed, Nov 18, 2015 at 1:00 AM, Aymeric Augustin wrote: > Hello Guido, > > I ran the test suite of websockets with this patch. It's interesting because > the tests stop the event loop in various ways when t

Re: [python-tulip] Please try with the patch from Issue 25593

2015-11-18 Thread Aymeric Augustin
Hello Guido, I ran the test suite of websockets with this patch. It's interesting because the tests stop the event loop in various ways when testing error conditions. Tests lock in this helper — I can't say I'm surprised: https://github.com/aaugustin/websockets/blob/212fed7/websockets/test_protoc