[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. IIRC, the reason for purging is this: https://phabricator.wikimedia.org/T114318 TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa, Aklapp

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. Can we detect when the expected class attributes/etc are missing, and only purge when they are missing? (or is the code already doing that?) TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/em

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa, Aklap

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. Is it harmful just set write = True for those test classes? TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa, Aklapper, jayvdb ___

[Pywikipedia-bugs] [Maniphest] [Commented On] T129001: listpages -cat throws exception

2016-03-06 Thread gerritbot
gerritbot added a comment. Change 275272 merged by jenkins-bot: Fix -cat pagegenerator https://gerrit.wikimedia.org/r/275272 TASK DETAIL https://phabricator.wikimedia.org/T129001 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc:

[Pywikipedia-bugs] [Maniphest] [Created] T129009: deprecated_args should present a better message for positional arguments

2016-03-06 Thread jayvdb
jayvdb created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION The deprecation warning for positional arguments should be more clear. see discussion at https://gerrit.wikimedia.org/r/#/c/275272/2/pywikibot/pagegenerators.py,cm TASK DETAIL https://phabri

[Pywikipedia-bugs] [Maniphest] [Triaged] T129009: deprecated_args should present a better message for positional arguments

2016-03-06 Thread jayvdb
jayvdb triaged this task as "Lowest" priority. TASK DETAIL https://phabricator.wikimedia.org/T129009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, jayvdb, pywikibot-bugs-list ___ py

[Pywikipedia-bugs] [Maniphest] [Created] T129010: Make APIGenerator a subclass of QueryGenerator

2016-03-06 Thread Xqt
Xqt created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION See discussion in https://gerrit.wikimedia.org/r/#/c/179586/5/pywikibot/data/api.py,unified TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Triaged] T129010: Make APIGenerator a subclass of QueryGenerator

2016-03-06 Thread Xqt
Xqt triaged this task as "Normal" priority. TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, Aklapper, Xqt, pywikibot-bugs-list ___ pyw

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. In https://phabricator.wikimedia.org/T128994#2092324, @Mpaa wrote: > I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): Yes, I see that. Hmm. Then the test suite is regularly purging the page, and these attributes, etc are dis

[Pywikipedia-bugs] [Maniphest] [Created] T129013: Use APIGenerator with APISite._generator

2016-03-06 Thread Xqt
Xqt created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION This was suggested in https://gerrit.wikimedia.org/r/#/c/179586/2/pywikibot/site.py,unified TASK DETAIL https://phabricator.wikimedia.org/T129013 EMAIL PREFERENCES https://phabricator.wikimedi

[Pywikipedia-bugs] [Maniphest] [Updated] T129010: Make APIGenerator a subclass of QueryGenerator

2016-03-06 Thread Xqt
Xqt added a blocking task: T129013: Use APIGenerator with APISite._generator. TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, Aklapper, Xqt, pywikibot-bugs-list _

[Pywikipedia-bugs] [Maniphest] [Updated] T129013: Use APIGenerator with APISite._generator

2016-03-06 Thread Xqt
Xqt added a blocked task: T129010: Make APIGenerator a subclass of QueryGenerator. TASK DETAIL https://phabricator.wikimedia.org/T129013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, Xqt, pywikibot-bugs-list ___

[Pywikipedia-bugs] [Maniphest] [Commented On] T129013: Use APIGenerator with APISite._generator

2016-03-06 Thread gerritbot
gerritbot added a comment. Change 275169 had a related patch set uploaded (by Xqt): [IMPR] Use api.APIGenerator through site._generator https://gerrit.wikimedia.org/r/275169 TASK DETAIL https://phabricator.wikimedia.org/T129013 EMAIL PREFERENCES https://phabricator.wikimedia.org/se

[Pywikipedia-bugs] [Maniphest] [Updated] T129013: Use APIGenerator with APISite._generator

2016-03-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T129013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: gerritbot, Aklapper, Xqt, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T129013: Use APIGenerator with APISite._generator

2016-03-06 Thread Xqt
Xqt added a subscriber: jayvdb. TASK DETAIL https://phabricator.wikimedia.org/T129013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, gerritbot, Aklapper, Xqt, pywikibot-bugs-list ___ pywi

[Pywikipedia-bugs] [Maniphest] [Triaged] T129013: Use APIGenerator with APISite._generator

2016-03-06 Thread Xqt
Xqt triaged this task as "Normal" priority. TASK DETAIL https://phabricator.wikimedia.org/T129013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, gerritbot, Aklapper, Xqt, pywikibot-bugs-list

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. In https://phabricator.wikimedia.org/T128994#2092448, @jayvdb wrote: > In https://phabricator.wikimedia.org/T128994#2092324, @Mpaa wrote: > > > I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): > > > Yes, I see that. Hmm. Then

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. The travis builds work with a clean cache for each job, so I doubt the caching is the only problem here. TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: pywi

[Pywikipedia-bugs] [Maniphest] [Commented On] T129010: Make APIGenerator a subclass of QueryGenerator

2016-03-06 Thread jayvdb
jayvdb added a comment. My 'gut' feeling is that QueryGenerator should be a subclass of APIGenerator. TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, Aklapper, Xqt, pywikibot

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. It was failing on my PC. I cleared ~/python/core/tests/apicache-py2. Is this cache also cleared? TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread jayvdb
jayvdb added a comment. In https://phabricator.wikimedia.org/T128994#2092569, @Mpaa wrote: > It was failing on my PC. I cleared ~/python/core/tests/apicache-py2 and now it is OK. > Is this cache also cleared? Each travis job start with a cold cache. the proofread page tests ar

[Pywikipedia-bugs] [Maniphest] [Commented On] T129010: Make QueryGenerator a subclass of APIGenerator

2016-03-06 Thread Xqt
Xqt added a comment. @jayvdb: sorry I meant it vice versa. Changed the title. TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, Aklapper, Xqt, pywikibot-bugs-list _

[Pywikipedia-bugs] [Maniphest] [Retitled] T129010: Make QueryGenerator a subclass of APIGenerator

2016-03-06 Thread Xqt
Xqt changed the title from "Make APIGenerator a subclass of QueryGenerator" to "Make QueryGenerator a subclass of APIGenerator". TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: jayvdb, Ak

[Pywikipedia-bugs] [Maniphest] [Created] T129017: Remove default values in panoramiopicker script

2016-03-06 Thread darthbhyrava
darthbhyrava created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION The panoramiopicker script uses default values for all parameters, which is undesirable. (refer to T93098 ) TASK DETAIL https://phabricator.wiki

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T129017: Remove default values in panoramiopicker script

2016-03-06 Thread darthbhyrava
darthbhyrava added a subscriber: jayvdb. TASK DETAIL https://phabricator.wikimedia.org/T129017 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava Cc: jayvdb, Aklapper, pywikibot-bugs-list, darthbhyrava, tahteche __

[Pywikipedia-bugs] [Maniphest] [Commented On] T128992: site detection failures

2016-03-06 Thread Xqt
Xqt added a comment. I got: C:\pwb\GIT\core>pwb.py tests/site_detect_tests -v SiteDetectionTestCase.test_det ect_failure tests: max_retries reduced from 25 to 1 test_detect_failure (__main__.SiteDetectionTestCase) Test detection failure for MediaWiki sites with an API. .

[Pywikipedia-bugs] [Maniphest] [Commented On] T129017: Remove default values in panoramiopicker script

2016-03-06 Thread gerritbot
gerritbot added a comment. Change 275276 had a related patch set uploaded (by Darthbhyrava): Change: Remove default values in panoramiopicker script https://gerrit.wikimedia.org/r/275276 TASK DETAIL https://phabricator.wikimedia.org/T129017 EMAIL PREFERENCES https://phabricator.wik

[Pywikipedia-bugs] [Maniphest] [Updated] T129017: Remove default values in panoramiopicker script

2016-03-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T129017 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, gerritbot Cc: gerritbot, jayvdb, Aklapper, pywikibot-bugs-list, darthbhyrava, tahteche

[Pywikipedia-bugs] [Maniphest] [Created] T129021: ReferringPageGenerator only returns 500 pages instead of all

2016-03-06 Thread Multichill
Multichill created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION I dusted off an old bot that used to work. It uses the following code to get all items that use a certain property: repo = pywikibot.Site().data_repository() ppage = pywikibot.Prop

[Pywikipedia-bugs] [Maniphest] [Triaged] T129021: ReferringPageGenerator only returns 500 pages instead of all

2016-03-06 Thread Multichill
Multichill triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T129021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Multichill Cc: Aklapper, pywikibot-bugs-list, Multichill

[Pywikipedia-bugs] [Maniphest] [Commented On] T93098: Remove default values in flickrripper script

2016-03-06 Thread darthbhyrava
darthbhyrava added a comment. I've added reviewers from my end, but would be glad is someone could +2 both this and T129017 ? Thanks! TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Pywikipedia-bugs] [Maniphest] [Commented On] T129021: ReferringPageGenerator only returns 500 pages instead of all

2016-03-06 Thread Xqt
Xqt added a comment. C:\pwb\GIT\core>pwb.py shell Welcome to the Pywikibot interactive shell! >>> import pywikibot >>> s = pywikibot.Site() >>> repo = s.data_repository() >>> pp = pywikibot.PropertyPage(repo, 'Property:P197') >>> from pywikibot import pagegenerators as

[Pywikipedia-bugs] [Maniphest] [Updated] T129021: ReferringPageGenerator only returns 500 pages instead of all

2016-03-06 Thread Multichill
Multichill added a comment. Looks like the local copy got stuck in a really old version: $ git pull Updating https://phabricator.wikimedia.org/rPWBC783b33c61495d6d80e17f841620ac0581d41e567..https://phabricator.wikimedia.org/rPWBCd82b9c3a62cad81fb1e44d1c42ca68ebb3c32dbc fatal: Not a gi

[Pywikipedia-bugs] [Maniphest] [Closed] T129021: ReferringPageGenerator only returns 500 pages instead of all

2016-03-06 Thread Multichill
Multichill closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T129021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Multichill Cc: Xqt, Aklapper, pywikibot-bugs-list, Multichill _

[Pywikipedia-bugs] [Maniphest] [Closed] T129017: Remove default values in panoramiopicker script

2016-03-06 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T129017 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, Xqt Cc: gerritbot, jayvdb, Aklapper, pywikibot-bugs-list, darthbhyrava, tahteche ___

[Pywikipedia-bugs] [Maniphest] [Commented On] T129017: Remove default values in panoramiopicker script

2016-03-06 Thread gerritbot
gerritbot added a comment. Change 275276 merged by jenkins-bot: Change: Remove default values in panoramiopicker script https://gerrit.wikimedia.org/r/275276 TASK DETAIL https://phabricator.wikimedia.org/T129017 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/ema

[Pywikipedia-bugs] [Maniphest] [Closed] T93098: Remove default values in flickrripper script

2016-03-06 Thread darthbhyrava
darthbhyrava closed this task as "Resolved". darthbhyrava added a comment. The patch has been merged, hence closing the task. TASK DETAIL https://phabricator.wikimedia.org/T93098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava Cc: Xqt

[Pywikipedia-bugs] [Maniphest] [Commented On] T76211: pywikibot external pycolorname used by catimages.py

2016-03-06 Thread DrTrigon
DrTrigon added a comment. > 1. Could you elaborate on how to do this ? I am not familiar with how to credit appropriately. The questions I have on this point are: > - Where else should I credit developers ? (Currently Ive written your name as author in pypi and my name as maintainer - eac

[Pywikipedia-bugs] [Maniphest] [Commented On] T128994: Some proofread page tests are writing to the wiki without being declared as write tests

2016-03-06 Thread Mpaa
Mpaa added a comment. Is this always failing or randomly? TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: pywikibot-bugs-list, Mpaa, Aklapper, jayvdb ___

[Pywikipedia-bugs] [Maniphest] [Edited] T66838: Port catimages.py to core

2016-03-06 Thread AbdealiJK
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T66838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Vlkyrie, darthbhyrava, Sumit, DrTrigon, AbdealiJK, StudiesWorld, Shrutika719, Avicennasis, Aklap

[Pywikipedia-bugs] [Maniphest] [Updated] T129010: Make QueryGenerator a subclass of APIGenerator

2016-03-06 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, jayvdb, Aklapper, Xqt, pywikibot-bugs-list _

[Pywikipedia-bugs] [Maniphest] [Commented On] T129010: Make QueryGenerator a subclass of APIGenerator

2016-03-06 Thread gerritbot
gerritbot added a comment. Change 275297 had a related patch set uploaded (by Xqt): [WIP] Make QueryGenerator a subclass of APIGenerator https://gerrit.wikimedia.org/r/275297 TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/s

[Pywikipedia-bugs] [Maniphest] [Claimed] T129010: Make QueryGenerator a subclass of APIGenerator

2016-03-06 Thread Xqt
Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T129010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: gerritbot, jayvdb, Aklapper, Xqt, pywikibot-bugs-list ___ pywikibot-bug

[Pywikipedia-bugs] [Maniphest] [Closed] T119904: Replace casechecker.SetColor with color_formatter

2016-03-06 Thread darthbhyrava
darthbhyrava closed this task as "Resolved". darthbhyrava claimed this task. darthbhyrava added a subscriber: valhallasw. darthbhyrava added a comment. Well, @valhallasw told me on IRC that commit messages can't be edited after merge, unfortunately. Closing it, then. TASK DETAIL https://

[Pywikipedia-bugs] [Maniphest] [Commented On] T128992: site detection failures

2016-03-06 Thread jayvdb
jayvdb added a comment. Regarding hackerspaces.org, see https://gerrit.wikimedia.org/r/#/c/269929/ TASK DETAIL https://phabricator.wikimedia.org/T128992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Xqt, Aklapper, pywikibot-bugs-list,

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T89670: Implement Coordinate.precisionToDim

2016-03-06 Thread darthbhyrava
darthbhyrava added a subscriber: jayvdb. darthbhyrava added a comment. @jayvdb - I've added in the test at wikibase_tests as required. Could you take a look at the above patch, please? TASK DETAIL https://phabricator.wikimedia.org/T89670 EMAIL PREFERENCES https://phabricator.wikimedia.

[Pywikipedia-bugs] [Maniphest] [Commented On] T128992: site detection failures

2016-03-06 Thread jayvdb
jayvdb added a comment. ok, maybe the hackerspaces problem is Python version specific (and maybe unittest vs unittest2). TASK DETAIL https://phabricator.wikimedia.org/T128992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Xqt, Aklappe

[Pywikipedia-bugs] [Maniphest] [Commented On] T89067: Pywikibot: Implement support for a large core MediaWiki component or extension deployed to Wikimedia sites

2016-03-06 Thread jayvdb
jayvdb added a comment. Re https://phabricator.wikimedia.org/tag/mediawiki-extensions-smitespam/ , it doesnt appear to be deployed to Wikimedia sites, so it is not eligible for this project. Here is the list of sites it is deployed to : https://wikiapiary.com/wiki/Extension:SmiteSpam @

[Pywikipedia-bugs] [Maniphest] [Edited] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

2016-03-06 Thread RedWolf
RedWolf edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T119855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: RedWolf Cc: pywikibot-bugs-list, Aklapper, RedWolf, StudiesWorld

[Pywikipedia-bugs] [Maniphest] [Commented On] T89067: Pywikibot: Implement support for a large core MediaWiki component or extension deployed to Wikimedia sites

2016-03-06 Thread darthbhyrava
darthbhyrava added a comment. I have made progress with my assigned microtask T89670 , and would be glad if someone could review my patch to fix it. I'll also take up the other open microtask (T90422 ), too.

[Pywikipedia-bugs] [Maniphest] [Claimed] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread darthbhyrava
darthbhyrava claimed this task. darthbhyrava added a comment. I'll take up this microtask. :D TASK DETAIL https://phabricator.wikimedia.org/T90422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava Cc: darthbhyrava, Xqt, XZise, jayvdb, M

[Pywikipedia-bugs] [Maniphest] [Updated] T119904: Replace casechecker.SetColor with color_formatter

2016-03-06 Thread jayvdb
jayvdb added a commit: rPWBC300c0b6f1ae5: Replaced SetColor with color_format. TASK DETAIL https://phabricator.wikimedia.org/T119904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, jayvdb Cc: valhallasw, darthbhyrava, Aklapper, pywikibot

[Pywikipedia-bugs] [Maniphest] [Updated] T119904: Replace casechecker.SetColor with color_formatter

2016-03-06 Thread jayvdb
jayvdb added a comment. The change was https://phabricator.wikimedia.org/rPWBC300c0b6f1ae56709809b539cb234cc45a4ff0712 , and we can link task and commit on the Phabricator page for the commit, as I have done. TASK DETAIL https://phabricator.wikimedia.org/T119904 EMAIL PREFERENCES https

[Pywikipedia-bugs] [Maniphest] [Reassigned] T119904: Replace casechecker.SetColor with color_formatter

2016-03-06 Thread jayvdb
jayvdb reassigned this task from darthbhyrava to Yujwey. TASK DETAIL https://phabricator.wikimedia.org/T119904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Yujwey, jayvdb Cc: valhallasw, darthbhyrava, Aklapper, pywikibot-bugs-list, jayvdb, tahteche

[Pywikipedia-bugs] [Maniphest] [Commented On] T115428: imageharvest and panoramiopicker uses BeautifulSoup version 3 instead of bs4

2016-03-06 Thread AbdealiJK
AbdealiJK added a comment. @darthbhyrava In imageharvest: You could possible mock the `URLopener.open()` function to simply return something like some link And make sure it returns 1 link for that. Something similar for `getLicense` can be done. @jayvdb Does that sou

[Pywikipedia-bugs] [Maniphest] [Commented On] T89067: Pywikibot: Implement support for a large core MediaWiki component or extension deployed to Wikimedia sites

2016-03-06 Thread Sumit
Sumit added a comment. In https://phabricator.wikimedia.org/T89067#2093320, @darthbhyrava wrote: > As for the extension to work with, I have gone through the list, I would like to go ahead with https://phabricator.wikimedia.org/tag/mediawiki-extensions-abusefilter/, or https://phabricat

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T85656: Pywikibot to detect and correctly handle edits that trigger abusefilter rules

2016-03-06 Thread jayvdb
jayvdb moved this task to Missing Mentors on the Possible-Tech-Projects workboard. TASK DETAIL https://phabricator.wikimedia.org/T85656 WORKBOARD https://phabricator.wikimedia.org/project/board/1042/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T57081: Implement support for Flagged Revisions in Pywikibot

2016-03-06 Thread jayvdb
jayvdb moved this task to Missing Mentors on the Possible-Tech-Projects workboard. TASK DETAIL https://phabricator.wikimedia.org/T57081 WORKBOARD https://phabricator.wikimedia.org/project/board/1042/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Pywikipedia-bugs] [Maniphest] [Created] T129049: Pywikibot support for Thanks

2016-03-06 Thread jayvdb
jayvdb created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. Herald added a project: Collaboration-Team-Backlog. TASK DESCRIPTION https://phabricator.wikimedia.org/tag/thanks/ extension allows positive feedback on revisions by logged in users. Pywikibot does not suppo

[Pywikipedia-bugs] [Maniphest] [Edited] T89067: Pywikibot: Implement support for a large core MediaWiki component or extension deployed to Wikimedia sites

2016-03-06 Thread jayvdb
jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T89067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Legoktm, polybuildr, darthbhyrava, Sumit, 01tonythomas, Anmolkalia, Mpaa, Ricordisamoa, Qgil, pywikibo

[Pywikipedia-bugs] [Maniphest] [Updated] T129049: Pywikibot support for Thanks

2016-03-06 Thread jayvdb
jayvdb added a project: Possible-Tech-Projects. TASK DETAIL https://phabricator.wikimedia.org/T129049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, darthbhyrava, jayvdb, pywikibot-bugs-list, Catrope, Jay8g, Quiddity, Legoktm

[Pywikipedia-bugs] [Maniphest] [Triaged] T129049: Pywikibot support for Thanks

2016-03-06 Thread jayvdb
jayvdb triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T129049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, darthbhyrava, jayvdb, pywikibot-bugs-list, Catrope, Jay8g, Quiddity, Legoktm ___

[Pywikipedia-bugs] [Maniphest] [Raised Priority] T85656: Pywikibot to detect and correctly handle edits that trigger abusefilter rules

2016-03-06 Thread jayvdb
jayvdb raised the priority of this task from "Lowest" to "Normal". jayvdb added a comment. There are a few abusefilter related problems in pywikibot, so this project would be quite valuable to flesh them out and fix them. TASK DETAIL https://phabricator.wikimedia.org/T85656 EMAIL PREFERENC

[Pywikipedia-bugs] [Maniphest] [Commented On] T115428: imageharvest and panoramiopicker uses BeautifulSoup version 3 instead of bs4

2016-03-06 Thread jayvdb
jayvdb added a comment. In https://phabricator.wikimedia.org/T115428#2069993, @darthbhyrava wrote: > According to Beautiful Soup's documentation ( https://goo.gl/HfQifz ) we need to change the import statements and check for specific method names while porting to bs4. > This can be e

[Pywikipedia-bugs] [Maniphest] [Commented On] T85656: Pywikibot to detect and correctly handle edits that trigger abusefilter rules

2016-03-06 Thread Sumit
Sumit added a comment. In https://phabricator.wikimedia.org/T85656#2093393, @jayvdb wrote: > There are a few abusefilter related problems in pywikibot, so this project would be quite valuable to flesh them out and fix them. As soon as this task gets a co-mentor, we can have it fea

[Pywikipedia-bugs] [Maniphest] [Unblock] T128991: test_pagegen_i18n_input failing: setlocale: LC_ALL: cannot change locale (arz): No such file or directory

2016-03-06 Thread jayvdb
jayvdb closed blocking task T129001: listpages -cat throws exception as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T128991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list _

[Pywikipedia-bugs] [Maniphest] [Closed] T129001: listpages -cat throws exception

2016-03-06 Thread jayvdb
jayvdb closed this task as "Resolved". jayvdb claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T129001 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: gerritbot, pywikibot-bugs-list, Aklapper, jayvdb _

[Pywikipedia-bugs] [Maniphest] [Commented On] T119855: Attempting to login with pwb.py results in Permission denied on Mac OS X

2016-03-06 Thread jayvdb
jayvdb added a comment. Could you give us the output of `python pwb.py version` please TASK DETAIL https://phabricator.wikimedia.org/T119855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, pywikibot-bugs-list, Aklapper, RedWolf,

[Pywikipedia-bugs] [Maniphest] [Block] T68275: implement Echo support (notifications)

2016-03-06 Thread jayvdb
jayvdb created blocking task T129051: Echo tests. TASK DETAIL https://phabricator.wikimedia.org/T68275 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ricordisamoa, jayvdb Cc: jayvdb, Ricordisamoa, pywikibot-bugs-list, zhuyifei1999

[Pywikipedia-bugs] [Maniphest] [Created] T129051: Echo tests

2016-03-06 Thread jayvdb
jayvdb created this task. Herald added a subscriber: Aklapper. TASK DESCRIPTION Add tests for pywikibot.echo and pywikibot.site.APISite.notifications Tests should be added to a new module `tests/echo_tests.py` TASK DETAIL https://phabricator.wikimedia.org/T129051 EMAIL PREFERENCES htt

[Pywikipedia-bugs] [Maniphest] [Retitled] T129051: Pywikibot Echo tests

2016-03-06 Thread jayvdb
jayvdb changed the title from "Echo tests" to "Pywikibot Echo tests". jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T129051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, zhuyifei1999, pywikibo

[Pywikipedia-bugs] [Maniphest] [Edited] T129049: Pywikibot support for Thanks

2016-03-06 Thread jayvdb
jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T129049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, darthbhyrava, jayvdb, pywikibot-bugs-list, Catrope, Jay8g, Quiddity, Legoktm ___

[Pywikipedia-bugs] [Maniphest] [Commented On] T129051: Pywikibot Echo tests

2016-03-06 Thread jayvdb
jayvdb added a comment. The hard part with this will be setting up test data. The automated test suite runs using the account `Pywikibot-test` , so we would need to set up data so that the `Pywikibot-test` account receives a notification

[Pywikipedia-bugs] [Maniphest] [Commented On] T129051: Pywikibot Echo tests

2016-03-06 Thread jayvdb
jayvdb added a comment. The easiest way to start this task is to create some dry tests, which create a `Notification` object using `Notification.fromJSON` with `data` being a hand-coded dict. TASK DETAIL https://phabricator.wikimedia.org/T129051 EMAIL PREFERENCES https://phabricator.wik

[Pywikipedia-bugs] [Maniphest] [Edited] T129049: Pywikibot support for Thanks

2016-03-06 Thread jayvdb
jayvdb edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T129049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, darthbhyrava, jayvdb, pywikibot-bugs-list, Catrope, Jay8g, Quiddity, Legoktm ___

[Pywikipedia-bugs] [Maniphest] [Commented On] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread Xqt
Xqt added a comment. @darthbhyrava what is to claim here? TASK DETAIL https://phabricator.wikimedia.org/T90422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, Xqt Cc: darthbhyrava, Xqt, XZise, jayvdb, Mpaa, gerritbot, pywikibot-bugs-

[Pywikipedia-bugs] [Maniphest] [Closed] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread Xqt
Xqt closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T90422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, Xqt Cc: darthbhyrava, Xqt, XZise, jayvdb, Mpaa, gerritbot, pywikibot-bugs-list, Aklapper, Rubin16

[Pywikipedia-bugs] [Maniphest] [Commented On] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread jayvdb
jayvdb added a comment. I dont understand why this is invalid. I think @xsize is correct in his earlier comment https://phabricator.wikimedia.org/T90422#1070932 TASK DETAIL https://phabricator.wikimedia.org/T90422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Pywikipedia-bugs] [Maniphest] [Commented On] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread Xqt
Xqt added a comment. This is a redirect to the description page. {{nobots}} and {{bots}} doesn't have the same behaviour. TASK DETAIL https://phabricator.wikimedia.org/T90422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, Xqt Cc: d

[Pywikipedia-bugs] [Maniphest] [Reopened] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread jayvdb
jayvdb reopened this task as "Open". jayvdb added a comment. I've reproduced the problem https://test.wikipedia.org/w/index.php?title=User:John_Vandenberg/nobots&diff=263125&oldid=212560 If `{{nobots|deny=...}}` is not valid syntax, for nobots, then Pywikibot should fail either with a

[Pywikipedia-bugs] [Maniphest] [Commented On] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread Xqt
Xqt added a comment. I disagree. Bot's {{bots}}/{{nobots}} behaviour must reflect the common use of enabling/disabling bot edits. We should not introduce a new set of templates and parameters. Others would use other templates the bot does not understand. Vice versa is the right way. Users sh

[Pywikipedia-bugs] [Maniphest] [Commented On] T66838: Port catimages.py to core

2016-03-06 Thread DrTrigon
DrTrigon added a comment. deps: Don't forget to consider binary tools like e.g. "exiftool"... there is a bunch of these. TASK DETAIL https://phabricator.wikimedia.org/T66838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DrTrigon Cc: Vlkyrie, Su

[Pywikipedia-bugs] [Maniphest] [Commented On] T90422: reflinks.py ignores {{nobots}}

2016-03-06 Thread jayvdb
jayvdb added a comment. In https://phabricator.wikimedia.org/T90422#2093544, @Xqt wrote: > I disagree. Bot's {{bots}}/{{nobots}} behaviour must reflect the common use of enabling/disabling bot edits. We should not introduce a new set of templates and parameters. I agree. `nobots

[Pywikipedia-bugs] [Maniphest] [Commented On] T66838: Port catimages.py to core

2016-03-06 Thread jayvdb
jayvdb added a comment. Thanks @DrTrigon , I had forgotten about those. These binary tools will need to be added to `.travis.yml` list `addons: apt: packages:` (or replaced with python packages if there is a suitable equivalent). TASK DETAIL https://phabricator.wikimedia.org/T66

[Pywikipedia-bugs] [Maniphest] [Commented On] T76211: pywikibot external pycolorname used by catimages.py

2016-03-06 Thread AbdealiJK
AbdealiJK added a comment. Hey, I believe everything has been already addressed except the following: JSON vs pickle -- Even if speed is worse in json, I'd prefer it because human readable. We do not have a complicated class that requires pickling. This can easil

[Pywikipedia-bugs] [Maniphest] [Commented On] T76211: pywikibot external pycolorname used by catimages.py

2016-03-06 Thread AbdealiJK
AbdealiJK added a comment. Just for completeness sake I tried out the profiler mentioned in the SO post for json vs pickle: $ python profiler.py pickle: 5.83598685265 json: 0.551915884018 I had to change this for 1000 runs as the default (100) took too long.