[Pywikipedia-bugs] [Maniphest] [Commented On] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot

zhuyifei1999 added a comment. I thought of some ways to fix/workaround this issue: - WONTFIX for python 2 and move on to python 3 - really? Tool labs still have python 2 by default. - Use the hack mentioned in StackOverflow (replace every \n with \r\n) - since we are working with binar

[Pywikipedia-bugs] [Maniphest] [Updated] T102315: pywikibot support for https-only

Andrew removed projects: Operations, Traffic, HTTPS. TASK DETAIL https://phabricator.wikimedia.org/T102315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Andrew Cc: Andrew, StudiesWorld, Ricordisamoa, XZise, BBlack, Nemo_bis, Tony_Tan_98, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Updated] T102315: pywikibot support for https-only

Andrew removed a project: Operations. Andrew added a comment. Herald added a project: Operations. As I understand it, this ticket is a request for updates to the pywikibot code. I'm going to remove the Operations tag; please re-add with a clear request if you need something from Ops. TASK D

[Pywikipedia-bugs] [Maniphest] [Retitled] T132676: Impossible to upload a file that ends with the '\r' byte using Pywikibot

matmarex changed the title from "Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-too-small error" to "Impossible to upload a file that ends with the '\r' byte using Pywikibot". TASK DETAIL https:/

[Pywikipedia-bugs] [Maniphest] [Triaged] T132676: Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-too-sma

jayvdb triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T132676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: pywikibot-bugs-list, Matanya, matmarex, czar, Aklapper, Steinsplitter, zhuyifei1999, Bawolff

[Pywikipedia-bugs] [Maniphest] [Commented On] T132676: Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-to

matmarex added a comment. Oooh, wait. I'm pretty sure that according to the spec, the request body should be using \r\n (CRLF) for line breaks, not just \n (LF). I guess the server is permissive and accepts it anyway, and in this case it can't tell that the '\r' wasn't meant to be part of th

[Pywikipedia-bugs] [Maniphest] [Commented On] T132676: Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-to

matmarex added a comment. It could potentially be a WMF severs' misconfiguration, too. The log you pasted above seems to have it handled correctly: Content-disposition: form-data; name="chunk"; filename="FAKE-NAME"\nContent-Transfer-Encoding: binary\n\n\r\n Note the '\r'. TAS

[Pywikipedia-bugs] [Maniphest] [Updated] T132676: Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-too-sma

zhuyifei1999 removed a project: MediaWiki-Uploading. TASK DETAIL https://phabricator.wikimedia.org/T132676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: zhuyifei1999 Cc: pywikibot-bugs-list, Matanya, matmarex, czar, Aklapper, Steinsplitter, zhuyife

[Pywikipedia-bugs] [Maniphest] [Commented On] T132676: Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-to

zhuyifei1999 added a comment. The interesting thing is, the last byte is a \r character: $ cat /srv/v2c/ssu/temp.webm | xxd -b | tail 775dc1c: 10001101 0111 1001 0001 0001 1100 .. 775dc22: 0110 0110 0011 0011 1010 ..{?..

[Pywikipedia-bugs] [Maniphest] [Updated] T132676: Uploading 125164627-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-too-sma

zhuyifei1999 added a project: pywikibot-core. zhuyifei1999 added a comment. Herald added a subscriber: pywikibot-bugs-list. Indeed: 01:45:56 0 ✓ zhuyifei1999@encoding01: ~$ ls -al /srv/v2c/ssu/temp.webm -rw-r--r-- 1 root root 125164628 Apr 14 12:10 /srv/v2c/ssu/temp.webm I guess

[Pywikipedia-bugs] [Maniphest] [Retitled] T132676: Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-too-sm

zhuyifei1999 changed the title from "Uploading 125164627-byte file using 4MiB chunked uploading results in unexpected offset on final chunk (1 byte less than file size) then chunk-too-small error" to "Uploading 125164628-byte file using 4MiB chunked uploading results in unexpected offset on fi

[Pywikipedia-bugs] [Maniphest] [Updated] T60942: Features to move from scripts to framework (tracking)

Xqt added a comment. Remaining issues when https://phabricator.wikimedia.org/T89499 would be merged $ grep -r "from scripts" * scripts/casechecker.py:from scripts.category import CategoryMoveRobot as CategoryMoveBot scripts/cfd.py:from scripts.category import CategoryMoveRobot a

[Pywikipedia-bugs] [Maniphest] [Updated] T89499: Refactor upload.py / move re-usable parts to framework

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T89499 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Avicennasis, gerritbot, jayvdb, Liuxinyu970226, pywikibot-bugs-list, Ricordisamoa, valhall

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T89499: Refactor upload.py / move re-usable parts to framework

gerritbot added a comment. Herald added a subscriber: Avicennasis. Change 283422 had a related patch set uploaded (by Xqt): [IMPR] Separate scripts and library part https://gerrit.wikimedia.org/r/283422 TASK DETAIL https://phabricator.wikimedia.org/T89499 EMAIL PREFERENCES https://

[Pywikipedia-bugs] [Maniphest] [Unblock] T57880: [Tracking] Functionality existing in compat but missing from core

Xqt closed blocking task T66856: Port various Commons upload bots to core & move to separate repository as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T57880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: binbot, Aklapper, APer

[Pywikipedia-bugs] [Maniphest] [Closed] T66856: Port various Commons upload bots to core & move to separate repository

Xqt closed this task as "Resolved". Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T66856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Avicennasis, Aklapper, jayvdb, Steinsplitter, gerritbot, valhallasw, droid, Ricord

[Pywikipedia-bugs] [Maniphest] [Commented On] T132663: Improve tests for an expected failure in reflinks_tests

gerritbot added a comment. Change 283401 had a related patch set uploaded (by Xqt): [bugfix] Bugfixes for for XMLDumpOldPageGenerator https://gerrit.wikimedia.org/r/283401 TASK DETAIL https://phabricator.wikimedia.org/T132663 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Pywikipedia-bugs] [Maniphest] [Updated] T132663: Improve tests for an expected failure in reflinks_tests

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T132663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, pywikibot-bugs-list, Xqt, Lewizho99, jayvdb __

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T90422: reflinks.py ignores {{nobots}}

Xqt added a subscriber: Meno25. TASK DETAIL https://phabricator.wikimedia.org/T90422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava, Xqt Cc: Meno25, darthbhyrava, Xqt, XZise, jayvdb, Mpaa, gerritbot, pywikibot-bugs-list, Aklapper, Rubin

[Pywikipedia-bugs] [Maniphest] [Commented On] T90422: reflinks.py ignores {{nobots}}

Xqt added a comment. > We could also create a script that finds any pages using nobots/bots with unrecognised syntax and the script could fix the page syntax. We should start at ar-wiki. They try to localize that template. I am strongly against localizing bot directives. They must be a c

[Pywikipedia-bugs] [Maniphest] [Edited] T132663: Improve tests for an expected failure in reflinks_tests

Xqt edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T132663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Xqt, jayvdb ___ pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T129368: Usages of unittest.expectedFailure should be solved

Xqt edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T129368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list _

[Pywikipedia-bugs] [Maniphest] [Updated] T129368: Usages of unittest.expectedFailure should be solved

Xqt added a blocking task: T132663: Improve tests for an expected failure in reflinks_tests. TASK DETAIL https://phabricator.wikimedia.org/T129368 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Updated] T132663: Improve tests for an expected failure in reflinks_tests

Xqt added a blocked task: T129368: Usages of unittest.expectedFailure should be solved. TASK DETAIL https://phabricator.wikimedia.org/T132663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Xqt, jayvdb __

[Pywikipedia-bugs] [Maniphest] [Created] T132663: Improve tests for an expected failure in reflinks_tests

Xqt created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION expectedFailure does not recognize whether an expected failure occurred. It ignores every fault inside the test. For `test_namespace_none` there should be a test against raising TypeError when

[Pywikipedia-bugs] [Maniphest] [Created] T132659: Conda-based packaging for Windows

valhallasw created this task. Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION (not a full-featured plan yet). Currently, installing dependencies on Windows is difficult for many of our users. Conda allows for relatively easy 'virtual environments' (sort of) on Wi