[Pywikipedia-bugs] [Maniphest] [Updated] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185369EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113

[Pywikipedia-bugs] [Maniphest] [Commented On] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

gerritbot added a comment. Change 405396 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] dev-requirements.txt: Add setuptools_scm to Python 2.6 requirements https://gerrit.wikimedia.org/r/405396TASK DETAILhttps://phabricator.wikimedia.org/T185369EMAIL PREFERENCES

[Pywikipedia-bugs] [Maniphest] [Claimed] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

Dalba claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T185369EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista

[Pywikipedia-bugs] [Maniphest] [Unassigned] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

Dalba removed Dalba as the assignee of this task.Dalba added a comment. Simply adding setuptools_scm ; python_version == '2.6' to requirement.txt does not work. Because requirements.txt is not installed on appveyor builds. We may use dev-requirements.txt instead.TASK DETAILhttps://phabricator.wikim

[Pywikipedia-bugs] [Maniphest] [Claimed] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

Dalba claimed this task.Dalba added a comment. Sounds like https://github.com/pypa/setuptools_scm/issues/209 They've suggested to install setuptools_scm by pip as a temporary workaround.TASK DETAILhttps://phabricator.wikimedia.org/T185369EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p

[Pywikipedia-bugs] [Maniphest] [Closed] T185296: TestDryPageGenerator DeprecationWarning: Instead of using kwargs from Request.__init__, parameters for the request to the API should be added via the "

Dalba closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T185296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik238

[Pywikipedia-bugs] [Maniphest] [Updated] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

Dalba added a parent task: T72987: Python 2.6 issues (tracking). TASK DETAILhttps://phabricator.wikimedia.org/T185369EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidaslam, MayS, Mdupont, JJMC89

[Pywikipedia-bugs] [Maniphest] [Updated] T72987: Python 2.6 issues (tracking)

Dalba added a subtask: T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found. TASK DETAILhttps://phabricator.wikimedia.org/T72987EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: R

[Pywikipedia-bugs] [Maniphest] [Created] T185369: Some Python 2.6 builds are failing with DistributionNotFound: The 'setuptools_scm>=1.15.0' distribution was not found

Dalba created this task.Dalba added projects: Pywikibot-core, Pywikibot-tests.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONOccuring on both travis and appveyor: https://travis-ci.org/wikimedia/pywikibot/jobs/331083321#L1064 https://ci.appveyor.com/project/Ladsgroup/pywik

[Pywikipedia-bugs] [Maniphest] [Commented On] T185296: TestDryPageGenerator DeprecationWarning: Instead of using kwargs from Request.__init__, parameters for the request to the API should be added via

gerritbot added a comment. Change 405262 merged by jenkins-bot: [pywikibot/core@master] Fix or suppress some of the expected warnings during dry tests https://gerrit.wikimedia.org/r/405262TASK DETAILhttps://phabricator.wikimedia.org/T185296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T185317: AssertionError in test_invalid_isbn

divadsn added a subscriber: jayvdb.divadsn added a comment. In T185317#3913844, @Dalba wrote: In T185317#3913727, @divadsn wrote: @Dalba ok, that's a point, but now why the revert? That patch could be fixed with a follow-up, which would be simply adding a |Invalid ISBN found to the regex, why no

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

Dalba added a comment. In T185317#3913727, @divadsn wrote: @Dalba ok, that's a point, but now why the revert? That patch could be fixed with a follow-up, which would be simply adding a |Invalid ISBN found to the regex, why not instead? IMO, https://gerrit.wikimedia.org/r/#/c/399348/ was more de

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

divadsn added a comment. @Dalba ok, but now what? That patch could be fixed with a follow-up, which would be simply adding a |Invalid ISBN found to the regex, I don't see the need to revert it.TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/set

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

Dalba added a comment. All dependencies other than requests are optional. requirements.txt is a comprehensive list of recommended dependencies. Installing it ensures that the environment can run any pywikibot script properly. I think it's mostly intended for end users, developers might want to ins

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

divadsn added a comment. Afaik it's usually supposed to install all needed requirements from the requirements.txt using pip, but I may be wrong here.TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, diva

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

divadsn added a comment. Afaik it's usually supposed to install all needed requirements from the requirements.txt using pip, but I may be wrong here.TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, diva

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

Dalba added a comment. In T185317#3913465, @divadsn wrote: But isn't it a requirement to run Pywikibot as I can see in the requirements.txt? Not really, the only real requirement to run pywikibot is requests. Most of the other requirements are extras for specific scripts. See install_requires an

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

Albert221 added a comment. this shouldn't be marked as a bug to be fixed, but rather a bug to be solved by the user by installing the required module. +1TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba,

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

divadsn added a comment. Running on Windows, make sure you don't have python-stdnum installed. But isn't it a requirement to run Pywikibot as I can see in the requirements.txt? https://github.com/wikimedia/pywikibot/blob/master/requirements.txt#L54 In my opinion this shouldn't be marked as a bug

[Pywikipedia-bugs] [Maniphest] [Closed] T185317: AssertionError in test_invalid_isbn

Dalba closed this task as "Resolved".Dalba claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkmin

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

gerritbot added a comment. Change 405292 merged by jenkins-bot: [pywikibot/core@master] Revert "Replace assertRaises with assertRaisesRegex in isbn_tests.py" https://gerrit.wikimedia.org/r/405292TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/

[Pywikipedia-bugs] [Maniphest] [Updated] T185317: AssertionError in test_invalid_isbn

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordi

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

gerritbot added a comment. Change 405292 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] Revert "Replace assertRaises with assertRaisesRegex in isbn_tests.py" https://gerrit.wikimedia.org/r/405292TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENC

[Pywikipedia-bugs] [Maniphest] [Updated] T154281: [recurring] Replace assertRaises with assertRaisesRegex

gerritbot added a comment. Change 399348 restored by Dalba: Replace assertRaises with assertRaisesRegex in isbn_tests.py Reason: T185317 https://gerrit.wikimedia.org/r/399348TASK DETAILhttps://phabricator.wikimedia.org/T154281EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/email

[Pywikipedia-bugs] [Maniphest] [Commented On] T185317: AssertionError in test_invalid_isbn

Dalba added a comment. There is also another change request at https://gerrit.wikimedia.org/r/#/c/399348/. I had tested it on travis and it too seems to pass the travis tests. I'll probably will suggest to revert the one above.TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCESht

[Pywikipedia-bugs] [Maniphest] [Updated] T185317: AssertionError in test_invalid_isbn

Dalba added a comment. The issue has appear after 9a13055ce9c130d832ebd273681e7bf4d5dd71a7.TASK DETAILhttps://phabricator.wikimedia.org/T185317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, rafidas

[Pywikipedia-bugs] [Maniphest] [Created] T185317: AssertionError in test_invalid_isbn

Dalba created this task.Dalba added projects: Pywikibot-tests, Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONRunning on Windows, make sure you don't have python-stdnum installed. $ python -m unittest tests.isbn_tests.TestCosmeticChangesISBN.test_invalid_is

[Pywikipedia-bugs] [Maniphest] [Declined] T185302: unclosed SSLSocket ResourceWarning during dry tests

Dalba closed this task as "Declined".Dalba added a comment. We are already igoring disruptive resource warnings in WarningSourceSkipContextManager. But I'm not sure if it's a good idea to ignore all resource warnings, even the harmless ones like this. May reopen in the future if required.TASK DETAI

[Pywikipedia-bugs] [Maniphest] [Commented On] T185302: unclosed SSLSocket ResourceWarning during dry tests

gerritbot added a comment. Change 405262 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] Fix or suppress some of the expected warnings during dry tests https://gerrit.wikimedia.org/r/405262TASK DETAILhttps://phabricator.wikimedia.org/T185302EMAIL PREFERENCEShttps

[Pywikipedia-bugs] [Maniphest] [Updated] T185302: unclosed SSLSocket ResourceWarning during dry tests

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185302EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113

[Pywikipedia-bugs] [Maniphest] [Created] T185302: unclosed SSLSocket ResourceWarning during dry tests

Dalba created this task.Dalba added a project: Pywikibot-tests.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONhttps://integration.wikimedia.org/ci/job/pywikibot-core-tox-nose34-docker/722/console 10:26:37 WARNING: /usr/lib/python3.4/unittest/mock.py:667: ResourceWarning:

[Pywikipedia-bugs] [Maniphest] [Triaged] T185296: TestDryPageGenerator DeprecationWarning: Instead of using kwargs from Request.__init__, parameters for the request to the API should be added via the

Dalba triaged this task as "Lowest" priority. TASK DETAILhttps://phabricator.wikimedia.org/T185296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis,

[Pywikipedia-bugs] [Maniphest] [Commented On] T185296: TestDryPageGenerator DeprecationWarning: Instead of using kwargs from Request.__init__, parameters for the request to the API should be added via

gerritbot added a comment. Change 405262 had a related patch set uploaded (by Dalba; owner: Dalba): [pywikibot/core@master] TestDryPageGenerator: Fix the deprecated api.PageGenerator parameter https://gerrit.wikimedia.org/r/405262TASK DETAILhttps://phabricator.wikimedia.org/T185296EMAIL PREFERENCE

[Pywikipedia-bugs] [Maniphest] [Updated] T185296: TestDryPageGenerator DeprecationWarning: Instead of using kwargs from Request.__init__, parameters for the request to the API should be added via the

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dalba, gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113

[Pywikipedia-bugs] [Maniphest] [Created] T185296: TestDryPageGenerator DeprecationWarning: Instead of using kwargs from Request.__init__, parameters for the request to the API should be added via the

Dalba created this task.Dalba added a project: Pywikibot-tests.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONRunning tests.api_tests.TestDryPageGenerator issues the following warning: WARNING: /src/pywikibot/data/api.py:2221: DeprecationWarning: Instead of using kwargs f